Project

General

Profile

Actions
Copy link

Regression #15439

closed

Incorrect icon on collapsed dashboard widgets

Added by Steve Wheeler 8 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marcos M
Category:
Dashboard
Target version:
2.8.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.11
Release Notes:
Default
Affected Version:
2.7.2
Affected Architecture:
All

Description

A collapsed widget on the dashboard shows the '+' icon where the wrench icon should be.

This is a regression since 23.09.1

Files

Download all files
Screenshot from 2024-04-25 13-27-34.png (3.43 KB) Screenshot from 2024-04-25 13-27-34.png Steve Wheeler, 04/25/2024 12:35 PM
clipboard-202407290856-0pzka.png (15.1 KB) clipboard-202407290856-0pzka.png Jim Pingle, 07/29/2024 12:56 PM
Actions
Copy link
 #1

Updated by Jim Pingle 8 months ago

  • Project changed from pfSense Plus to pfSense
  • Category changed from Dashboard to Dashboard
  • Target version changed from 24.11 to 2.8.0
  • Affected Plus Version deleted (24.03)
  • Plus Target Version set to 24.07
Actions
Copy link
 #2

Updated by Jim Pingle 8 months ago

In source:src/usr/local/www/js/pfSenseHelpers.js#L486 the code that handles collapse/expand is adding/removing the fa-plus-circle/fa-minus-circle class and on the old Font Awesome setup it ignored the second one and used the first icon (the wrench) in all cases, but now for whatever reason it's ignoring the first one and using the last one but only in the collapsed state. The HTML/CSS involved here appears to be identical in both cases but the way Font Awesome behaves is not. So it's not a quick/easy fix as we hoped.

Actions
Copy link
 #3

Updated by Danilo Zrenjanin 7 months ago

  • Status changed from New to Confirmed

I can confirm this on:

24.03-RELEASE (amd64)
built on Wed Apr 24 17:38:00 UTC 2024
FreeBSD 15.0-CURRENT
Actions
Copy link
 #4

Updated by Jim Pingle 7 months ago

  • Plus Target Version changed from 24.07 to 24.08
Actions
Copy link
 #5

Updated by Kris Phillips 5 months ago

Tested on

24.08-DEVELOPMENT (amd64)
built on Thu Jul 18 6:00:00 UTC 2024
FreeBSD 15.0-CURRENT

Still present on the dev snapshots.

Actions
Copy link
 #6

Updated by Marcos M 5 months ago

  • Status changed from Confirmed to In Progress
  • Assignee set to Marcos M
Actions
Copy link
 #7

Updated by Marcos M 5 months ago

  • Affected Version set to 2.7.2
Actions
Copy link
 #8

Updated by Marcos M 5 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by dylan mendez 5 months ago

Can confirm patch fixes the issue on 24.08 devel.

Actions
Copy link
 #10

Updated by Jim Pingle 5 months ago

Looks good on the latest snapshot

Actions
Copy link
 #11

Updated by Jim Pingle 2 months ago

  • Plus Target Version changed from 24.08 to 24.11
Actions
Copy link

Also available in: Atom PDF