Regression #15540
closed
Cannot create new System Patches package custom entry on Plus 24.08/CE 2.8.0 Snapshots
Added by Jim Pingle 6 months ago.
Updated about 2 months ago.
Plus Target Version:
24.11
Affected Plus Version:
24.08
Description
At some point between May 14th snapshots and June 2nd snapshots, something broke the ability to create new System Patches package custom patch entries.
There is no error when saving but the new patch entry is not stored in the configuration. There is a configuration history entry but it does not show any changes to the system patches configuration.
Deleting a patch entry works as expected.
I'm not certain this is specific to this package, it may have been a more fundamental change, but so far it's the only place I've seen the problem manifest.
- Description updated (diff)
- Status changed from Confirmed to Pull Request Review
I'm not seeing this issue on the following version, which doesn't have the pull request above merged yet.
24.08-DEVELOPMENT (amd64)
built on Fri Jun 7 18:50:00 UTC 2024
FreeBSD 15.0-CURRENT
System_Patches 2.2.12
Without the patch from the PR it happens on all of mine, but all of mine had existing patch entries. It's possible it doesn't happen when adding the first entry, but only when adding additional entries. Either way, the patch fixes it.
I tested against the version which seems to have the patch applied:
24.08-DEVELOPMENT (amd64)
built on Fri Jun 21 0:35:00 UTC 2024
FreeBSD 15.0-CURRENT
However, I am having some troubles. After fetching a patch the buttons for apply/revert don't show up.
Please check.
- Status changed from Pull Request Review to Confirmed
Looks like the fetch action isn't storing anything in the patch entry, probably a similar issue to the problem creating a new entry.
If I manually make a new entry and add patch content it works but the fetch button isn't doing anything.
- Status changed from Confirmed to Feedback
Fixed with commit:4026d8132d10ec4702b1de6850c49b7723ec04e2.
- Status changed from Feedback to Resolved
Tested against:
24.08-DEVELOPMENT (amd64)
built on Tue Jun 25 6:00:00 UTC 2024
FreeBSD 15.0-CURRENT
It's working as expected.
The ticket can be resolved.
- % Done changed from 0 to 100
The fetch button is working properly here as well on the same system where it failed previously, so that issue does appear to be resolved.
- Plus Target Version changed from 24.08 to 24.11
Also available in: Atom
PDF