Project

General

Profile

Actions

Feature #2146

closed

Allow concurrent logins when using vouchers

Added by Igor Ybema almost 10 years ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Captive Portal
Target version:
Start date:
01/27/2012
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

When using vouchers it is not possible to use them more then once, even when enabling 'allow concurrent logins'. Using one vouchers more than once is sometimes required. For example when you rent meetingrooms and want to give them access by giving a voucher to the meetingholder.

Please also see http://forum.pfsense.org/index.php/topic,43100.0.html
A fix is easy:

1646,1649c1646,1652
< /* This user was already logged in so we disconnect the old one */
< captiveportal_disconnect($cpentry,$radiusservers,13);
< captiveportal_logportalauth($cpentry4,$cpentry3,$cpentry2,"CONCURRENT LOGIN - TERMINATING OLD SESSION");
< unset($cpdb[$sid]);
---

if (isset($config['captiveportal']['noconcurrentlogins'])) {
/* This user was already logged in so we disconnect the old one */
captiveportal_disconnect($cpentry,$radiusservers,13);
captiveportal_logportalauth($cpentry4,$cpentry3,$cpentry2,"CONCURRENT LOGIN - TERMINATING OLD SESSION");
unset($cpdb[$sid]);
}

Actions #2

Updated by Jim Pingle over 1 year ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

We can try this but I seem to remember a problem with this in the past. If I recall correctly it was issues with how time was counted against the voucher with multiple concurrent logins. Though I can't remember if it counted too fast (tracking both at once) or if it still worked based on the initial time of the first login. Definitely needs confirmation of how it actually operates either way.

Actions #3

Updated by Viktor Gurov over 1 year ago

Jim Pingle wrote:

We can try this but I seem to remember a problem with this in the past. If I recall correctly it was issues with how time was counted against the voucher with multiple concurrent logins. Though I can't remember if it counted too fast (tracking both at once) or if it still worked based on the initial time of the first login. Definitely needs confirmation of how it actually operates either way.

it working based on the initial time of the first login

Actions #4

Updated by Renato Botelho about 1 year ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho

Already resolved by #9432. Leaving it in feedback for confirmation

Actions #5

Updated by Steve Beaver about 1 year ago

  • Assignee changed from Renato Botelho to Igor Ybema
Actions #6

Updated by Viktor Gurov 11 months ago

  • Status changed from Feedback to Resolved

works as expected in all modes
2.5.0.a.20210104.0250

Actions

Also available in: Atom PDF