Feature #2146
closed
Allow concurrent logins when using vouchers
Added by Igor Ybema almost 13 years ago.
Updated almost 4 years ago.
Description
When using vouchers it is not possible to use them more then once, even when enabling 'allow concurrent logins'. Using one vouchers more than once is sometimes required. For example when you rent meetingrooms and want to give them access by giving a voucher to the meetingholder.
Please also see http://forum.pfsense.org/index.php/topic,43100.0.html
A fix is easy:
1646,1649c1646,1652
< /* This user was already logged in so we disconnect the old one */
< captiveportal_disconnect($cpentry,$radiusservers,13);
< captiveportal_logportalauth($cpentry4,$cpentry3,$cpentry2,"CONCURRENT LOGIN - TERMINATING OLD SESSION");
< unset($cpdb[$sid]);
---
if (isset($config['captiveportal']['noconcurrentlogins'])) {
/* This user was already logged in so we disconnect the old one */
captiveportal_disconnect($cpentry,$radiusservers,13);
captiveportal_logportalauth($cpentry4,$cpentry3,$cpentry2,"CONCURRENT LOGIN - TERMINATING OLD SESSION");
unset($cpdb[$sid]);
}
- Status changed from New to Pull Request Review
- Target version set to 2.5.0
We can try this but I seem to remember a problem with this in the past. If I recall correctly it was issues with how time was counted against the voucher with multiple concurrent logins. Though I can't remember if it counted too fast (tracking both at once) or if it still worked based on the initial time of the first login. Definitely needs confirmation of how it actually operates either way.
Jim Pingle wrote:
We can try this but I seem to remember a problem with this in the past. If I recall correctly it was issues with how time was counted against the voucher with multiple concurrent logins. Though I can't remember if it counted too fast (tracking both at once) or if it still worked based on the initial time of the first login. Definitely needs confirmation of how it actually operates either way.
it working based on the initial time of the first login
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
Already resolved by #9432. Leaving it in feedback for confirmation
- Assignee changed from Renato Botelho to Igor Ybema
- Status changed from Feedback to Resolved
works as expected in all modes
2.5.0.a.20210104.0250
Also available in: Atom
PDF