Project

General

Profile

Feature #4133

Add GUI setting for VLANs PCP

Added by Clement Barnier over 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Interfaces
Target version:
Start date:
12/20/2014
Due date:
% Done:

100%

Estimated time:

Description

Add support for optionally setting VLANs priority (PCP) through the GUI, saved as part of the xml configuration.

Suggested patches are attached (also include fix for #3737).

pf_pcp_git.diff (12.2 KB) pf_pcp_git.diff PHP interface patch (pfSense GIT) Clement Barnier, 12/20/2014 08:34 AM
pf_pcp_source.diff (12.5 KB) pf_pcp_source.diff Source patch Clement Barnier, 12/20/2014 08:34 AM
pf_pcp_tools.diff (1.24 KB) pf_pcp_tools.diff pfPorts patch (php55-pfSense-module) Clement Barnier, 12/20/2014 08:34 AM
pf_pcp_git.diff (12.2 KB) pf_pcp_git.diff Corrected PHP interface patch (missing brackets) Clement Barnier, 01/03/2015 05:33 AM

Associated revisions

Revision 329b8d92 (diff)
Added by Luiz Souza over 3 years ago

Make interface_vlan_configure() compatible with the new pfSense PHP module.

Allow the VLAN pcp setting.

While here, fix a bug when editing a VLAN. Make sure it is destroyed before it can be recreated.

Pull Request #1757. Ticket #4133

Revision cc345482 (diff)
Added by Luiz Souza over 3 years ago

Add support to set the VLAN PCP (priority code point) in GUI. Pull Request #1757. Ticket #4133

History

#1 Updated by Renato Botelho over 4 years ago

  • Target version changed from 2.2 to 2.2.1

Target to 2.2.1 for future review, 2.2 is now in RC state

#2 Updated by Clement Barnier over 4 years ago

I just realized that the blob in the git diff regarding configuration compatibility has a few missing brackets. I guess I decided to change it at the last minute.
Tested on 2.2-RC without problem.

#3 Updated by Jim Thompson over 4 years ago

  • Assignee set to Renato Botelho

#4 Updated by Chris Buechler over 4 years ago

  • Target version changed from 2.2.1 to 2.2.2

#5 Updated by Chris Buechler over 4 years ago

  • Target version changed from 2.2.2 to 2.2.3

#6 Updated by Chris Buechler about 4 years ago

  • Target version changed from 2.2.3 to 2.3

#7 Updated by Chris Christensen about 4 years ago

I tested this patch using 2.2.3-Release:

I used the build instructions from: https://forum.pfsense.org/index.php?topic=83785.0 to generate an image.

This all appears to have worked very nicely - the UI is exposed and the added functionality appears to function. For me was related to Google Fiber QoS ( https://support.google.com/fiber/faq/3333053?hl=en ) that requires 802.1Q VLAN pcp set to 2. (otherwise upload speed is rate-limited)

As for the test, the results speak:

#8 Updated by Chris Buechler almost 4 years ago

Thanks Chris! We'll get this integrated for 2.3.

#9 Updated by Renato Botelho over 3 years ago

  • Assignee changed from Renato Botelho to Luiz Souza

Luiz, can you please check kernel patch available at https://github.com/pfsense/pfsense-tools/pull/6?

#10 Updated by Luiz Souza over 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

All the parts are committed, should work out-of-box in 2.3.

#11 Updated by Chris Buechler over 3 years ago

This looks to work fine. It's configured correctly, and the appropriate PCP mark is on the traffic.

Chris or anyone else with a real world scenario here, could you please test the latest 2.3 snapshot from https://snapshots.pfsense.org and report back?

#12 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

Chris confirmed via email that this worked fine (aside from hitting #5453 and having other issues from that)

Also available in: Atom PDF