Project

General

Profile

Actions

Bug #4561

closed

siproxd listening port redirect rule pulling wrong tag from <siproxdsettings> (config.xml)

Added by Mark Bailey about 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
siproxd
Target version:
-
Start date:
03/28/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
All
Affected Plus Version:
Affected Architecture:

Description

I use siproxd a little differently than most. I set its listen port to 5070 and have all my SIP devices set to UDP on 5070. Reason is that I also have an inside Asterisk server that needs 5060 open (not intercepted). I have some outside PBX connections to attach to as well, and siproxd on 5070 handles these perfectly without NAT concerns. What I discovered was that even with siproxd's port set to 5070, port 5060 was still being intercepted. Examination of Line 83 in /usr/local/pkg/siproxd.inc exposed the problem:

$port = ($siproxd_conf['proxy_port'] ? $siproxd_conf['proxy_port'] : 5060);

It is pulling 'proxy_port' from <installedpackages><siproxdsettings><config> in config.xml, whereas the actual tag saved in this location is:

&lt;port&gt;5070&lt;/port&gt;

As the $port line above defaults to 5060 if <proxy_port> is undefined, the redirect rule insert is always redirecting on 5060 regardless of what port siproxd is actually listening on. This condition has existed as far back as 2.0.x, but as few use siproxd as I do, I'm not surprised that this issue has not surfaced before now.

Actions #1

Updated by Mark Bailey about 9 years ago

I have confirmed that changing Line 83 to:

$port = ($siproxd_conf['port'] ? $siproxd_conf['port'] : 5060);

corrects this issue.

Actions #2

Updated by Phillip Davis about 9 years ago

It will be easy if your go to https://github.com/pfsense/pfsense-packages
Find the file, click the pencil tool to edit, save, follow the bouncing ball to make a pull request.
For small things like this it is very easy to just use the online GitHub. Then the devs can easily review the diff and take the code.
For packages, you should also increment the package version - look in pkg_config.10.xml for packages that go with FreeBSD 10.x and pfSense 2.2.x and also edit pkg_config.8.xml pkg_config.8.xml.amd64 to change the package version displayed on FreeBSD 8.3 pfSense 2.1.x systems.

Actions #3

Updated by Aleksei Aksenov about 9 years ago

Good day! Tell me, is it possible to expand the functions of the package ,siproxd, so that he could translate the protocol h323?

Actions #5

Updated by Renato Botelho almost 9 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Pull request has been merged

Actions #6

Updated by Chris Palmer almost 9 years ago

Thank You!

Saw this and reported on the forum back in 2011.

https://forum.pfsense.org/index.php?topic=43213.msg223536#msg223536

I can make some changes tonight and confirm.

Actions #7

Updated by Jim Thompson over 8 years ago

  • Assignee set to Chris Buechler

assigned to cmb, because this has been in feedback for 4 months now, and we've released since then.

I'd like to know if it's fixed, so we can mark it 'resolved'.

Actions #8

Updated by Kill Bill over 8 years ago

Actions #9

Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to Resolved

thanks

Actions

Also available in: Atom PDF