pfSense

After running the wizard and changing the LAN IP it calculates a new DHCP range for LAN. Then I get 3 notices about "Invalid DHCP pool" for the new DHCP pool range, complaining that it is not in the OLD LAN subnet. I guess the code there is implementing some DHCP changes before it switches the LAN IP. I will have a look and see if the whole implementation of LAN IP plus LAN DHCP pool range can be done together to avoid ever having an inconsistent run-time state.

See pull request https://github.com/pfsense/pfsense/pull/1935 for a possible solution to this.

Actually in theory this should never happen, the sequence of "reload all" at the end of the setup wizard should never pass through inconsistent stages where the implemented interface IP address/CIDR settings and DHCP pools are not matched. But that looks like another big job to sort out exactly what goes on through each stage of that.

Also pull request https://github.com/pfsense/pfsense/pull/1938 has a solution with a bit more logging.
Take your pick.

The fix in pull request 1938 works great for me, thanks Phil, we'll get that imported.