Bug #5811
closed
Packages try to highlight some of their text
100%
Description
For example the Notes package highlights the word "Notes" next to the text box that displays/edits the note.
In 2.2.6 that works fine.
In 2.3-BETA it shows:
"<strong>Notes</strong><br /><br />"
I guess that the package is putting some HTML in the literal string used for the field text, but that in 2.3-BETA HTML like that is being escaped (to guard against packages doing naughty things?)
Choose a solution: Get rid of the embedded HTML in packages like Notes, or change the package parsing code to allow certain HTML things that are considered harmless.
Files
| NotesEdit23beta.png (8.49 KB) NotesEdit23beta.png | |||
| NotesEdit226.png (5.73 KB) NotesEdit226.png |
Updated by Renato Botelho almost 9 years ago
- Status changed from New to Feedback
Jim Pingle already removed the HTML tags from field
Updated by Jim Pingle almost 9 years ago
It's best to just take out the HTML or, if it's required, move it to a <sethelp> tag which works like an extended description in the case of packages.
I removed that bunk HTML from the Notes package. It appears to have been trying to signify that the field was required, but that's what the <required/> tag is for, so I dropped that in as well.
Might have to try to work up a way to seek out other packages with similar issues. Though I have already gone through the bigger ones I converted, some of the smaller XML-only packages have seen less attention.
Updated by 
Updated by Jim Pingle almost 9 years ago
- Status changed from Feedback to Resolved
- % Done changed from 0 to 100
I grepped and searched through the packages and fixed up all the instances I could find. If any more turn up, feel free to reopen.