Project

General

Profile

Actions
Copy link

Bug #6044

closed
JV JD

system>monitoring tooltip unit "null" for some graphs

Bug #6044: system>monitoring tooltip unit "null" for some graphs

Added by jeroen van breedam over 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jared Dillard
Category:
RRD Graphs
Target version:
2.3.2
Start date:
03/30/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3.x
Affected Architecture:

Description

JD Updated by Jared Dillard over 10 years ago Actions
Copy link
 #1

  • Status changed from New to Feedback
  • Target version set to 2.3
  • Affected Version set to 2.3

JV Updated by jeroen van breedam over 10 years ago Actions
Copy link
 #2

@jared don't forget the same applies to queues/queuedrops

DB Updated by David Burns over 10 years ago Actions
Copy link
 #3

Unit "null" also showing for NTP metrics

As per https://forum.pfsense.org/index.php?topic=107790.msg608787#msg608787

Thanks

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Confirmed

I fixed the NTP portion.

Unless I'm missing some easier way, getting rid of the "null" in queues and queuedrops is painful and problematic. You'd need one of the case instances for every queue name (which is user-configurable), like: 

+               case "qInternet":
+                       $unit_acronym = "drops";
+                       break;

Except it's drops in queuedrops, but qInternet in queues is bits per second.

Unless I'm missing an easy way to fix that, I'd rather release 2.3 with "null" there than introduce the complexity required to fix it at this stage.

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #5

  • Target version changed from 2.3 to 2.3.1

JV Updated by jeroen van breedam over 10 years ago Actions
Copy link
 #6

@Chris Buechler: you can also set the unit for an RRD-graph/file instead of setting it for an individual value, inside the rrd-file

now that you mentioned what kind of "units" queues/queuedrops uses, i tried the PR below. This seems to work... but needs testing by someone who is actually shaping.
see https://github.com/pfsense/FreeBSD-ports/pull/102

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #7

  • Target version changed from 2.3.1 to 2.3.2

JD Updated by Jared Dillard over 10 years ago Actions
Copy link
 #8

  • Status changed from Confirmed to Feedback

CB Updated by Chris Buechler about 10 years ago Actions
Copy link
 #9

  • Status changed from Feedback to Resolved
  • Affected Version changed from 2.3 to 2.3.x

fixed

RB Updated by Renato Botelho about 10 years ago Actions
Copy link
 #10

  • Affected Version changed from 2.3.x to 2.3

works

RB Updated by Renato Botelho about 10 years ago Actions
Copy link
 #11

  • Affected Version changed from 2.3 to 2.3.x
Actions
Copy link

Also available in: Atom