Bug #6044: system>monitoring tooltip unit "null" for some graphs - pfSense - pfSense bugtracker

Actions

Copy link

Bug #6044

closed

system>monitoring tooltip unit "null" for some graphs

Added by jeroen van breedam over 8 years ago. Updated over 8 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jared Dillard

Category:

RRD Graphs

Target version:

2.3.2

Start date:

03/30/2016

Due date:

% Done:

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.3.x

Affected Architecture:

Description

https://github.com/pfsense/FreeBSD-ports/pull/88

Actions

Copy link

Updated by Jared Dillard over 8 years ago

Status changed from New to Feedback
Target version set to 2.3
Affected Version set to 2.3

Actions

Copy link

Updated by jeroen van breedam over 8 years ago

@jared don't forget the same applies to queues/queuedrops

Actions

Copy link

Updated by David Burns over 8 years ago

Unit "null" also showing for NTP metrics

As per https://forum.pfsense.org/index.php?topic=107790.msg608787#msg608787

Thanks

Actions

Copy link

Updated by Chris Buechler over 8 years ago

Status changed from Feedback to Confirmed

I fixed the NTP portion.

Unless I'm missing some easier way, getting rid of the "null" in queues and queuedrops is painful and problematic. You'd need one of the case instances for every queue name (which is user-configurable), like:

+               case "qInternet":
+                       $unit_acronym = "drops";
+                       break;

Except it's drops in queuedrops, but qInternet in queues is bits per second.

Unless I'm missing an easy way to fix that, I'd rather release 2.3 with "null" there than introduce the complexity required to fix it at this stage.

Actions

Copy link

Updated by Chris Buechler over 8 years ago

Target version changed from 2.3 to 2.3.1

Actions

Copy link

Updated by jeroen van breedam over 8 years ago

Chris Buechler: you can also set the unit for an RRD-graph/file instead of setting it for an individual value, inside the rrd-file

now that you mentioned what kind of "units" queues/queuedrops uses, i tried the PR below. This seems to work... but needs testing by someone who is actually shaping.
see https://github.com/pfsense/FreeBSD-ports/pull/102

Actions

Copy link