Project

General

Profile

Bug #6044

system>monitoring tooltip unit "null" for some graphs

Added by jeroen van breedam over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
RRD Graphs
Target version:
Start date:
03/30/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3.x
Affected Architecture:

History

#1 Updated by Jared Dillard over 3 years ago

  • Status changed from New to Feedback
  • Target version set to 2.3
  • Affected Version set to 2.3

#2 Updated by jeroen van breedam over 3 years ago

@jared don't forget the same applies to queues/queuedrops

#3 Updated by David Burns over 3 years ago

Unit "null" also showing for NTP metrics

As per https://forum.pfsense.org/index.php?topic=107790.msg608787#msg608787

Thanks

#4 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Confirmed

I fixed the NTP portion.

Unless I'm missing some easier way, getting rid of the "null" in queues and queuedrops is painful and problematic. You'd need one of the case instances for every queue name (which is user-configurable), like:

+               case "qInternet":
+                       $unit_acronym = "drops";
+                       break;

Except it's drops in queuedrops, but qInternet in queues is bits per second.

Unless I'm missing an easy way to fix that, I'd rather release 2.3 with "null" there than introduce the complexity required to fix it at this stage.

#5 Updated by Chris Buechler over 3 years ago

  • Target version changed from 2.3 to 2.3.1

#6 Updated by jeroen van breedam over 3 years ago

Chris Buechler: you can also set the unit for an RRD-graph/file instead of setting it for an individual value, inside the rrd-file

now that you mentioned what kind of "units" queues/queuedrops uses, i tried the PR below. This seems to work... but needs testing by someone who is actually shaping.
see https://github.com/pfsense/FreeBSD-ports/pull/102

#7 Updated by Chris Buechler over 3 years ago

  • Target version changed from 2.3.1 to 2.3.2

#8 Updated by Jared Dillard over 3 years ago

  • Status changed from Confirmed to Feedback

#9 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved
  • Affected Version changed from 2.3 to 2.3.x

fixed

#10 Updated by Renato Botelho over 3 years ago

  • Affected Version changed from 2.3.x to 2.3

works

#11 Updated by Renato Botelho over 3 years ago

  • Affected Version changed from 2.3 to 2.3.x

Also available in: Atom PDF