Bug #6044
closed
- Status changed from New to Feedback
- Target version set to 2.3
- Affected Version set to 2.3
@jared don't forget the same applies to queues/queuedrops
- Status changed from Feedback to Confirmed
I fixed the NTP portion.
Unless I'm missing some easier way, getting rid of the "null" in queues and queuedrops is painful and problematic. You'd need one of the case instances for every queue name (which is user-configurable), like:
+ case "qInternet":
+ $unit_acronym = "drops";
+ break;
Except it's drops in queuedrops, but qInternet in queues is bits per second.
Unless I'm missing an easy way to fix that, I'd rather release 2.3 with "null" there than introduce the complexity required to fix it at this stage.
- Target version changed from 2.3 to 2.3.1
Chris Buechler: you can also set the unit for an RRD-graph/file instead of setting it for an individual value, inside the rrd-file
now that you mentioned what kind of "units" queues/queuedrops uses, i tried the PR below. This seems to work... but needs testing by someone who is actually shaping.
see https://github.com/pfsense/FreeBSD-ports/pull/102
- Target version changed from 2.3.1 to 2.3.2
- Status changed from Confirmed to Feedback
- Status changed from Feedback to Resolved
- Affected Version changed from 2.3 to 2.3.x
- Affected Version changed from 2.3.x to 2.3
- Affected Version changed from 2.3 to 2.3.x
Also available in: Atom