Bug #6044
closedsystem>monitoring tooltip unit "null" for some graphs
0%
Updated by Jared Dillard over 8 years ago
- Status changed from New to Feedback
- Target version set to 2.3
- Affected Version set to 2.3
Updated by jeroen van breedam over 8 years ago
@jared don't forget the same applies to queues/queuedrops
Updated by David Burns over 8 years ago
Unit "null" also showing for NTP metrics
As per https://forum.pfsense.org/index.php?topic=107790.msg608787#msg608787
Thanks
Updated by Chris Buechler over 8 years ago
- Status changed from Feedback to Confirmed
I fixed the NTP portion.
Unless I'm missing some easier way, getting rid of the "null" in queues and queuedrops is painful and problematic. You'd need one of the case instances for every queue name (which is user-configurable), like:
+ case "qInternet": + $unit_acronym = "drops"; + break;
Except it's drops in queuedrops, but qInternet in queues is bits per second.
Unless I'm missing an easy way to fix that, I'd rather release 2.3 with "null" there than introduce the complexity required to fix it at this stage.
Updated by Chris Buechler over 8 years ago
- Target version changed from 2.3 to 2.3.1
Updated by jeroen van breedam over 8 years ago
Chris Buechler: you can also set the unit for an RRD-graph/file instead of setting it for an individual value, inside the rrd-file
now that you mentioned what kind of "units" queues/queuedrops uses, i tried the PR below. This seems to work... but needs testing by someone who is actually shaping.
see https://github.com/pfsense/FreeBSD-ports/pull/102
Updated by Chris Buechler over 8 years ago
- Target version changed from 2.3.1 to 2.3.2
Updated by Jared Dillard about 8 years ago
- Status changed from Confirmed to Feedback
This should be fixed in PR141 https://github.com/pfsense/FreeBSD-ports/pull/141
Updated by Chris Buechler about 8 years ago
- Status changed from Feedback to Resolved
- Affected Version changed from 2.3 to 2.3.x
fixed
Updated by Renato Botelho about 8 years ago
- Affected Version changed from 2.3 to 2.3.x