Bug #6137
closed
- Assignee set to Chris Buechler
- Assignee changed from Chris Buechler to Renato Botelho
- Project changed from pfSense Packages to pfSense
- Subject changed from Haproxy fails after 2.2.x to 2.3 upgrade to Old package inc files may cause problems post-upgrade
- Category changed from haproxy to Package System
- Status changed from New to Confirmed
The problem this causes is one of the old haproxy*.inc files make filter_configure_sync hang forever. So it kills the entire system until you remove those inc files.
We probably ought to whack all of the inc files in /usr/local/pkg with the exception of those in base in post-upgrade unless Renato has a better idea. That will prevent the haproxy issue, and possibly any number of other post-upgrade issues related to old package inc files.
Moving to base and package system because it's possibly an issue with much more than haproxy and should have a general fix.
- Status changed from Confirmed to Feedback
- % Done changed from 0 to 100
The upgrade log shows it doing the package uninstall as configured, and it's correctly reinstalled post-upgrade, but it leaves behind the .inc files in /usr/local/pkg/ so it doesn't fix the root issue here.
Also no doubt many inc files hanging around out there that aren't part of an installed package. After uninstalling the packages, it should rm /usr/local/pkg/* minus the files in base.
Basic example config attached for haproxy. Restore to 2.2.6, upgrade to 2.3.1 snapshot. This particular config, having the .inc files hanging around there doesn't hurt anything. But their presence in /usr/local/pkg/ is what will break with many configs.
It was my fault, I forgot part of the code commented out. Fixed now.
- Status changed from Confirmed to Feedback
I think I have two firewalls still running 2.2.x, so I should be able to test in a "real world" scenario.
Can you please advise when this fix hits the public website, and/or provide an upgrade URL I can test with?
(I probably won't be able to do a test upgrade until Tuesday at the earliest... and I'm only going to take one shot at upgrading each firewall, because they're both production systems. At least one of them is i386, not amd64, if that makes any difference.)
Adam Thompson wrote:
I think I have two firewalls still running 2.2.x, so I should be able to test in a "real world" scenario.
Can you please advise when this fix hits the public website, and/or provide an upgrade URL I can test with?
(I probably won't be able to do a test upgrade until Tuesday at the earliest... and I'm only going to take one shot at upgrading each firewall, because they're both production systems. At least one of them is i386, not amd64, if that makes any difference.)
You can get 2.3.1-DEVELOPMENT snapshots at https://snapshots.pfsense.org/. All snapshots newer than 20160606-0900 will contain the fix.
the removal part was fine. The reinstall post-upgrade wasn't working until my last commit. Leaving to verify once that hits a snapshot.
It passed on all my tests too
- Status changed from Feedback to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by