Bug #6175
closed
- Category set to Rules / NAT
- Status changed from New to Feedback
- Assignee deleted (
Jim Pingle)
- Target version deleted (
2.3.1)
See the thread. I can't reproduce it as-is. Needs more info before a ticket can be opened or a fix pursued, we have to be able to reproduce it to confirm it's fixed.
i've just updated the thread after creating this ticket.
- Assignee set to Anonymous
- Target version set to 2.3.1
- Affected Version set to 2.3
I wonder if this is as easy as
--- src/usr/local/www/firewall_rules_edit.php
+++ src/usr/local/www/firewall_rules_edit.php
@@ -194,7 +194,7 @@
if (isset($a_filter[$id]['floating']) || $if == "FloatingRules") {
$pconfig['floating'] = $a_filter[$id]['floating'];
if (isset($a_filter[$id]['interface']) && $a_filter[$id]['interface'] <> "") {
- $pconfig['interface'] = $a_filter[$id]['interface'];
+ $pconfig['interface'] = explode(",", $a_filter[$id]['interface']);
}
}
@@ -1205,7 +1205,7 @@
$section->addInput($input = new Form_Select(
'interface',
'Interface',
- explode(",", $pconfig['interface']),
+ $pconfig['interface'],
build_if_list(),
true
))->setHelp('Choose the interface(s) for this rule.');
This will place the explode() call in a more appropriate place and hopefully do the trick.
Jorge M. Oliveira wrote:
I wonder if this is as easy as
[...]
This will place the explode() call in a more appropriate place and hopefully do the trick.
maybe, i'm not much of a coder & haven't tried your patch. i assume you have ;)
i put it below firewall_rules_edit.php#L441 because there $pconfig gets overwritten by $_post. (does $pconfig['interfaces'] survive?)
- Assignee changed from Anonymous to jeroen van breedam
Change suggested by Jorge M. Oliveira was found to be effective and has been merged.
Thanks Jeroen and Jorge.
Since this issue is difficult to reproduce, please confirm that the fix was effective.
seems fixed after gitsync. thanks all
- % Done changed from 0 to 100
- Status changed from Feedback to Resolved
Also available in: Atom
PDF