Project

General

Profile

Bug #7066

vmx(4) interfaces do not have ALTQ support on pfSense 2.4, they had ALTQ support on 2.3

Added by Jim Pingle 9 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Traffic Shaper
Target version:
Start date:
01/02/2017
Due date:
% Done:

100%

Affected version:
2.4
Affected Architecture:
amd64

Description

Attempting to configure traffic shaping on a pfSense 2.4 VMware VM with vmx NICs results in an error:

There were error(s) loading the rules: pfctl: vmx0: driver does not support altq - The line in question reads [0]: 

The same configuration works on pfSense 2.3.

If ALTQ support is removed from vmx and not coming back, we will need to remove vmx from the list of ALTQ-capable NICs and disable the shaper on upgrade if it is in use.

History

#1 Updated by Jim Pingle 9 months ago

  • Description updated (diff)

#2 Updated by Landon Timothy 9 months ago

For what it's worth, I saw the same behavior with igb interfaces after restoring a 2.3 config with a shaper.

#3 Updated by Greg Siemon 9 months ago

This appears to be caused by r263259 in FreeBSD 11 - Add Tx/Rx multiqueue support to vmx(4).

I believe that ALTQ does not support multiqueues and needs to be complied with the flag VMXNET3_LEGACY_TX flag enabled in order to get it working with ALTQ working again. See Forums posts details relating to ALTQ and IGB when multiqueue was enabled on that driver:

https://forum.pfsense.org/index.php?topic=122367.0

From the revised Makefile in FreeBSD 11 (https://svnweb.freebsd.org/base?view=revision&revision=263259):

# With VMXNET3_LEGACY_TX, the driver will use the non-multiqueue
35    # capable if_start interface.
36    #CFLAGS+= -DVMXNET3_LEGACY_TX

#4 Updated by Michael OBrien 9 months ago

I also see this on Hyper-V virtual NICs (not legacy). Perhaps this is a more generalized issue?

#5 Updated by Jim Thompson 9 months ago

  • Assignee set to Jim Pingle

Personally, I think ALTQ is dead.

#6 Updated by Chris Collins 9 months ago

Jim ALTQ does looks its on the a downward path but still pfSense uses it and the traffic shaper is an established key feature.

Looking at FreeBSD problem tickets is confusing, I find some saying igb needs patching, but I also found one where apparently a patch was commited to auto enable legacy queuing when ALTQ is compiled into kernel.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208409

Also to confirm igb is broken on pfSense 2.4 and ALTQ

#7 Updated by Jim Thompson 9 months ago

Chris Collins wrote:

Jim ALTQ does looks its on the a downward path but still pfSense uses it and the traffic shaper is an established key feature.

Looking at FreeBSD problem tickets is confusing, I find some saying igb needs patching, but I also found one where apparently a patch was commited to auto enable legacy queuing when ALTQ is compiled into kernel.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208409

Also to confirm igb is broken on pfSense 2.4 and ALTQ

ALTQ may be broken, but igb is likely fine.

That "patch" is a bodge, and I am unlikely to being in "legacy tx" support to pfsense.

#8 Updated by Jim Pingle 9 months ago

If there is any issue with igb, I can't replicate it here. On an SG-8860 with igb running 2.4, I can use ALTQ and it has multiple queues on the NICs.

The only type of NICs that fail in this way that I have tried so far are the vmx(4) interfaces from the original report.

#9 Updated by Greg Siemon 9 months ago

Jim Pingle wrote:

If there is any issue with igb, I can't replicate it here. On an SG-8860 with igb running 2.4, I can use ALTQ and it has multiple queues on the NICs.

The only type of NICs that fail in this way that I have tried so far are the vmx(4) interfaces from the original report.

I swapped the VM interfaces from VMXNET3 to EM1000 and no sign of the error anymore. There does appear to be a cosmetic bug in the Traffic Shaper interface which states "This firewall does not have any interfaces assigned that are capable of using ALTQ traffic shaping." Traffic is being assigned to queues and there are no errors in the system logs. Can't seem to see the bug report the OP refers to here (seeing the same with igb interfaces: https://forum.pfsense.org/index.php?topic=123639.0

#10 Updated by Jim Pingle 9 months ago

What page does the error show on, exactly? I can't replicate any problem where that error shows up on a firewall that is actually capable of using the shaper.

#11 Updated by Greg Siemon 9 months ago

Firewall-Traffic Shaper-By Interface. I didn't check the others. If I see traffic in the queues then AltQ should be working right?

#12 Updated by Jim Pingle 9 months ago

  • Assignee changed from Jim Pingle to Luiz Souza

OK I put that back on #7102, it's all unrelated to this ticket. This ticket is now (again) only for vmx(4) lacking ALTQ support. No other interface types are affected that I've found.

#13 Updated by Luiz Souza 8 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#14 Updated by Greg Siemon 8 months ago

Luiz Otavio O Souza wrote:

Should work now: https://github.com/pfsense/FreeBSD-src/commit/91384809a74dc98ef0d2a173718bd79bd77c13bb

Thanks. Will test as soon as the snapshots update (still on 29 Jan at the moment).

#15 Updated by Greg Siemon 8 months ago

Luiz Otavio O Souza wrote:

Should work now: https://github.com/pfsense/FreeBSD-src/commit/91384809a74dc98ef0d2a173718bd79bd77c13bb

Confirmed fixed here. No errors reported using ALTQ and 6 x VMXNET3 interfaces on ESXi 6.5.

#16 Updated by Luiz Souza 8 months ago

  • Status changed from Feedback to Resolved

Thanks!

Also available in: Atom PDF