Project

General

Profile

Bug #7813

Missing download statistics on captive portal with MAC filtering enabled

Added by Caio Plumbeo about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
Captive Portal
Target version:
Start date:
08/25/2017
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4
Affected Architecture:
All

Description

I'm testing the captive portal on 2.4 RC (updated to today) and I noticed that when MAC filtering is enabled the bytes received count is always 0. It works as expected when MAC filtering is disabled.

Inspecting the ipfw tables on the firewall shows:

--- table(test_auth_up), set(0) ---
10.0.0.11/32 08:00:27:bd:f8:bc 2208 2804 337280 1503655700
10.0.0.12/32 08:00:27:af:77:0c 2210 21611 2902308 1503662597

--- table(test_auth_down), set(0) ---
10.0.0.11/32 08:00:27:bd:f8:bc 2209 0 0 0
10.0.0.12/32 08:00:27:af:77:0c 2211 0 0 0

FWIW, reapplying 5f6825bbac6373a909651c90e8ca268242f6eedc ("Do not associate IP and MAC on down table"), which was reverted in e14c441bf9e1c922001180ff6cc02e0b4ef91723 ("Make rules that deal with IP+MAC pairs to be layer2 only") seems to fix the issue.

History

#1 Updated by Jim Thompson about 2 years ago

  • Assignee set to Renato Botelho

#2 Updated by Kill Bill about 2 years ago

See Bug #7833 and kindly re-instate the AWOL fix.

#3 Updated by Luiz Souza almost 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Fixed. Please try the next snapshot (will be available on tomorrow's snapshot).

#4 Updated by Vladimir Lind almost 2 years ago

2.4.1-DEVELOPMENT (amd64)
built on Sun Sep 24 21:37:23 CDT 2017

With enabled MAC filtering:

--- table(teagetgb_auth_up), set(0) ---
100.0.1.100/32 00:0c:29:01:9d:9e 2000 856 86377 1506351771
--- table(teagetgb_auth_up), set(0) ---
100.0.1.100/32 00:0c:29:01:9d:9e 2000 856 86377 1506351771

With disabled MAC filtering:

--- table(teagetgb_auth_up), set(0) ---
100.0.1.100/32 2000 544 57510 1506351895
--- table(teagetgb_auth_down), set(0) ---
100.0.1.100/32 2001 818 877195 1506351895

I see incrementing byte count in both cases

#5 Updated by Renato Botelho almost 2 years ago

  • Status changed from Feedback to Resolved

#6 Updated by Steve Wheeler almost 2 years ago

Confirmed:

[2.4.0-RC][root@checkpoint.stevew.lan]/root: ipfw table all list
--- table(cplan_auth_up), set(0) ---
192.168.75.10/32 98:5a:eb:11:5b:f5 2000 269 34650 1506357135
--- table(cplan_auth_down), set(0) ---
192.168.75.10/32 98:5a:eb:11:5b:f5 2001 234 114050 1506357135

[2.4.0-RC][root@checkpoint.stevew.lan]/root: ipfw table all list
--- table(cplan_auth_up), set(0) ---
192.168.75.10/32 2000 501 89160 1506357284
--- table(cplan_auth_down), set(0) ---
192.168.75.10/32 2001 592 535237 1506357284

Also available in: Atom PDF