Project

General

Profile

Bug #7972

Captive portals do not synchronize voucher data in both directions

Added by Dejan Milojevic almost 2 years ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Captive Portal
Target version:
2.4.3
Start date:
10/19/2017
Due date:
% Done:

100%

Estimated time:
Affected Version:
Affected Architecture:

Description

Hi,

I have a master and slave Captive portals. They synchronized well the data in both directions and immediately about active vouchers and voucher rolls.
After upgrading from 2.3 to 2.4 the situation is as follows:
- data is synchronized from the slave to the master immediately it seems, e.g. when you expire the ticket on the slave, it registers on the master. The other way around does not work.
- data is synchronized from the master to the slave only upon clicking on the save button on the Services>Captive Portal>Vouchers form.

Just FYI, I have applied the previous CP patch which brought back the functionality of testing and expiring the vouchers.

Thank you in advance for your help and support.

Associated revisions

Revision b8963db6 (diff)
Added by Renato Botelho over 1 year ago

Fix #7972

Rework the way Captive Portal vouchers are synchronized on HA:

- When voucher use is enabled on primary, do the same on secondary
- When voucher rolls are created/modified/deleted, sync to secondary
- When voucher is used, disconnected or expired, sync it in both
directions using HA main information on primary to secondary

History

#1 Updated by Jim Thompson almost 2 years ago

  • Assignee set to Renato Botelho
  • Target version set to 2.4.3

#2 Updated by Renato Botelho over 1 year ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Paighton Bisconer over 1 year ago

Tested on 2.4.3.a.20180305.1550

Was able to sync expired vouchers in both directions, resolved.

#4 Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to Resolved

#5 Updated by A FL 9 months ago

Renato wrote:

When voucher is used, disconnected or expired, sync it in both
directions using HA main information on primary to secondary

It seems that backward synchronization is still not working correctly.

xmlrpc_sync_voucher_details() of slave node returns false when a voucher is used/expired on slave, even if credentials of the master node are entered in the slave voucher page.

This happens because a global $cpzone; is missing in xmlrpc_sync_voucher_details(), causing the function to never get credentials entered in the voucher page.

Adding this global $cpzone; also seems to cause other issues (I am still investigating, but I am suspecting a CARP loop).

Also available in: Atom PDF