Bug #9072
closed
RRD graph mouseover information shows up as Mb when unit size is set to MB
Added by Luka Rojnica almost 6 years ago.
Updated almost 4 years ago.
Description
The dashboard traffic graph widget shows mouse over information in Mb when the unit size is set to MB
Files
i can confirm
the problem comes when you change from bytes to bits and then bits to bytes.
one temporary workaround :
change /usr/local/www/widgets/widgets/traffic_graphs.widget.php on line 280 :
window.size = <?=json_encode($tg_size)?>;
by
window.size = <?=json_encode($tg_size)?>*1;
This is because https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/js/traffic-graphs.js#L203 strict check an integer.
And the values comning from post are strings.
Should be casted at first stage, but need more changes to be clean.
- Assignee set to Jared Dillard
- Status changed from New to Feedback
- % Done changed from 0 to 100
It Works! ;)
tested on :
2.4.4-RELEASE-p2 (amd64)
built on Wed Dec 12 07:40:18 EST 2018
FreeBSD 11.2-RELEASE-p6
- Status changed from Feedback to Resolved
Thanks for digging into the problem and for testing the fix!
Jared Dillard wrote:
Thanks for digging into the problem and for testing the fix!
I'm running 2.4.4-RELEASE-p3 (amd64) and just noticed this same issue is still happening on my install. Do I need to do anything to fix it?
- Target version set to 2.5.0
I can't reproduce, did you toggle the Unit Size from Bits to Bytes and back again (hitting Save each time) on the Traffic Graphs widget and the units not match up?
Also available in: Atom
PDF