Bug #9097


ECL can't locate config.xml unless device is MBR-partitioned

Added by Adam Thompson about 3 years ago. Updated about 1 year ago.

Backup / Restore
Target version:
Start date:
Due date:
% Done:


Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:


Follow-on to #9089, but this one needs to be fixed in code, IMHO:

  • GPT devices show up as da1p1, not da1s1, so can't be used for ECL

(FYI: macOS's Disk Utility now formats devices as GPT by default, not MBR. Yay.)

The fix appears to be trivial, although I lack the skills and infrastructure to build - and thus test - this fix (sorry). I'd be happy to test a fresh spin of the install ISO, though, if you provide a URL.

I'm not too sure about git-diff's output here, but you can see the gist of the 1-line change regardless.

diff --git a/src/etc/ecl.php b/src/etc/ecl.php
index 30a64c5d43..05d519c952 100755
--- a/src/etc/ecl.php
+++ b/src/etc/ecl.php
@@ -37,7 +37,7 @@ function get_swap_disks() {

 function get_disk_slices($disk) {
        global $g, $debug;
-       $slices = glob("/dev/" . $disk . "s*");
+       $slices = glob("/dev/" . $disk . "[ps]*");
        $slices = str_replace("/dev/", "", $slices);
        return $slices;
Actions #1

Updated by Jim Pingle over 2 years ago

  • Category changed from Installer to Backup / Restore

Changing category, ECL is in base, not the installer, so it doesn't need changes to the ISO to test. You can leave the thumb drive plugged in on any boot to obtain a new config via ECL.

Actions #3

Updated by Jim Pingle over 1 year ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions #4

Updated by Renato Botelho over 1 year ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Danilo Zrenjanin about 1 year ago

Tested on :
2.5.0-DEVELOPMENT (amd64)
built on Mon Sep 07 19:04:05 EDT 2020

I was able to restore the config stored in /config.xml on an USB stick formatted using GUID Partition Map/MS-DOS (FAT) format.

Ticket resolved.

Actions #6

Updated by Danilo Zrenjanin about 1 year ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF