pfSense

Ticket #4652 actually return value as expected!

Fixes #4652 put workaround for bogus timestamp until real data are cosnumed.

Missin double equals in captiveportal.inc

Looking at where this is nested inside various if statements, I do not think this error did too much harm - only to the $mac['descr'] - in this particular code flow $username is not used for important stuff after this point....

Random text typos

that I noticed.

Do not leak firewall rules as well when (re)creating rules

Fix spell typo spotted by phil-davis

Use this generation now of committing pipes directly and only rules to put on ruleset to avoid memory pressure and the timelimit will than be enforced by the caller

Revert "Ticket #3932 Use array_map to get more parallelism when there are many entries. This makes it not reach the execution timeout with large entries."

This reverts commit 7077addc5a5058fab4b4dc7678270c1000d342c9.

Actually improve the previous resource leak commit since the function is there but it was not being used during init_rules process.

• Try to autodetect if the execution limit needs to be raised on big number of passthrough entries.
  Set the time limit to 0 and restore it back to default value when this is detected.

• Do not leak pipes when reloading ruleset for CP since this will consume available descriptors....

Ticket #3932 Use array_map to get more parallelism when there are many entries. This makes it not reach the execution timeout with large entries.

Fix inherent issues with isset and empty values set as true by our parser. This made the piep configuration to be wrong at least for passthrough entries. Ticket #3932

Correctly call function for retrieving stats from ipfw. Fixes #4131

Correct issue with not reloading CP properly on calling interface configure.

Do not apply bw limits if the setting is not enabled in CP. Though still respect radius attributes for now with this setting. Resolves #4127

Rather than set the g['booting'] on globals provide a function to test for that doing the right checks

Ticket #4007, properly pass the table number here to retrieve the status.

Shorten up the MAC pass-through descr. It was redundant, and for those with huge numbers of auto-added MAC passthrough entries, it adds up to a significant amount of config space (adding to delays when launching CP). helps Ticket #3932

Use the name entry now that there is a definition for it

Subnet parameter is mandatory for pfSense_ipfw_Tableaction(), add where it's missing

Pass zone id to pfSense_ipfw_getTablestats(), should fix #3990

don't duplicate $message in CP log entries

Fixes #3938. Do more error checking.

Ticket #3932 For more than 100 entries create pipes in line with the rules file to speedup the process

Convert almost all /sbin/sysctl calls to php functions

Bring the code of captiveportal up to speed with its module counterpart requirments

Update SCRIPT tags.

Add CDATA sections to SCRIPT tags in various files

Fix http and https port for cpzone

Use global cpzoneid variable

Drop double $$ from variable name

Remove redundant set

Migrate captive portal code to SQLite3 php module

Correct the ridirection URL to unbreak ones passed through Radius attributes and repsect user choices. Reported-by: Antoine Guillemot

Add nohttpsforwards option to captive portal

GC unused code and do not set this to 0 for now since it is not anymore relevant

Correct typo on function name that has slipped unnoticed. Reported-by: https://forum.pfsense.org/index.php?topic=74688.0

Put the fix to be more generic to prevent any other leak possible in the long run. Fixes #3062

Update captiveportal.inc

Release unused pipeno when client is already authenticated.

Bug #3062

Merge pull request #1031 from ayvis/master-br-patch

replaced uppercase html tags with lowercase

Fixes #3543, correct the typo in spelling

While here escape the passed valuye to avoid problems with input

Somehow these got changed to /usr/local/sbin/ipfw instead of /sbin/ipfw

Fix this for master

Fix deletion of ipfw rules and pipes for passthru mac, it fixes #3538

replaced uppercase html tags with lowercase
js files saved as UTF-8 / LF
language="JavaScript" deprecated, replaced with type="text/javascript"

Merge branch 'master-br' of https://github.com/ayvis/pfsense into ayvis-master-br

standardize URLs

xhtml Compliance
replaced <br>, <br/> and </br> with <br />

Properly compile the query to insert the values. Pointy-hat: myself. While here respect the redirurl when passed to portal_allow and use proper function to do redirection.

If set use the default bandwidth setting on the CP even for mac passthrough. Reported-by: https://forum.pfsense.org/index.php/topic,72761.0.html

Use the default bw specification if configured even for allowed ip and hostname.

Revert "Replaced gethostbyname() with gethostbynamel() to get a list of all IPs associated with the dns name and add them to the allowed list"

This change is not needed, filterdns will handle it.

This reverts commit d460371416d4e2cfef976d5a7616f63f6faa203f.

Merge pull request #904 from dv-user1/master

Replaced gethostbyname() with gethostbynamel() to get a list of all IPs ...

Consider setting of noconcurrent login for passthrough expiry of users. Fixes #3340

Use the 11th column for the radius context rather than overriding the interim interval field with it. Fixes #3447

Replaced gethostbyname() with gethostbynamel() to get a list of all IPs associated with the dns name and add them to the allowed list

Do not allocate the same pipe to everyone rather give each person its own!

Use empty here for testing even if the setting is unset

Merge manually 4fd85b115e2550969ddeadd43a2bc6dafff21779 3f2ae9d58f5ea3d9de175e8daa9c8902b3f23440 and e049c5e74f009430e22e446f149a552d00846d7a

Remove not relevant comment now. Also make the operation clear to avoid priority issues.

No need for a second rule forwarding http

Correct generation of lighty configuration with zoneid changing to lower that 4000 value

Catch up with mac needed for all operations in the table nowdays.

Properly create zones for the CP with the new command arguments and properly invoke ipfw for applying rules and other configuration options.

Prevent a possible division by zero. it fixes #3212

Remove unecessary blockedmacs db and read it directly from config

Do not add a ipfw rule to block mac since auth can take care of block or redirect it

Make sure db doesn't exist when start to configure macs

When block a MAC address, add it to a DB to make it possible to redirect it to a URL

Add action to auto created passtru mac rule

Remove unused variable $macdb

Make captiveportal_passthrumac_delete_entry() return rules instead of execute them as other similar functions do

Add action to auto created passtru mac rule

Add actions (block or pass) to Captive Portal passtrumac

Correct bandwidth assignment so the configuration is not reverted courtesy of ipfw(4) swapped arguments. Reported-by: http://forum.pfsense.org/index.php/topic,65069.0.html

Resolves #3121. Fix the command so it does perform correctly

Add Zone to the messages logged on syslog from CP to easy troubleshooting

Enable filtering on ipfw sysctl not dependent on ipfw module otherwise issue reported here http://forum.pfsense.org/index.php/topic,64412.0.html happens

Fix copy/pasto introduced in previous commit.

Implement proper releasing of pipes allocated based on CPzone. Keep track of which zone a pipe is and release those pipes during disabling/deleting of zone. Ticket #3062, Pull request #698

Use empty to cover all needed cases as suggested on #3062. Suggested from pull request #698

modified radius function to release the pineno

modified radius function to release the pinene if the client is not authenticated properly, and modified function captiveportal_get_next_dn_ruleno to initially takes the value 2000 for the first pipeno.

Correct variable used to delete symlinks and files delete from CP filemanager. Reported-by: http://forum.pfsense.org/index.php/topic,64016.0/topicseen.html. While here reduce some uneeded extra operations

Add used binary

Prevent errors from flowing up to the clients workspace and preventing functionality

Give the rules their own number and swap table numbers to correct statistics gathering.

Make sure some value is present here during boot

Consider CP allowed IPs for both directions. It will help ticket #2780

Make sure captiveportal section of config is an array, reported on ticket #2838

Revert "Merge pull request #417 from miken32/cp-database-fix"

It breaks customizations, it's not a good time for such big change.

This reverts commit 40c7b1a98bfdc61261154adaac5fdefc234ecb08, reversing
changes made to d896f86751bae79625197da6c80d709fdf185448.

Merge pull request #417 from miken32/cp-database-fix

Use associative array for captive portal database

self-explanatory now, no comments needed

while we're here, send named termination causes

use associative array for captive portal to prevent confusion, messiness, and abuse

only send Accounting-On at boot; can't tell if CP's being newly enabled or not

add support for RADIUS NAS accounting, fixes redmine feature request 2143

During bootup do not try to resolve hostnames filterdns will handle those

remove unsed getNasID function

Test that timeout value is bigger than 0

Cleanup some code