pfSense

Various updates to PR

1) convert echo to print, and add infobox, as requested in PR comments
2) If no identifiable line number, say so
3) EVAL gives an error message format that wasn't picked up, it is now. Test case - enter as the code: eval("X");
4) Warn that EVAL gives a "spurious" "error at line 1" as well, the real error is in the (...). See above test case for this....

add comment

typo

If user-entered PHP errors out, display the error line in context to help the user

If the user enters PHP in the command-line page, and it errors out, it's usually a typo or something minor. But the user is left with an error that references a /tmp file which doesn't exist at the point they read the message, a line number that's incorrect, and their input which doesn't display line numbers anyhow....

Remove some unused code from diag_command.php.

Revisions to GET/POST conversion limiting POSTs to save, apply, and delete functions - Diagnostics

Remove HTML from strings in diags files

Add security notes for privilege assignment pages

Suggested solution for Redmine 2247

Suppress error logging for Diag > Command Prompt so an error in user-entered code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702

Remove all calls to conf_mount_r* functions

Move copyright from ESF to Netgate

Move to Apache License 2.0

Review license / copyright on all files (final round)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Fix form submission fields

Submitting one form may lead to any other filled forms to be also submitted. This commit fixes this flaw

(diag > command prompt) page styling

Swap the colors on Diag > Command back. Executing is dangerous, hence the warning.

Changed the button colors and icons. The fa-terminal wasn't doing it for me :)

Fix typo

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

Renamed exec.php and edit.php