pfSense

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Redmine #5994 services_ntpd standardize advanced buttons

services_ntpd fix leaptext array key name

Use leaptext everywhere - some references were to leaptext and some to leaptxt, so it didn't work.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Advanced button consistency. Ticket #5965

Icon consistency in Repeatable blocks. Ticket #5965

Move NTP access restrictions to their own tab and add the ability to craft custom restrictions for arbitrary networks. Fixes #4463

Clarify text, ticket #4463

Quote the 1st parameter (constant name) when calling define()

Rename NTP tab to Settings to be more user friendly.

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

Merge pull request #2548 from phil-davis/diag-logs

Fixup old diag_logs references

Note: The shortcuts for upnp were not showing. This was because
shortcuts.inc only includes *.inc files from /usr/local/www/shortcuts
So I have renamed pkg_upnp.php to pkg_upnp.inc
I notice that some time in the past it used to be pkg_upnp.inc because...

More internationalization of servicescode

UI Consistency

1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g....

Cleanup some text and fix default behavior of some NTP options to match 2.2.6 and what the text described.

Remove $closehead variable

Remove unused variable $closehead

Code style services

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Create the required number of rows for NTP time servers

depending on how many are already defined in the config, making sure to always have a minimum of 1.

Also I used the constant NUMTIMESERVERS that was defined up the top of this file to control the loop that limits the number saved to 10....

Standardize Services NTP breadcrumbs

Oops

Fixed #5535

Type up SCRIPT tags

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Copyright updates Batch 2 of 3

Moved action-buttons in-line styling to pfSense.css

Javascript refine to hide Delete row button if there is only one row

Completes #5159
All duplicated JS removed to included file

Addresses #5159 by removing hide/show/disable/enable functions to included file

Fixed #5184

Fixed #5183 by converting to PHP table library

fix typo

services_ntpd.php - style fixes, fix typo

bootstrap, use require_once for classes/Form.class.php

Merge branch 'master' into bootstrap

Move main pfSense content to src/