pfSense

Cleanup some text and fix default behavior of some NTP options to match 2.2.6 and what the text described.

diag_tables give different message when last updated is unknown

and put the message in an infoblock_open so the user can close/open it as they wish.

Unset $entries array after clearing table

Without this, when the table is cleared then the "now old and gone" entries are being redisplayed the first time after the clear table happens.

Merge branch 'patch-6' of https://github.com/phil-davis/pfsense

• 'patch-6' of https://github.com/phil-davis/pfsense:
  status_logs_filter_summary make the info box open on initial page load
  status_logs_filter_summary make the info an info box

Merge pull request #2366 from NOYB/HTML_Compliance_-_Firewall_/_Schedules_/_Edit

Merge pull request #2373 from phil-davis/patch-3

Merge pull request #2374 from phil-davis/patch-5

Merge pull request #2371 from NewEraCracker/php-standards

status_logs_filter_summary make the info box open on initial page load

Fixed #5742

firewall_shaper_queues show green success after apply

After applying changes done from firewall_shaper_queues the message should be green-success.

diag_nanobsd whitespace

Just a bit of consistency while I am here.

Fix #5743, spell typo

SHow the infoblock on page load by specifying div id="infoblock_open"

Merge pull request #2364 from phil-davis/patch-5

Allow an infoblock to be displayed (not hidden) on page load y specifying id='infoblock_open'

Merge pull request #2370 from phil-davis/patch-11

Merge pull request #2368 from phil-davis/patch-8

Merge pull request #2367 from phil-davis/patch-7

Remove unused var in get_std_save_message

$d_sysrebootreqd_path seems to be a leftover from some ancient group of global $d_* vars that are no longer used.

Adjust more calls to print_info_box with unquoted strings

diag_tables change deleteall to clearall

This is part 1(a) only of https://redmine.pfsense.org/issues/5742
When the name is 'deleteall' then a popup comes saying "You may not delete the last row".

diag_nanobsd clean up handling of RO<->RW switching

1) When the Save button has been used to save the Permanent Read/Write setting then display a success message so the user knows it worked.
2) Move the "This setting is only temporary..." setHelp to be with the Read/Write status area, where it is in 2.2.6. That text was under the Permanent Read/Write checkbox, where it was not true....

HTML Compliance - Firewall / Schedules / Edit

The align attribute on the td element is obsolete. Use CSS instead.
The cellspacing attribute on the table element is obsolete. Use CSS instead.
The cellpadding attribute on the table element is obsolete. Use CSS instead....

status_logs_filter_summary make the info an info box

The existing behavior in 2.3-BETA is that if you close this box with the "x" it goes away completely and you cannot get it back.
Do we want to make it a "proper" info box that can be open and closed as desired? (like I did here)...

Config history info - make it an info box

Currently this display as an orange box. It seems to me that it is ordinary info and should be an info box (displaying in blue).
Note: with the current behavior the text is always displayed, after changing it to an info box the "i" icon has to be clicked to show the text....

Rationalize add and delete buttons for limiter GUI

1) When you click to add a new limiter or new queue, then the "Add new queue" button is displayed down the bottom. That is dumb - you are already adding and actually you need to enter the data and save first before adding something else....

firewall_shaper_vinterface URL reference

As far as I can see this URL should be self-referring - to firewall_shaper_vinterface.php
But I am having trouble finding how to test it, because whenever $pipe is set, so is $queue so I never get down the "else"....

Set secure_mode=yes in miniupnpd config. Ticket #5627

Open help link in a new tab

Change method name to setIsRequired() to match other similar methods

Merge pull request #2360 from NewEraCracker/regex-fixes

Fix all unterminated character class for pattern

Fix minor typos and correct code standards

Fixed #5723

Fix a bunch of text issues on DNS resolver advanced options

Added new method setRequired() (shortcut for setAttribute("required", true) )

Validate pppoe_subnet before use it in calculation. Ticket #5720

Change number of PPPoE users range to 1-255 and add an extra POST validation

Fix field name validation

Replace n_l2tp_units field by a drop-down from 1 to 255 and add a post validation just to be sure. Ticket #5720

Fix success message color

Fixed #5738

Merge pull request #2358 from NOYB/HTML_Compliance_-_Firewall_/_Rules_/_WAN

HTML Compliance - Firewall / Rules / WAN

Attribute name not allowed on element table at this point.
<table name="ruletable" class="table table-hover table-striped table-condensed">

Unclosed element div.
End tag for body seen, but there were unclosed elements.

Status logs common changes for nginx

Fixed #5633

Merge pull request #2353 from NOYB/HTML_Compliance_-_Firewall_/_NAT_/_Outbound_/_Edit

Add some more Bootsrap panels

"firewall_aliases.php"
- add gettext to the H2 tag
- remove debug code

"sevices_igmpproxy.php"
"services_pppoe.php"
"vpn_ipsec_keys.php"
"status_gateways.php"
"status_gateway_groups.php"
"statis_services.php"
"diag_arp.php"...

add dark beta theme

back out design changes for now

Remove errant bracket from character class.

Merge branch 'Status_-_System_Logs_-_Consolidation' of https://github.com/NOYB/pfsense

• 'Status_-_System_Logs_-_Consolidation' of https://github.com/NOYB/pfsense:
  Redmine #5731 Error when setting various system log settings from factory default config...

HTML Compliance - Form Button - HRef

The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.

Merge pull request #2343 from phil-davis/patch-3

clean up lighttpd

clean up lighttpd

Keeping the disable logging option. Revert "clean up lighttpd bits"

This reverts commit 9de0332dec955ec513b74be9361de72d12aa7245.

clean up lighttpd bits

HTML Compliance - Firewall / NAT / Outbound / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="source" id="source" type="text" pattern="[0-9, a-z, A-Z and .">
<input class="form-control" name="destination" id="destination" type="text" value="" pattern="[0-9, a-z, A-Z and .">...

Fix interface list

Improve error message when the user forget to "Apply"

Redmine #5731 Error when setting various system log settings from factory default config

From PR #2350 By Phil Davis

HTML Compliance - Status - System Logs - Firewall Summary View

The align attribute on the div element is obsolete. Use CSS instead.
Replace with bootstrap class="text-center".

Fixup AJAX stuff so dynamic updating works.

Move getGETPOSTsettingvalue function to be more centrally located in guiconfig.inc.

Rename functions per Phil suggestions.

s/miscellaneous_common_code/status_logs_common_code/
s/build_if_list/status_logs_build_if_list/

As for getGETPOSTsettingvalue I'm open to it going anywhere that makes sense. Would be nice not to need too many additional inc's to get it though. Anything in guiconfig.inc or filter_logs.inc hierarchy shouldn't require anything additional.

Remove commented out test code.

Can' t do that here. Remove space between php tags.

Status - System Logs - Consolidate - Firewall Summary View

Update summary view log selection method to same method as firewall and system logs.

Status - System Logs - Consolidate - Firewall Dynamic View

Add advanced filtering to firewall dynamic view.
Add manage log to dynamic view.
Update dynamic view view log selection method to same method as firewall and system logs.

Status - System Logs - Consolidate - Common Functions

Factor common code section into to functions and place in include file.

getGETPOSTsettingvalue
 miscellaneous_common_code
 tab_array_logs_common

log_filter_form_system_submit
 filter_form_system

log_filter_form_firewall_submit...

Merge pull request #2352 from phil-davis/status_graph

Fixed #5733

Add back display description option for status_graph

The code that provides the data for this is already in
bandwidth_by_ip.php in both 2.2.* and master 2.3.
The description option is in the Display dropdown list in 2.2.*, but it
got missed in the bootstrap conversion and integration process....

Correct "noWrap" in text areas. (Function is not actually used by anyone, but it might as well work just in case.

Merge pull request #2351 from NOYB/HTML_Compliance_-_Firewall_/_NAT/_1_1_/_Edit

Redmine #5731 Error when setting various system log settings from factory default config

Forum https://forum.pfsense.org/index.php?topic=104762.0

HTML Compliance - Firewall / NAT/ 1:1 / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="src" id="src" type="text" pattern="[0-9, a-z, A-Z and .">
<input class="form-control" name="dst" id="dst" type="text" pattern="[0-9, a-z, A-Z and .">

Redmine #5728 Fix delete row button in Firewall Schedule Edit

The calls to delete_row() were going off to some other delete_row() function and not doing what was needed.
Give delete_row() here a unique name and it all works again.

Merge pull request #2347 from NOYB/HTML_Compliance_-_Firewall_/_NAT_/_Port_Forward_/_Edit

Merge pull request #2346 from NOYB/HTML_Compliance_-_Firewall_/_Aliases_/_Edit

Merge pull request #2345 from NOYB/HTML_Compliance_-_Services_Status_Widget

HTML Compliance - Firewall / NAT / Port Forward / Edit

Attribute min/max not allowed on element input at this point.
<input class="form-control" name="srcbeginport_cust" id="srcbeginport_cust" type="text" value="any" min="1" max="65536">
<input class="form-control" name="srcendport_cust" id="srcendport_cust" type="text" value="any" min="1" max="65536">...

Fix reading of server list on page load

Fixed #5724

HTML Compliance - Firewall / Aliases / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="address0" id="address0" type="text" value="" pattern="[0-9, a-z, A-Z and ." placeholder="Address">

HTML Compliance - Services Status Widget

Element option without attribute label must not be empty.
<option selected></option>

Fix redmine #5722 DHCP validation for master

Merge pull request #2341 from NOYB/HTML_Compliance_-_Interfaces_/_VLAN

Merge pull request #2339 from BBcan177/patch-2

HTML Compliance - Interfaces / VLAN

A table row was 5 columns wide and exceeded the column count established by the first row (4).

pkg_mgr_installed - Fix disablepackagehistory

• Improve if/else/endif

pkg_mgr - Fix disablepackagehistory

• Version title should always print
• $g['disablepackagehistory'] only disables the changelog hyperlink

Fixed #5717

Merge pull request #2325 from stilez/patch-7

Merge pull request #2337 from BBcan177/patch-1

Update pkg_mgr.php

Update syntax to 4 space indent

Add password confirmation and change to Form_* framework

Update pkg_mgr.php

• Note - There are two lines previously commented out at Lines! (L127-128)

• Mods to if/else/elseif/endif statements for consistency.
• Change package dependency href link icon from "paper-clip" to "globe".
• Put package dependency links into a < ul > for a cleaner output when dependencies span over two lines....

Merge pull request #2335 from NOYB/HTML_Compliance_-_Interfaces_/_Assign_network_ports