pfSense

Status_dhcp_leases fix edit button for static entries with no IP address

The edit button for static entries always has an index id=0 and thus pressing the edit button goes to (mostly) edit the wrong entry.
It was easier and made the code cleaner to get rid of the looping through the staticmap array every time trying to matach IP, MAC address... That data ('if' and 'staticmap_array_index') is easily gathered further up, the first time the staticmap array for each DHCP interface is traversed. I think this should also be more efficient when there are many static mapping entries....

Fix lineup of copyright lines

and module names and other bits of formatting and typos in header
comment sections.

Welcome 2015

modify copyright statement to reflect reality

Provide an edit button for static mapped entries

As suggested in forum https://forum.pfsense.org/index.php?topic=82883.msg0#new
Instead of a non-functioning red plus icon, show an edit icon for static mapped entries, and take the user to services_dhcp_edit page if it is clicked. IMHO this makes it much easier to correct things that are noticed when viewing the Status, DHCP Leases display.

Whitespace in status_dhcp_leases.php

Spelling

Tidy up "status_dhcp_leases.php" XHTML

Add SUMMARY to TABLES
Updates spaces in $fspans and $fspane
Close INPUT and IMG tags and ALT to IMG
Deprecate Ampersand in Anchor tags

xhtml Compliance
replaced <br>, <br/> and </br> with <br />

Fix DHCP lease time display, strftime already convert it to local timezone, so we no need to calc offset

Optimize DHCPv4 lease display online status for static leases. Do not re-parse complete ARP table for each lease, as it can be slow with large ARP tables.

Add the interface's descr after the pool name.

Value in attributes should be lower case

Value in the "method" attribute should be lower case

Fix deleting DHCP leases

This broke when the code was changed to suck the whole leases file into an array with:
$leases_contents = file($leasesfile);
Each array entry has the text of a line in the file AND the newline at the end of the line. So when matching array entries, the match has to expect the "\n" on the end.

Activate new shortcuts/status in the rest of the areas that are currently setup.

If the range isn't an array, skip it, or it will give a PHP error displaying leases.

Improve the memory use while processing the leases file.

need to break out of foreach loop once it finds there is a local time has been selected by any interface of DHCP.

I now parses the xml tags in the dhcpd to check if an interface for DHCP lease is using local time if not defaults to UTC time.

Added choice of UTC time or local time for DHCP leases.

Fixup MAC display on this other path too

Print the MAC mfg on another line in a smaller font if it's found. Less obtrusive than completely replacing the MAC.

MAC prefix to vendor resolution at Status->Interfaces, Status->DHCP leases, Diagnostics->ARP table

Fix comment

Also skip the rewind binding state or leases show expired. Reported at http://forum.pfsense.org/index.php/topic,36657.0.html

Display confirmation before sending Wake on LAN packet to clicked MAC address in list of DHCP leases. Ticket #861

Bring in XSS id fixes from m0n0wall

Fix misc XSS issues from davey b

Implement gettext() calls on status_dhcp_leases.php

Make DHCP leases sortable. Fixes #653

this page is status, not diag.