pfSense

Merge branch 'master' into bootstrap

This is a merge of pfSense/master at this point:

c0d5c1435ee8f90d1ee62f5fb4a4fac48aacda77

include vpn.inc so IPsec CRL reload works. require_once filter.inc in
vpn.inc for callers there that haven't already included it.

When a CRL is updated, refresh strongswan's CRLs.

system_crlmanager.php Conversion complete

Ready for review

This page has a complex mixture of forms and tables. It needs to be
reviewed for functionality.

Encode ca/cert/crl descr in system_crlmanager.php

Code spacing

and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.

Code style system C

Improving aesthetics.

Make title color more consistent with other pages.
Improving aesthetics.

Fix lineup of copyright lines

and module names and other bits of formatting and typos in header
comment sections.

Welcome 2015

Change copyright statement to reflect reality

Merge pull request #1237 from N0YB/XHTML_Compliance_System_Menu

Tidy up misc. XHTML

"diag_dns.php"
Tidy up "equals sign"

"services_captiveportal.php"
Add space to OPTION tag
Update HTML Boolean operator
Close INPUT and BR tags

"services_captiveportal_hostname.php"
Update ALIGN to MIDDLE

"services_captiveportal_vouchers.php"...

XHTML Compliance - System Menu

Enforce select option

XHTML Compliance - System Menu

Advanced - Admin Access Tab
Advanced - Firewall / NAT Tab
Cert Manager - Certificate Revocation Tab
User Manager - Users Tab
User Manager - Groups Tab

Tidy up Ampersand XHTML

Deprecate Ampersand in Anchor tags

Use an alphanumeric test rather than purely is_numericint because the ID is generated by uniqid and is not purely numeric. Fixes #3591

xhtml Compliance
replaced <br>, <br/> and </br> with <br />

Improve checks for params 'id', 'dup' and other similar ones to make sure they are numeric integer, also, pass them through htmlspecialchars() before print

Allow an "empty" CRL to be exported, since this is still a valid action.

Remove call-time pass by reference for do_input_validation, helps ticket #2565

Tidy up "system_crlmanager.php" XHTML

Add CDATA section to SCRIPT tags
Update HTML boolean operators
Close INPUT and BR tags
Move TFOOT between THEAD and TBODY, this is a "quirk" of HTML

Update usr/local/www/system_crlmanager.php

Cleanup HTML

Allow editing an imported CRL, and refresh OpenVPN CRLs when saving. Implements #2652

Shift OpenVPN require, it was causing CRLs to not save changes properly.

removes variables concatenation on gettext strings

CRL fixes for empty CRLs (so they don't kill OpenVPN)

fix missing images for CRLs

Various CRL fixes, handle empty internal CRLs better.

Allow importing a CRL for an external CA.

Show CRL download link only for imported certificates or CRLs with revoked certificates.

Some CRL fixes.

Fix misnamed form field on CRL import.

Fix XSS issues

Various CRL fixes.

Remove WIP note. This should resolve #555.

Add ability to select reason codes for revocation. Reformat CRL edit screen a bit. Ticket #555

Refresh OpenVPN CRL files when a CRL has a cert added/removed. Ticket #555

Add support for deleting a cert from a CRL (unrevoke). As of this point basic CRL functionality does work: Revoke a cert and it cannot connect. Remove it from the CRL and it can. (Have to edit/save OpenVPN server instance to update/refresh CRL though). Ticket #555

Add more CRL functionality. Needs to wait on a new build for further testing.

Fix some forgotten name->descr changes.

Rename 'name' to 'descr' for CA, Certificates, and CRLs, to gain CDATA protection and standardize field names. Ticket #320.

Another CRL delete fix.

Fix delete action for CRLs, and other cleanup.

Don't list a cert count for external CRLs since we can't tell what they are.

Add a work-in-progress CRL manager page