pfSense

Merge branch 'master' into bootstrap

This is a merge of pfSense/master at this point:

c0d5c1435ee8f90d1ee62f5fb4a4fac48aacda77

Add isset check for strictcrlpolicy

To be consistent with the checks in the rest of this code.

Add IPsec advanced option for strict CRL checking

Handle IPsec Advanced Settings save before IPsec is enabled

If the Advanced Settings are saved before any other IPsec is set up then $config['ipsec'] can be just the empty string. As a result you can get:
a) If you select some debug settings then those are not saved. The code to save those settings was only executed when $config['ipsec'] was already an array. Actually the code already did the necessary "if isset() then unset()" stuuf. So I just took the the "if is_array()" away from the code block....

Encoding in vpn_ipsec_settings.php

Merge pull request #1721 from phil-davis/style

Code spacing

and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.

Ticket #4655 well manually merge pull/1715. Thanks: Phil

Ok another round of this which unbreaks input error validation messages

Make this right finally :). Thanks-ti: Phil-davis

Activate the redirection that for some reason got disabled

Ticket #4655 Do not behave against the logic of checkbox and description.

Code style VPN IPsec

Show correct selection for noshuntlan option. Ticket #4655

Update display_top_tabs to use pills as default

Refs. #107

Fix #4640 IPsec Auto-exclude LAN address toggles

every time save is pressed.
Actually the GUI is displaying the opposite setting to what is in the config. When the user pressed save that opposite setting was saved, but then again it displays the opposite of the opposite...

Implement make bofre break feature avaliable on strongswan 5.3.0 useful for IKEv2. Fixes #4626

Fix up Ticket #4504 implementation. Match config style with other areas. Use a config setting to disable, rather than enable, this functionality since it's enabled by default so the tag isn't necessary in the default config. Remove now unnecessary config upgrade code.

Merge branch 'master' into bootstrap

Merge branch 'master' of github.com:pfsense/pfsense

Fixes #4504 use correct key index

Fixes #4504 Allow the bypass policy for LAN to be enabled and prevent traffic sent to lan ip to go to the ipsec tunnel

Fix IPsec Advanced Settings uniqueids. It was neither set in strongswan config, nor picked up correctly in the UI.

Fix todo, let checkbox toggle maxmss input

Refs. #22

Add debug settings as separate group

Refs. #22

Convert vpn_ipsec_settings

Refs. #22

Merge remote-tracking branch 'upstream/master' into origin/master

clean up unique IDs text a bit.

Don't enable interfaces_use by default. Add checkbox to enable on Advanced
tab, in case there are scenarios where it's desirable. Ticket #4341

Globally correct a few typos

• $x; > $x = null;
• removed duplicated cases
• fixed useless statement: (int)$x = $y
• removed poetic: if (!$x && $x) $x = $x

Remove "Prefer old SA" option, and ignore it in all existing configurations. Breaks things in many cases with strongSwan. For the very rare circumstances where this is actually desirable, it's just a sysctl that can be set in tunables.

Fixes #4359 Allow controlling uniqueids

Fixes #4353 Identify when strongswan.conf needs a reload and restart ipsec service.

Provide an advanced setting to be able to disable Unity Plugin(Cisco extensions)

fix text

fix spelling of compression

Fixes #4182 by properly managing IPcomp on ipsec tunnels.
Also retires IPsec force reloading advanced sysctl since its useless nowdays with strongswan and remove its call on rc.newipsecdns.

Welcome 2015

Add input validation on vpn_ipsec_settings.php. Fixes #4052.

Fixes #4039 remove the toggle from IPSec settings since its not anymore useful.

Allow accept_unencrypted_mainmode_messages to be enabled if needed

get back to our standard RFC-defined capitalization of IPsec

firewall_virtual_ip make the table sortable

Merge pull request #1139 from ExolonDX/branch_master_02

Some adjustments to the code for logging

Tidy up "vpn_ipsec" XHTML

Add CDATA section to SCRIPTS
Add SUMMARY to TABLES
Update HTML Boolean operators
Close INPUT and IMG tags and ALT to IMG tags
Move NOWRAP into CLASS statement
Deprecate ampersand in Anchor tags

Move the IPsec settings from System > Advanced, Misc tab to "Advanced Settings" tab under VPN > IPsec.