pfSense

Fix NAS IP listing in captive portal. semi-related to Ticket #5656

Use a better check for whether there are DNS servers available with dynamic WAN types. Ticket #4747

Verify a DNS server exists before allowing enabling of forwarding mode. Ticket #4747

$interface isn't used here. Wasn't before either, otherwise it would have broken the get_configured_carp_interface_list. Ticket #5844

Just show the IP to the user, the VIP's uniqid is meaningless noise to the user. Ticket #5844

Only show VIPs associated with the correct interface. Ticket #5844

Select appropriate VIP where one is configured. Ticket #5844

Add pfsync to the list of pre-defined packet capture filters. Also add negation for ESP that seems to have been accidentally omitted.

Fix #5837

Since the introduction of pkg_with_pb(), direct calls to this function
were added using the following format:

if ! pkg_with_pb ... | tee -a $logfile; then

What happened in this case is if was always getting a successfull
return code from tee call, and pkg_with_pb return was always being...

HTML Compliance - Status / OpenVPN

Start tag body seen but an element of the same type was already open.
Stray start tag script.