pfSense

simplify avoiding loop. Also localise with gettext()
(cherry picked from commit 16b91b19e08e0778522c16e811754c22f03b5150)

Bugfixes

1. On creating a new rule, $pconfig['ipprotocol'] is undefined, rather than defaults to what is seen in GUI (IPv4). Form generation logic for the ICMPType list box can't rely on a good value. It was fixed late here and missed when copying changes to Github. Very likely responsible for above issue by @rbgarga . Please confirm if this fixes it for you. On the off-chance that it still doesn't, can you let me know if editing an existing rule works, which will help....

Improve icmptype input sanitising
(cherry picked from commit 0e782e9f576aee02d4e2e5147e24bc5def261355)

Enhance ICMP types in rules

See main PR for details
(cherry picked from commit cf1aaf9c5afcd34ed6d2bebc577fd527c42c80b4)

Enhance ICMP type handling in rules

See main PR for details
(cherry picked from commit 7a4b11b6a495ddc747db5e44f5a62891ef86398c)

typo
(cherry picked from commit 58aa4d7ce3d0c602516e8d7691fc0137b593262c)

Enhance ICMP rules

See main PR details
(cherry picked from commit 4784d8cef74bac4d1397fbfd7312c08912d8890a)

Add privs to control display of notices

This is a suggested way to allow control of the display and clearing of
notices. The use case is:
1) A user with minimal page privs (e.g. can just change their password,
or access a few status pages or...) should not be automatically able to...

Fix #6982: Remove wrong global definition of use_filterdns and pass it as reference

Revert "Fix #6920: Do not include stale .inc files"

It's 2.4 only, merged accidentally

This reverts commit 87913c3053c83c5d8473d6e24f39c38833d75b47.