pfSense

Cleanup code logic status_upnp

1) Variable $i is was set, incremented and not used.
2) "if preg_match" at line 94 had no curlies after it, so it was only applying to the first line after it ($rdr_proto = ...) It really looks like "if preg_match"should apply to the whole code chunk - settings the various "rdr*" vars and then spitting out the "tr" with the various matches values in the row....

Fix alias rename and delete bug #4701

The old advancedoutbound key in config.xml is now called outbound.

Slash-select should be inside if in load_balancer_pool_edit

otherwise there is an unbalanced slash-select when the else happens (if there are no load-balancer monitors defined)

fixed indent according to the style guide.

Currently pfsense enforces unique unqualified hostnames for static dhcp leases, which is not correct as only the fully qualified hostname (hostname + domainname) must be unique. With this commit the old validation logic for uniqeness is modified such that hostnames no longer need to be unique and at the same time the fully qualified hostname hast to be unique....

Firewall Rules Edit missing slash

This should be the end of a "tr" here.
Browsers seem to be forgiving of this stuff - I don't see any difference in rendering in Firefox before or after this change.

Unmatched td in firewall_nat

This file seems to have an unmatched "td" ending. Adding the line here matches the "td" at line 320 and this embraces the little table that has the 4 icons in it in a square that comes at the right hand end of each port-forward entry in the main table....

Call clear_subsystem_dirty('staticmaps') if using Unbound

Encode server name before displaying back to the user.

Fixes #4633 Enable carp packets to flow on the first carp interface creation. This is needed only when the system is booted up without any carp vip configured