Project

General

Profile

Bug #10955

XMLRPC sync errors when failover peer IP is specified in DHCP server settings

Added by Max Leighton 6 months ago. Updated 3 days ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
Renato Botelho
Category:
XMLRPC
Target version:
pfSense Plus - Plus-Next
Start date:
10/04/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.5.0
Affected Architecture:
Release Notes:
Default

Description

Forum post: https://forum.netgate.com/topic/156974/xmlrpc-sync-error-built-on-sun-sep-20-01-01-05-edt-2020

I'm seeing this behavior in:

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 04 18:53:52 EDT 2020
FreeBSD 12.2-STABLE

DHCPv6 Relay and DHCPv6 Server & RA are disabled on all interfaces and no IPv6 configuration exists whatsoever. Any configuration change made on the primary node triggers two errors and does not sync to the secondary.

Exception calling XMLRPC method restore_config_section # Impossible to encode value '' from type 'NULL'. No analogous type in XML_RPC. 2020-10-04 22:02:55
Exception calling XMLRPC method restore_config_section # Impossible to encode value '' from type 'NULL'. No analogous type in XML_RPC. 2020-10-04 22:02:56

Removing the Failover Peer IP from the DHCP server settings or unchecking DHCP server settings from the synced options in System>High Avail. Sync will resolve the issue and allow configuration changes to sync once again.

Associated revisions

Revision 64431f25 (diff)
Added by Viktor Gurov 6 months ago

route_get() improments. Fixes #10955

Revision b1558574 (diff)
Added by Renato Botelho 5 months ago

Ticket #10955: Fix "default" case

Make a string check to cover "default" gateway

History

#1 Updated by Jim Pingle 6 months ago

  • Status changed from New to Confirmed
  • Priority changed from Normal to Very High
  • Target version set to 2.5.0

I'm seeing this as well

#3 Updated by Renato Botelho 6 months ago

  • Status changed from Confirmed to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Raul Ramos 6 months ago

I started the post i put my feedback here.

built on Fri Oct 09 14:15:42 EDT 2020 is working as expected.

Thanks

#5 Updated by Viktor Gurov 6 months ago

  • Status changed from Feedback to Resolved

works fine on 2.5.0.a.20201009.1850 HA

#6 Updated by Jim Pingle 5 months ago

  • Category changed from CARP to XMLRPC

#7 Updated by Azamat Khakimyanov 3 days ago

  • Status changed from Resolved to Pull Request Review
  • Priority changed from Very High to Normal
  • Target version changed from 2.5.0 to Plus-Next

According to https://github.com/pfsense/pfsense/pull/4479/commits/64431f257bb831a8aa121c356bbef3ab28d0ddc1 function route_get was changed
$result = array();
foreach ($rtable[$family] as $item) {
- if ($item['destination'] == $target) {
+ if (ip_in_subnet($target, $item['destination'])) {
$result[] = $item;
but now when I opened /etc/inc/util.inc I see
$result = array();
foreach ($rtable[$family] as $item) {
if ($item['destination'] == $target ||
ip_in_subnet($target, $item['destination'])) {
$result[] = $item;
and there is a ticket https://go.netgate.com/helpdesk/tickets/81347 - on 21.02_p1 client has exactly the same issue which was described in Bug.
Looks like route_get function was rewritten again and it initiated Bug with HA cluster again.

Steve wrote that function route_get were changed https://github.com/pfsense/pfsense/commit/b1558574e69965ea68744ad355a60842ca8294ea#diff-e8a8d358a47a0aaf09fb3b160a32f5dd7625b3c1c82210d7f2412e182d0fcd66

Current Bug 10955 was marked resolved at Oct 10 2020 but commit I mentioned above was added at Nov 2 2020 - after this Bug was tested and resolved.

Also available in: Atom PDF