Bug #11098
open
Backup Files and Directories plugin crashes firewall if /root specified as backup location
0%
Description
The Backup Files and Directories plugin crashes firewall if /root specified as backup location. The plugin creates its backup at /root/backup and does not exclude the backup directory. This creates a recursive tar which fills all available storage and crashes pfSense.
Additional info at:
[[https://forum.netgate.com/topic/158572/who-maintains-this-package-how-do-i-file-a-bug-report?lang=en-GB]]
Files
| backup.php (7.33 KB) backup.php | Untested Potential Fix (Line 57 added --exclude) | ||
| Screenshot from 2020-11-25 12-05-49.png (35.3 KB) Screenshot from 2020-11-25 12-05-49.png |
Updated by Jim Pingle about 1 year ago
- Project changed from pfSense to pfSense Packages
- Category changed from Backup / Restore to Backup
Updated by Viktor Gurov about 1 year ago
Updated by Steve Wheeler about 1 year ago
I can't replicate this by simply attempting to backup /root.
The backup file is not included in the .tgz.
Testing Backup package version 0.5_3 in 2.4.5p1.
Updated by Marcos Mendoza about 1 year ago
I was not able to reproduce the issue either:
path: /root/backup dir contents: empty result: archive with empty /root/backup dir path: /root/backup dir contents: pfsense.bak.tgz result: archive with empty /root/backup dir path: /root dir contents: default files; empty backup dir result: archive with default files and empty backup dir
When I tested "path: /", it the failed because it ran out of space (but this is not indicative of a recursive failure).
Updated by Renato Botelho about 1 year ago
- Status changed from New to Feedback
- Assignee set to Viktor Gurov
PR has been merged. Thanks!
Updated by Jordan Greene about 1 year ago
Attempted creating backup for '/' on XG-7100 on ZFS
received following
PHP ERROR: Type: 1, File: /usr/local/www/packages/backup/backup.php, Line: 77, Message: Allowed memory size of 536870912 bytes exhausted (tried to allocate 552079360 bytes) @ 2021-01-09 21:35:18
Updated by Kris Phillips 3 months ago
Attempting a backup produces a crash, but doesn't freeze the entire firewall or fill the drive thankfully. It also spiked RAM usage by 50% due to PHP usage. Seems there is more work to be done here.
Crash report begins. Anonymous machine information:
amd64
12.3-PRERELEASE
FreeBSD 12.3-PRERELEASE plus-devel-12-n202608-e4bc455a39a pfSense
Crash report details:
PHP Errors:
[31-Oct-2021 00:01:06 Etc/UTC] PHP Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 498034928 bytes) in Unknown on line 0
No FreeBSD crash data found.
Updated by Viktor Gurov 3 months ago
Updated by Jim Pingle 3 months ago
- Status changed from Feedback to Pull Request Review
Updated by Viktor Gurov about 1 month ago
- Status changed from Pull Request Review to Feedback
Merged