Project

General

Profile

Bug #11098

Backup Files and Directories plugin crashes firewall if /root specified as backup location

Added by Privacy Please about 2 months ago. Updated 10 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Backup
Target version:
-
Start date:
11/24/2020
Due date:
% Done:

0%

Estimated time:
Affected Version:
Affected Architecture:
All

Description

The Backup Files and Directories plugin crashes firewall if /root specified as backup location. The plugin creates its backup at /root/backup and does not exclude the backup directory. This creates a recursive tar which fills all available storage and crashes pfSense.

Additional info at:
[[https://forum.netgate.com/topic/158572/who-maintains-this-package-how-do-i-file-a-bug-report?lang=en-GB]]

backup.php (7.33 KB) backup.php Untested Potential Fix (Line 57 added --exclude) Privacy Please, 11/24/2020 01:33 PM
Screenshot from 2020-11-25 12-05-49.png (35.3 KB) Screenshot from 2020-11-25 12-05-49.png Steve Wheeler, 11/25/2020 06:31 AM

History

#1 Updated by Jim Pingle about 2 months ago

  • Project changed from pfSense to pfSense Packages
  • Category changed from Backup / Restore to Backup

#3 Updated by Steve Wheeler about 2 months ago

I can't replicate this by simply attempting to backup /root.

The backup file is not included in the .tgz.

Testing Backup package version 0.5_3 in 2.4.5p1.

#4 Updated by Marcos Mendoza about 2 months ago

I was not able to reproduce the issue either:

path: /root/backup
dir contents: empty
result: archive with empty /root/backup dir

path: /root/backup
dir contents: pfsense.bak.tgz
result: archive with empty /root/backup dir

path: /root
dir contents: default files; empty backup dir
result: archive with default files and empty backup dir

When I tested "path: /", it the failed because it ran out of space (but this is not indicative of a recursive failure).

#5 Updated by Renato Botelho 12 days ago

  • Status changed from New to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

#6 Updated by Jordan Greene 10 days ago

Attempted creating backup for '/' on XG-7100 on ZFS

received following
PHP ERROR: Type: 1, File: /usr/local/www/packages/backup/backup.php, Line: 77, Message: Allowed memory size of 536870912 bytes exhausted (tried to allocate 552079360 bytes) @ 2021-01-09 21:35:18

Also available in: Atom PDF