Project

General

Profile

Actions
Copy link

Feature #11164

closed

Input validation to prevent setting a load balancing gateway group as default

Added by Steve Wheeler almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Danilo Zrenjanin
Category:
Gateways
Target version:
2.5.2
Start date:
12/15/2020
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default

Description

Currently it's possible to set a load-balance gateway group as the system default gateway in System > Routing > Gateways.

That is an invalid setting though, only individual gateways or failover groups are valid there.

It would be nice for the input validation to prevent that but that would mean code to categorise gateway groups. That could get complex quickly.

Failing that a note on that page such as changing the text to:

Select a gateway or failover gatewaygroup to use as the default gateway.

Files

f_o.png (6.64 KB) f_o.png Alhusein Zawi, 04/21/2021 09:17 PM
Actions
Copy link
 #1

Updated by Steve Wheeler almost 3 years ago

Reviewing it appears the intended behaviour here is that a load-balance group can be selected but behaves as a failover group with whichever gateway is first acrting as the higher tier. Importantly it cannot actually load-balance.

So a note to that effect on the page would probably suffice here.

Actions
Copy link
 #2

Updated by Jim Thompson over 2 years ago

  • Target version changed from Future to CE-Next

Seems simple enough to fix (with the message) and the GUI is misleading.

Actions
Copy link
 #4

Updated by Jim Pingle over 2 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #5

Updated by Renato Botelho over 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Danilo Zrenjanin

PR has been merged. Thanks!

Actions
Copy link
 #6

Updated by Renato Botelho over 2 years ago

  • Target version changed from CE-Next to 2.6.0
Actions
Copy link
 #7

Updated by Alhusein Zawi over 2 years ago

note is added (attached)

2.6.0-DEVELOPMENT (amd64)
built on Wed Apr 21 01:03:55 EDT 2021
FreeBSD 12.2-STABLE

Actions
Copy link
 #8

Updated by Viktor Gurov over 2 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #9

Updated by Jim Pingle over 2 years ago

  • Plus Target Version set to 21.05

Already present on 21.05 builds.

Actions
Copy link
 #10

Updated by Jim Pingle over 2 years ago

  • Subject changed from Prevent setting a load-balance gateway group as default. to Input validation to prevent setting a load balancing gateway group as default

Updating subject for release notes.

Actions
Copy link
 #11

Updated by Jim Pingle over 2 years ago

  • Target version changed from 2.6.0 to 2.5.2
Actions
Copy link

Also available in: Atom PDF