Project

General

Profile

Actions

Bug #12001

open

System tries to stop disabled packages on shutdown

Added by Viktor Gurov about 2 months ago. Updated 13 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
Services
Target version:
Start date:
06/07/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.09
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

/etc/rc.stop_packages tries to stop disabled services:

 Stopping package Cron...done.
 Stopping package freeradius3...done.
 Stopping package acme...done.
 Stopping package Avahi...done.
 Stopping package FRR...done.
 Stopping package pfBlockerNG-devel...done.
 Stopping package haproxy-devel...done.
 Stopping package squid3...done.
 Stopping package Zabbix Agent 5.2...done.
 Stopping package OpenVPN Client Export Utility...done.
 Stopping package suricata...done.
 Stopping package squidGuard...done.
 Stopping package snort...done.
 Stopping /usr/local/etc/rc.d/haproxy.sh...done.
 Stopping /usr/local/etc/rc.d/pfb_dnsbl.sh...done.
 Stopping /usr/local/etc/rc.d/pfb_filter.sh...done.
 Stopping /usr/local/etc/rc.d/radiusd.sh...done.
 Stopping /usr/local/etc/rc.d/sqp_monitor.sh...done.
 Stopping /usr/local/etc/rc.d/zabbix_agentd.sh...done.

- snort and suricata are not enabled in my case,
and it's not possible to "stop" OpenVPN Client Export Utility

Actions #1

Updated by Viktor Gurov about 2 months ago

  • Category changed from PPPoE Server to Services
Actions #2

Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.6.0
  • Plus Target Version set to 21.09
Actions #3

Updated by Renato Botelho about 2 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

Actions #4

Updated by Viktor Gurov about 2 months ago

  • % Done changed from 0 to 100
Actions #5

Updated by Max Leighton 25 days ago

Tested in

2.6.0-DEVELOPMENT (amd64)
built on Fri Jul 09 09:13:36 EDT 2021
FreeBSD 12.2-STABLE

I still see:

Stopping /usr/local/etc/rc.d/haproxy.sh...done.
Stopping /usr/local/etc/rc.d/sqp_monitor.sh...done.
Stopping /usr/local/etc/rc.d/squid.sh...done.
Stopping /usr/local/etc/rc.d/suricata.sh...done.
Stopping /usr/local/etc/rc.d/vmware-guestd.sh...done.
Stopping /usr/local/etc/rc.d/vmware-kmod.sh...done.

In my case, HAproxy is disabled. Suricata and Squid are both stopped and not enabled on any interface. I no longer see the message for stopping OpenVPN client export though

Actions #6

Updated by Christian McDonald 23 days ago

Right now it's the responsibility of packages themselves to handle removing their own *.sh rc files when they are disabled. pfSense just globs the rc path for *.sh files and executes them if they are present. There is also no guarantee that a package's rc file follows the format:

<service internal name>.sh
On top of that, it isn't required that package rc files end in *.sh anyways.

Actions #7

Updated by Bill Meeks 23 days ago

I've added my own internal bug tracking report of this issue to my list for the Snort and Suricata packages. I will make sure that when no enabled interface remains, the shell script in /usr/local/etc/rc.d/ is removed. The script is always created when saving changes, so once at least one interface is enabled, and that change is saved, the necessary script will be created.

I will address this in the next GUI package update for each.

Actions #8

Updated by Bill Meeks 13 days ago

A fix for this issue has been incorporated into both the Snort and Suricata packages. The pull request (https://github.com/pfsense/FreeBSD-ports/pull/1086 and https://github.com/pfsense/FreeBSD-ports/pull/1085) has been merged into both the DEVEL and RELEASE branches.

This issue is resolve for the Snort and Suricata packages.

Actions

Also available in: Atom PDF