Project

General

Profile

Actions

Todo #204

closed

All write_config() statements should include a reason of some sort

Added by Scott Ullrich almost 15 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
12/06/2009
Due date:
% Done:

100%

Estimated time:
20.00 h
Plus Target Version:
Release Notes:

Description

Need to sweep the tree and modify write_config() to include a reason for the change.

Actions #1

Updated by Seth Mos almost 15 years ago

I've previously talked with Bill about this at the hackathon and was offering a bounty at the time.
This also included the possibility to tag specific versions as ok with a comment.

Actions #2

Updated by Chris Buechler over 14 years ago

  • Target version changed from 3 to Future
Actions #3

Updated by Phillip Davis over 7 years ago

Actions #4

Updated by Kill Bill over 7 years ago

Not sure about bounty, but I did a couple more of them since I find the lack of info about what caused the configuration change to be annoying.

https://github.com/pfsense/pfsense/pull/3620 (Unbound)
https://github.com/pfsense/pfsense/pull/3621 (WOL)
https://github.com/pfsense/pfsense/pull/3622 (L2TP VPN)
https://github.com/pfsense/pfsense/pull/3623 (DynDNS)
https://github.com/pfsense/pfsense/pull/3632 (Misc. pages)
https://github.com/pfsense/pfsense/pull/3633 (IPsec VPN)
https://github.com/pfsense/pfsense/pull/3634 (Wizards)
https://github.com/pfsense/pfsense/pull/3663 (Firewall - NAT/Rules/Aliases/Schedules/Virtual IPs)

Actions #5

Updated by Kill Bill about 7 years ago

https://github.com/pfsense/pfsense/pull/3805 (interfaces*.php)
https://github.com/pfsense/pfsense/pull/3806 (firewall_shaper*.php)
https://github.com/pfsense/pfsense/pull/3807 (load_balancer*.php)
https://github.com/pfsense/pfsense/pull/3808 (services_captiveportal*.php)
https://github.com/pfsense/FreeBSD-ports/pull/404 (sysutils/pfSense-Status_Monitoring)

Remaining:

/etc/inc/gwlb.inc
/usr/local/www/services_dhcp_edit.php
/usr/local/www/services_dhcp.php
/usr/local/www/services_dhcp_relay.php
/usr/local/www/services_dhcpv6_edit.php
/usr/local/www/services_dhcpv6.php
/usr/local/www/services_dhcpv6_relay.php
/usr/local/www/services_dnsmasq_domainoverride_edit.php
/usr/local/www/services_dnsmasq_edit.php
/usr/local/www/services_dnsmasq.php
/usr/local/www/services_igmpproxy_edit.php
/usr/local/www/services_igmpproxy.php
/usr/local/www/services_pppoe_edit.php
/usr/local/www/services_pppoe.php
/usr/local/www/services_rfc2136.php
/usr/local/www/services_router_advertisements.php
/usr/local/www/services_snmp.php
/usr/local/www/system_advanced_admin.php
/usr/local/www/system_advanced_misc.php
/usr/local/www/system_advanced_network.php
/usr/local/www/system_advanced_notifications.php
/usr/local/www/system_advanced_sysctl.php
/usr/local/www/system_authservers.php
/usr/local/www/system_camanager.php
/usr/local/www/system_certmanager.php
/usr/local/www/system_gateway_groups_edit.php
/usr/local/www/system_groupmanager_addprivs.php
/usr/local/www/system_groupmanager.php
/usr/local/www/system_usermanager_addprivs.php
/usr/local/www/system_usermanager_passwordmg.php
/usr/local/www/system_usermanager.php
/usr/local/www/system_usermanager_settings.php

Actions #6

Updated by Jim Pingle over 5 years ago

  • Category set to Web Interface
Actions #7

Updated by Renato Botelho about 4 years ago

  • Status changed from New to Feedback
  • Assignee set to Renato Botelho
  • Target version changed from Future to 2.5.0

All write_config() calls on base and ports now have a description. Added a Warning when it's called without it so developers will be notified while testing

Actions #8

Updated by Renato Botelho about 4 years ago

  • % Done changed from 0 to 100
Actions #9

Updated by Viktor Gurov almost 4 years ago

  • Status changed from Feedback to Resolved

tested on 2.5.0.a.20210112.0250
all write_config() calls have messages

Actions

Also available in: Atom PDF