Todo #204

All write_config() statements should include a reason of some sort

Added by Scott Ullrich over 11 years ago. Updated 3 months ago.

Web Interface
Target version:
Start date:
Due date:
% Done:


Estimated time:
20.00 h
Release Notes:


Need to sweep the tree and modify write_config() to include a reason for the change.

Associated revisions

Revision e85ae672 (diff)
Added by Renato Botelho 5 months ago

Fix #204: Add messages to all write_config() calls


#1 Updated by Seth Mos over 11 years ago

I've previously talked with Bill about this at the hackathon and was offering a bounty at the time.
This also included the possibility to tag specific versions as ok with a comment.

#2 Updated by Chris Buechler about 11 years ago

  • Target version changed from 3 to Future

#4 Updated by Kill Bill about 4 years ago

Not sure about bounty, but I did a couple more of them since I find the lack of info about what caused the configuration change to be annoying. (Unbound) (WOL) (L2TP VPN) (DynDNS) (Misc. pages) (IPsec VPN) (Wizards) (Firewall - NAT/Rules/Aliases/Schedules/Virtual IPs)

#5 Updated by Kill Bill over 3 years ago (interfaces*.php) (firewall_shaper*.php) (load_balancer*.php) (services_captiveportal*.php) (sysutils/pfSense-Status_Monitoring)



#6 Updated by Jim Pingle over 1 year ago

  • Category set to Web Interface

#7 Updated by Renato Botelho 5 months ago

  • Status changed from New to Feedback
  • Assignee set to Renato Botelho
  • Target version changed from Future to 2.5.0

All write_config() calls on base and ports now have a description. Added a Warning when it's called without it so developers will be notified while testing

#8 Updated by Renato Botelho 5 months ago

  • % Done changed from 0 to 100

#9 Updated by Viktor Gurov 3 months ago

  • Status changed from Feedback to Resolved

tested on 2.5.0.a.20210112.0250
all write_config() calls have messages

Also available in: Atom PDF