Todo #204
closedAll write_config() statements should include a reason of some sort
Added by Scott Ullrich over 14 years ago. Updated over 3 years ago.
100%
Description
Need to sweep the tree and modify write_config() to include a reason for the change.
Updated by Seth Mos over 14 years ago
I've previously talked with Bill about this at the hackathon and was offering a bounty at the time.
This also included the possibility to tag specific versions as ok with a comment.
Updated by Chris Buechler over 14 years ago
- Target version changed from 3 to Future
Updated by Phillip Davis over 7 years ago
By doktornotor:
https://github.com/pfsense/pfsense/pull/3617
https://github.com/pfsense/pfsense/pull/3618
By phil.davis:
https://github.com/pfsense/pfsense/pull/3619
Only 7 years late, is there still a bounty on offer? :)
Updated by Kill Bill over 7 years ago
Not sure about bounty, but I did a couple more of them since I find the lack of info about what caused the configuration change to be annoying.
https://github.com/pfsense/pfsense/pull/3620 (Unbound)
https://github.com/pfsense/pfsense/pull/3621 (WOL)
https://github.com/pfsense/pfsense/pull/3622 (L2TP VPN)
https://github.com/pfsense/pfsense/pull/3623 (DynDNS)
https://github.com/pfsense/pfsense/pull/3632 (Misc. pages)
https://github.com/pfsense/pfsense/pull/3633 (IPsec VPN)
https://github.com/pfsense/pfsense/pull/3634 (Wizards)
https://github.com/pfsense/pfsense/pull/3663 (Firewall - NAT/Rules/Aliases/Schedules/Virtual IPs)
Updated by Kill Bill almost 7 years ago
https://github.com/pfsense/pfsense/pull/3805 (interfaces*.php)
https://github.com/pfsense/pfsense/pull/3806 (firewall_shaper*.php)
https://github.com/pfsense/pfsense/pull/3807 (load_balancer*.php)
https://github.com/pfsense/pfsense/pull/3808 (services_captiveportal*.php)
https://github.com/pfsense/FreeBSD-ports/pull/404 (sysutils/pfSense-Status_Monitoring)
Remaining:
/etc/inc/gwlb.inc /usr/local/www/services_dhcp_edit.php /usr/local/www/services_dhcp.php /usr/local/www/services_dhcp_relay.php /usr/local/www/services_dhcpv6_edit.php /usr/local/www/services_dhcpv6.php /usr/local/www/services_dhcpv6_relay.php /usr/local/www/services_dnsmasq_domainoverride_edit.php /usr/local/www/services_dnsmasq_edit.php /usr/local/www/services_dnsmasq.php /usr/local/www/services_igmpproxy_edit.php /usr/local/www/services_igmpproxy.php /usr/local/www/services_pppoe_edit.php /usr/local/www/services_pppoe.php /usr/local/www/services_rfc2136.php /usr/local/www/services_router_advertisements.php /usr/local/www/services_snmp.php /usr/local/www/system_advanced_admin.php /usr/local/www/system_advanced_misc.php /usr/local/www/system_advanced_network.php /usr/local/www/system_advanced_notifications.php /usr/local/www/system_advanced_sysctl.php /usr/local/www/system_authservers.php /usr/local/www/system_camanager.php /usr/local/www/system_certmanager.php /usr/local/www/system_gateway_groups_edit.php /usr/local/www/system_groupmanager_addprivs.php /usr/local/www/system_groupmanager.php /usr/local/www/system_usermanager_addprivs.php /usr/local/www/system_usermanager_passwordmg.php /usr/local/www/system_usermanager.php /usr/local/www/system_usermanager_settings.php
Updated by Renato Botelho almost 4 years ago
- Status changed from New to Feedback
- Assignee set to Renato Botelho
- Target version changed from Future to 2.5.0
All write_config() calls on base and ports now have a description. Added a Warning when it's called without it so developers will be notified while testing
Updated by Renato Botelho almost 4 years ago
- % Done changed from 0 to 100
Applied in changeset e85ae672e45f0e883478c74b630b1723908998dd.
Updated by Viktor Gurov over 3 years ago
- Status changed from Feedback to Resolved
tested on 2.5.0.a.20210112.0250
all write_config() calls have messages