pfSense

I put in some basic CARP settings (and maybe not a consistent/valid set?) and got the same PHP warnings from these config.xml sections:

    <hasync>
        <pfsyncpeerip>192.168.1.11</pfsyncpeerip>
        <pfsyncinterface>lan</pfsyncinterface>
        <synchronizetoip>192.168.1.11</synchronizetoip>
        <username/>
        <password/>
        <pfsyncenabled>on</pfsyncenabled>
        <synchronizealiases>on</synchronizealiases>
    </hasync>
    <virtualip>
        <vip>
            <mode>carp</mode>
            <interface>lan</interface>
            <vhid>1</vhid>
            <advskew>0</advskew>
            <advbase>1</advbase>
            <password>test</password>
            <descr><![CDATA[Test VIP]]></descr>
            <type>single</type>
            <subnet_bits>24</subnet_bits>
            <subnet>192.168.1.22</subnet>
        </vip>
    </virtualip>

if (is_array($config['hasync'])) {
    foreach($config['hasync'] as $carp) {
    $ip = $carp['ipaddress'];

Found same issue and mailed to dev@lists a 'possible solution', maybe Ermal Luçi can take another look?

p.s. the long 30 second wait was probably to wait for pfsync to have time to sync the connection firewall states from the backup back to the CARP master. I have added a check in github(https://github.com/bsdperimeter/pfsense/commit/1be1a67a3941de56e6fc80db1d1ee21f6e9c4fce) to see if pfSync is actually set ON, and if not skip the wait.

Below the 'possibly fixed' function for the stristr warnings:

function filter_process_carp_nat_rules() {
    global $g, $config;

    update_filter_reload_status("Creating CARP NAT rules");
    if(isset($config['system']['developerspew'])) {
        $mt = microtime();
        echo "filter_process_carp_nat_rules() being called $mt\n";
    }
    $lines = "";
    if (is_array($config['hasync'])) {
        foreach($config['hasync'] as $carp) {
            $ip = $carp['ipaddress'];
            if($ip == "any") {
                $ipnet = "any";
            } else {
                $int = find_ip_interface($ip);
                $carp_int = find_carp_interface($ip);
            }
            if ($int != false and $int != $wan_interface) {

    $ipnet = convert_ip_to_network_format($ip, $carp['netmask']);
                if ($int && $carp_int)
                    $lines .= "nat on {$int} inet from {$ipnet} to any -> ({$carp_int}) \n";
            }
        }
    }
    return $lines;
}

Previous was not the 'possibly fixed' function it was the 'original' here is the 'fixed' one..:

function filter_process_carp_nat_rules() {
    global $g, $config;

    update_filter_reload_status("Creating CARP NAT rules");
    if(isset($config['system']['developerspew'])) {
        $mt = microtime();
        echo "filter_process_carp_nat_rules() being called $mt\n";
    }
    $lines = "";

    if (is_array($config['virtualip']['vip']) && is_array($config['virtualip'])) {
        foreach($config['virtualip']['vip'] as $carp) {
            if ($carp['mode']!="carp")
                continue;

            $ip = $carp['subnet'];
            if($ip == "any") {
                $ipnet = "any";
            } else {
                $int = find_ip_interface($ip, $carp['subnet_bits']);
                $carp_int = find_carp_interface($ip);
            }

            if ($int != false and $int != $wan_interface) {
                $ipnet = convert_ip_to_network_format($ip, $carp['subnet_bits']);
                if ($int && $carp_int)
                {
                    $lines .= "nat on {$int} inet from {$ipnet} to any -> ({$carp_int}) \n";
                }
            }
        }
    }
    return $lines;
}

same error still there but has shifted to line 3840