Project

General

Profile

Actions

Todo #4858

closed

Finish/fix CARP uniqid changes

Added by Chris Buechler about 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
CARP
Target version:
Start date:
07/21/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:

Description

The changes made in 89f171b052fbe72aed654d2a1c3d5a24e9bf9902 need review and completion. Need to verify OpenVPN bound to gateway groups with CARP IPs is working as well. Fixed in RELENG_2_2 in 6eb520938c518a958f09db67e5e9eba2dbdc02d2.

Actions #1

Updated by Jim Thompson about 6 years ago

  • Assignee set to Chris Buechler
Actions #2

Updated by Cullen Trey almost 6 years ago

See Bug #4642 where i uploaded the rc.carpmaster and rc.carpbackup files, which should start or stop OpenVPN only on the necessary CARP IP events.

Actions #3

Updated by Chris Buechler almost 6 years ago

This is just a mess, for the reasons Phil Davis noted on the commit, and other things it's broken (#5441, maybe #5442, and definitely other issues that don't have bugs at the moment).
https://github.com/pfsense/pfsense/commit/89f171b052fbe72aed654d2a1c3d5a24e9bf9902

It was tagged with #3997 but has nothing to do with that ticket, that doesn't apply to CARP at all. It no longer git reverts after things have moved around, but will probably end up backing this out as I see no benefit to having it, it wasn't finished, and it doesn't work.

Actions #4

Updated by Jim Thompson almost 6 years ago

  • Assignee changed from Chris Buechler to Luiz Souza

I'd rather have Luiz do this, and drive things back as close as we can to stock FreeBSD

Actions #5

Updated by Luiz Souza almost 6 years ago

  • % Done changed from 0 to 30
Actions #6

Updated by Jim Thompson over 5 years ago

  • Status changed from New to Assigned
Actions #7

Updated by Chris Buechler over 5 years ago

  • Subject changed from Review CARP uniqid changes to Finish/fix CARP uniqid changes
  • Status changed from Assigned to Feedback
  • % Done changed from 30 to 100

that should be the last of it.

Actions #8

Updated by Luiz Souza over 5 years ago

Unfortunately this is not yet fixed, there are numerous issues when dealing with IP aliases and CARP in pfSense services.

I've a more complete fix which I'm going to commit in the next hours.

Thanks!

Actions #9

Updated by Luiz Souza over 5 years ago

The uniqid changes are now finished. All the serious and known bugs are fixed.

It took me a while to understand the big picture here and deliver a solution that wasn't too intrusive and at the same time provide all the fixes we need. This was indeed incomplete and broken at various places.

One of the most important failures here was the upgrade code that was never committed and so, all the existent setups would fail miserably after the upgrade.

Thanks everyone for the patience!

Actions #10

Updated by Chris Buechler over 5 years ago

I've re-tested every use of CARP and IP aliases including on gateway groups with the exception of dynamic DNS which I haven't had a chance to get to yet.

outside of the regressions in #5884 and #5885, the remainder works now.

Leaving to feedback until I can thoroughly test dynamic DNS on gateway groups with VIPs.

Actions #11

Updated by Chris Buechler over 5 years ago

  • Status changed from Feedback to Resolved

Dynamic DNS on gateway groups with VIPs was broken. It's working now including IP alias and CARP VIPs. That should be the last of this, outside things covered in other tickets.

Actions

Also available in: Atom PDF