Todo #5994
closed
Make Advanced Buttons work consistently
Added by Phillip Davis over 8 years ago.
Updated over 8 years ago.
Description
See forum for discussion: https://forum.pfsense.org/index.php?topic=108108.0
Where there is an Advanced section:
a) On page load with default values, show "Display Advanced" button and hide the advanced fields.
b) On page load where the existing values are non-default, show "Hide Advanced" button and show the advanced fields.
c) When "Display Advanced" is clicked, show the advanced fields, change the button text to "Hide Advanced".
d) When "Hide Advanced" is clicked, hide the advanced fields, change the button text to "Display Advanced".
I can look at this tonight (my time) = Tuesday day US time.
- Status changed from New to Feedback
- % Done changed from 0 to 100
- Assignee set to Jim Pingle
- Status changed from Feedback to Assigned
- Assignee changed from Jim Pingle to Phillip Davis
They all look OK except for firewall_rules_edit.php -- When creating a brand new rule, which defaults to TCP, it shows "Hide Advanced" but the block is already hidden. Clicking it switches the button to "Display advanced" and then clicking expands as expected. If you don't click anything and instead change it to another protocol with ports like UDP or TCP/UDP, the source ports show.
Doesn't quite sound the same as #6007 but it doesn't surprise me that there are some lingering issues with JS on that page, it's pretty complicated especially with its many possible initial states + changes.
Also since #6003 is fixed so that the periodic reset radio button setting is saved in interfaces_pps_edit.php #6003, I noticed that the Advanced fields did not open on page load for that case.
Test criteria fixed to include that, pull request: https://github.com/pfsense/pfsense/pull/2762
That should be all for issue #5994
- Status changed from Assigned to Feedback
Both PRs had been merged. Thanks!
- Status changed from Feedback to Resolved
The rules case seems to be better after that, looks like this can be closed out.
Also available in: Atom
PDF