Add escapeshellarg() calls on exec parameters. While I'm here, replace some exec() calls by php functions like symlink, copy, unlink, mkdir
Fix #3259. Save 'packet loss rate' and 'bucket size' for limiter queues
Fix 'Packet loss rate' and 'Bucket Size' range checking
Fix codel not being applied on non-priq queue types
Fixed typo in CoDel wiki link
Remove call-time pass by reference from traffic shaper files, it should fix #2565
Traffic Shaper GUI text typos
and note the Queue Limit is a number of packets (not packets per second)
Dummynet does not require burst size specification
Dummynet traffic shaper does not require burst size specification andassumes 0 if not specified. Allow user to leave burst field blank/
Correct the comments describing the error with correct values
Add a brief description about bandwidth vs bursting.
A better fix for conditionally including burst.
Burst of 0 is also valid
Only add burst if a burst is defined
Include the burst size in the limiter. Submitted-by: http://forum.pfsense.org/index.php/topic,62470.0.html
Do not hide IPV6 setting when system->advanced->network->allowipv6 is false
Allow IPV6 bandwidth limiter mask
Bandwidth Limiter - Disable and blank mask bits input field when mask type is 'none'.
Allow explicit mask specification in bandwidth limiter
Allow explicit mask specification in bandwidth limiter. This backwardscompatible and implements ermal suggestions.
Allow codel to be activated as an option for the specific queues or as its own discipline without any childs
Tidy up "shaper.inc" XHTML
Add missing closing P tag
Fixes Javascript Errors
Fixes the Javascript error that prevents enabling/disabling the objectsin the interface.
Add missing end TR tagAdd missing end TD tagAdd missing end SPAN tagMove table row start into the PHP IF statement, so that the IF statementgenerates the full table rowRemove duplicate ID in INPUT tagSize parameter in INPUT tag can only be a whole number...
Update HTML boolean operators
Updated CHECKED, SELECTED and DISABLED boolean operator
Close INPUT tagsClose IMG tags and add "alt" parameterChange ONCLICK and ONCHANGE to lowercase
Tidy up "shaper" and "firewall shaper" XHTML
Update VALIGNDeprecated the ampersand in ANCHOR tagsUpdate TYPE in script
Add CDATA sections to javascriptClose off the BR tags
Previous attempt to fix #1995 allow to set more than one default queues, prevent it with this change. It should fix #1995
Remove call-time pass-by-reference
Allow to edit default queue. Should fix #1995
Correct limiter queue rule generation
Enable io_fast on dummynet to avoid uncessesary loop arounds of packets
Correctly mark found configuration.
Fixes http://forum.pfsense.org/index.php/topic,54595.0.html
More fixes to the schedules rules
break the loop for none schedule limiters
Mark the pipe/queue with zero(unlimited) bandwidth to allow traffic on the state to flow still or new traffic matching the rule to flow. Dummynet blocks traffic not matchign apipe/flow by default. Reported-by: http://forum.pfsense.org/index.php/topic,54595.msg294734.html#msg294734
To avoid issues with missing removed schedules just do not create the pipe at all
Correct issues with limiters. 1. correct spelling of config option 2. avoid duplicating javascript
Check if there is any configuration present before going through it.
Merge pull request #239 from phil-davis/master
Limiter addBwRowTo plus icon syntax
Ooops fix removed line by accident
Fix the syntax so that the GUI Limiter, Creat new limiter, Bandwidth "+" icon as the correct title text, and the Mask field gets displayed.Note that clicking the "+" icon still does not make an empty first row when creating a new limiter.
Make limiters have a schedule specified which applie bandwidth limits during that period
Fixes #2428. Reference limiters in rules by name to avoid issues. Also put upgrade code for existing configs. The same fix is necessary for 2.0.x though not sure how this should be committed there.
fix typo. Ticket #2371
Correct location of '\n'
Correct building of queue to not depend on parent mask
fix for: Traffic Limiter Bits/sec option broken
fixes #2296
http://redmine.pfsense.org/issues/2296
Mute error: Undefined variable: g in /etc/inc/shaper.inc on line 4062
Fixes this: http://redmine.pfsense.org/issues/2015
I was checking, but if someone of the stuff give it a check it would be much better, since this is a core feature!
Show friendly interface names
Correct the link generation. Reported-by: http://forum.pfsense.org/index.php/topic,39855.0.html
Remove a slipped in text that confuses people
Resolves #1193. Properly warn about duplicate default queue
Ticket #1193. Do not show default queue checkbox when another queue has it selected.
Merge remote-tracking branch 'mainline/master' into inc
Conflicts: etc/inc/priv.defs.inc
Do not show the root interface queue on the queue list availble since it is not allowed to choose it. Ticket #636
Conflicts: etc/inc/interfaces.inc etc/inc/upgrade_config.inc etc/inc/vpn.inc
Bring back the optimization on max-packets at pf(4) level now that the issues with daemon have been identified.
Conflicts: etc/inc/shaper.inc
Fix indent.
Correct the conditional testing.
Do not show the default queue selection for a queue that has child queues
Prevent non-numeric chars from being inputed on bandwidth field.
Conflicts: etc/inc/interfaces.inc etc/inc/priv.defs.inc etc/inc/shaper.inc etc/inc/system.inc
Conflicts: etc/inc/auth.inc etc/inc/config.lib.inc etc/inc/filter.inc etc/inc/pfsense-utils.inc etc/inc/pkg-utils.inc etc/inc/priv.defs.inc etc/inc/services.inc...
Unbreak adding subqueues to queues also. This has happened after allowing renaming, oops.
Unbreak adding subqueues to limiters. Correct some text in the way.
Ticket #1374. Actually test the right field name.
Fix javascript errors reported by: http://forum.pfsense.org/index.php/topic,34139.0.html
Allow renaming even shaper queues as an improvement.
Fixes #1207. Allow renaming a limiter. Also prevent a limiter to be deleted if it is referenced in filter rules.
Merge branch 'master' into inc
Conflicts: etc/inc/captiveportal.inc etc/inc/config.console.inc etc/inc/config.lib.inc etc/inc/easyrule.inc etc/inc/filter.inc etc/inc/ipsec.inc etc/inc/pkg-utils.inc etc/inc/shaper.inc...
Make this actually work as it should. The warnings about default queue should be ok now.
Actually send a notice even if no default queue could not be found. This might be serious in some cases.
Do not put the queue config on the rules if there is no default queue, just log it. This prevents errors in rules loading which is worse than having no shaper.
Log the errors we know for not allowing a queue to be added.
Ticket #1210. Also here unset any previous value if none posted.
If no value is posted means we have no value to save in config and should unset any pervious set ones.
nuke trailing carriage returns
Be consistent on having 1K == 1024
This checkbox enables, remove confusing enable/disable.
Merge remote branch 'mainline/master' into inc
Conflicts: etc/inc/auth.inc etc/inc/config.lib.inc etc/inc/filter.inc etc/inc/gwlb.inc etc/inc/interfaces.inc etc/inc/pfsense-utils.inc etc/inc/pkg-utils.inc...
Nuke trailing c/r
Conflicts: etc/inc/PEAR.inc etc/inc/filter.inc
Remove trailing carriage return
Fix display of queues on rules and layer7 containers.
Conflicts: etc/inc/auth.inc etc/inc/config.lib.inc etc/inc/priv.defs.inc etc/inc/system.inc etc/inc/upgrade_config.inc etc/inc/vpn.inc
Do not show on the queue/limiters list the disabled entries(optimized and cleaner version).
Do not show on the queue/limiters list the disabled entries.
Fix gettext on shaper.inc
Implement gettext() calls on shaper.inc
Properly clear the qlimit or tbrconfig settings when a value is deleted from GUI
Resolves #716. Correctly unset values of m1 and d on HFSC and appropriate special values on other schedulers if previously they had a value.
Resolves #791. add a missing = in the get request.
Even on child queue honor when bandwidth is empty for HFSC this is valid.
If no bandwidth specified for root queue honor this decision and generate proper rules.
Remove priority from HFSC it is a null config option. Center most of the text in the center of a <td> and add some space between objects.
Show the Enable/Disable and name first and then the bandwidth values. Fix html markup so the table is displayed propperly.
fix text