pfSense

Fixed #5714

Remove workaround to get dpinger running when interface is in tentative state

Do not start dpinger processes due to rrd

Restore default MTU when field is cleared. Fixes #3926

Make sure source and target addresses have scope id when they are link-local. It should fix #5695

Add a seatbelt to prevent 2 dpinger instances for same GW

Collect dpinger processes that failed to start and try again after 1 second, this should be enough to fix #5711

No need to return 0 here

Change start_dpinger() to return dpinger return code

Do not overwrite $params

Merge pull request #2332 from dennypage/master

Follow dpinger and change default loss_interval to 4* send_interval

Disable unused stdout reporting thread

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

Disable IPsec phase1 or phase2 using DES and inform user why they were disabled since DES is no longer supported. It should fix #5543

Revert "Delete package XML only on post-deinstall, otherwise it'll do it twice"

This reverts commit 92b3ac622cc3789ca00b625052621f0dc4262f1f.

Revert "Silent accept deinstall and pre-install on rc.packages"

This reverts commit d7c8eb30ddad2140a2790a7a8989158e52f74bc9.

Only remove config.xml items on post-deinstall, fixes #5689

Disable all IPsec P1 entries when old version has IPsec globally disabled. Fixes #5699

Fixes issue where limiter mask does not save (from forum)

Replace inetd by xinetd, it should fix #5707

update comment for dpinger

HTML Compliance - System / Advanced / Firewall and NAT

Bad value 200000↩ for attribute placeholder on element input: Line feed not allowed.
<input class="form-control" name="maximumtableentries" id="maximumtableentries" type="text" placeholder="200000↩">...

This broke things again. Revert "data sanitising: ip2long32, ip2ulong, long2ip32 (FIXED RESUBMIT of #2152)"

This reverts commit 4557e3fba627c91c37afba04681cdabf71eccf57.

data sanitising: ip2long32, ip2ulong, long2ip32 (FIXED RESUBMIT of #2152)

Self explanatory. If these functions find themselves trying to convert non-int data (or an x64 int with non-zeros in any bits >32) to dotted IPv4, or non-dotted IPv4 to integer IPv4 values, something's wrong and they shouldn't return a value that looks like they succeeded....

Return complete path for dpinger PID filename, it should fix #5686

Be less specific with dpinger PID filename regex, old version was not matching IPv6 addresses, with or without %ifname in case of ll

Silence array_map() call to avoid getting unlink errors for directories

Merge pull request #2309 from phil-davis/tiw

Avoid triggering initial wizard before reboot

If you use the the webGUI to reset to factory defaults, then while the
existing system is shutting down you navigate off to the dashboard, the
initial setup wizard will start. The trigger_initial_wizard flag file is...

Redmine #5613 avoid Reset to Factory Defaults PHP warnings

On Reset to Factory Defaults there are some warnings given when unlink_if_exists() tries to unlink() directories in /conf - /conf/backup and /conf/sshd.
unlink does not work on directories.
This PR avoids the PHP warnings by not trying to remove the directories inside /conf....

Rework dpinger related code to new version

- s/-U/-u/
- Add i GW_NAME to get this info on logs and make life easier
Since i parameter will be send to alert_cmd, remove it from command
Add source and target IP addresses on pid/socket filename since status...

Reverts PR2152 reported as causing OpenVPN issues here: https://forum.pfsense.org/index.php?topic=104175.0

Fix gen_subnetv4_max

and use it in services_dhcp rather than trying to do the similar
calculation in-line.
Should fix redmine #5654 and probably a bunch of other things that use
gen_subnet_max

Flush zone's tables if its db must be reset to avoid leaving behind any table entries. Ticket #5622

Add busytimeout of 60 seconds for CP database access. This matches the default value PHP uses with sqlite 2.x versions (pfSense 2.1.x and earlier) and prevents the issues noted in Ticket #5622

Nuke fifolog support. It was never used or fully implemented, no GUI option, and didn't end up working out.
It buffered writes too long, users could never see the most current log data.

Merge pull request #2263 from phil-davis/r016

add these three strongswan libs to the obsoletedfiles list. They haven't been included in any releases, but were briefly included in snapshots in mid April 2015.

Consolidate OpenVPN kill_client routine

After a gitsync just now I started getting "cannot redeclare
kill_client" error messages. Whatever it was that caused this to start
happening, the kill_client() function in these 2 places is identical.
Might as well put it in openvpn.inc

No need to set LANG env var here

Consolidate conv_log_filter RegEx Patterns

Consolidate common regex patterns.
Use pattern globally in parse functions.

util.inc syntax error and code style

Line 578 of the previous commit had a bonus ")".
Code style also fixed up.

Merge pull request #2151 from stilez/patch-11

Merge pull request #2152 from stilez/patch-12

Fix handling of 0-byte files uploaded to the CP file manager.

Silent accept deinstall and pre-install on rc.packages

Remove /etc/gettytab

Remove unused empty /etc/printcap file

Changed sop icon to fa-stop-circle-o

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Retire verify_digital_signature() and pubkey.pem

Remove /etc/protocols

Obsolete /etc/fbtab

Remove /etc/fbtab

Remove static copy of /etc/services

Fixed #5626

Fixed #5626

globals.inc comment typos

Moved global defines to globals.inc

Merge pull request #2212 from NOYB/Sys_Log_RegEx_Var_Name_Tweak

Delete package XML only on post-deinstall, otherwise it'll do it twice

Set language early on a common place included everywhere. This fix some tar warnings 'Failed to set locale'

Remove dead code, we only have UTF-8 today

Update pfsense-utils.inc

When installing packages, an extra line break is added by the "\r" ... echo "\r{$status}";
The $status string typically contain a trailing "\n" as required. This allows to print a message in two steps.

Writing configuration... done....

Fixed #5620 change css classes from icon- to text-

Tweak for correct var naming , so that:

process_pattern var actually holds the process pattern instead of the host name pattern.
pid_pattern var actually holds the pid pattern instead of the process and pid patterns.
No functional changes. Just good to have the var names reflect what they really hold.

Rename of files to better match their position in the memory structure

Status - System Logs - Manage Log

Build up th manage log section with options to override the "General Logging Options" settings on an individual log basis.
Remove over exuberant gettext's.
Set/adjust filter form field widths to be better fitting for the field types....

link to proper license information location

Use default values for latencylow and losslow when they are not defined by user. Reported by grandrivers at https://forum.pfsense.org/index.php?topic=103818.msg579069#msg579069

Convert latency to ms before use it to compare with value defined in gateway conf

Change quality rrd delay variable again to match same unit apinger used so we don't break current database. Ticket #5624

Fix parameter order

Add template to rrd update

Actually call bc to do the math, ticket #5624

Convert delay to milliseconds for RRD graph, ticket #5624

Remove unused function create_gateway_quality_rrd()

Implement RRD gateway qualiry support after move to dpinger. Fixes #5624

Use $ values for vardb_path

Merge pull request #2185 from phil-davis/factory-default-interfaces-20151208

Merge pull request #2182 from NOYB/write_config_only_option

Merge pull request #2191 from phil-davis/patch-3

Merge pull request #2192 from phil-davis/patch-4

Merge pull request #2193 from phil-davis/patch-5

Merge pull request #2194 from phil-davis/patch-6

Merge pull request #2195 from phil-davis/patch-8

Merge pull request #2202 from phil-davis/patch-11

Fix GW setting names in upgrade_config

gwlb array key typo loss_interval

Write upgrade config to replace apinger by dpinger, it should fix #5624

Ticket #5624: Welcome dpinger!

Add rc.gateway_alarm script

dpinger always pass 3 parameters to alert_cmd, what can make pfSctl confuse,
This script will be called by dpinger when alarm goes on or off, then
it's going to call pfSctl

Merge pull request #2199 from heper/patch-2

Fixed #5602 by dynamically updating hte help text based on the cert selected.

fix #5563

Code style and white space in etc

Remove bonus debug from filter_log.inc

These debug blocks look like they should not be in production. if 'debug' is turned on, then they would always log_error() and return for all log lines, even good ones.

Internationalize more of config.console.inc

This code is a whole mix of some palces that use gettext() and other chunks of output that are hardcoded text between "EOD" markers.
I have got rid of the "EOD" blocks where there is a question asked - those needed to have a space at the end of the question. To meet code style guide it is easy if questions are all in their own echo statements and the space " " can be visibly coded in.

Internationalize console reset to factory defaults

This is another one that was using echo EOD stuff and needed a space after "Do you want to proceed [y|n]?".