Project

General

Profile

Statistics
| Branch: | Tag: | Revision:

# Date Author Comment
21915c63 08/03/2016 11:43 AM NewEraCracker

Some tweaks to improve alignment in table with checkbox

1) If a checkbox does not have a description (even if it is empty), layout will be broken as checkbox won't be aligned correctly

2) UPnP checkbox looks better with description instead of help

This commit fixes the two issues...

fe179ed6 07/18/2016 03:44 PM Stephen Beaver

Allow section header to be omitted by specifying "NOTITLE" as the section title.

(cherry picked from commit 9ce54773be5e02235e3be7d2b970f61fbb27ba86)

aaec5634 07/15/2016 06:32 PM Renato Botelho

Review license / copyright on all files (final round)

8acd654a 07/14/2016 09:36 PM Renato Botelho

Review license / copyright on all files (1st round)

595b074d 06/30/2016 05:20 AM Phil Davis

Feature #6388 custom GUI preference settings per user

e4c5b7d4 06/28/2016 12:49 PM Phil Davis

Remove a-f from IPv4 address pattern

It seems to me that a through f should not be part of the pattern for the "V4" case.
(cherry picked from commit 1f49dd8a3a49b724ded5840c1db6c168ed466aae)

94b5eb1f 06/22/2016 03:57 PM NewEraCracker

Fix Bug #6394 - Incorrect Output of Translation

Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings

(cherry picked from commit 6ae99aba5cab12440d88dd9ddaa6535c3b9b5d82)

2c4af48f 06/21/2016 06:47 PM Stephen Beaver

Fixed #6498 by providing new address type argument to Form_IpAddress(). In this case it is specified as "V6".

(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)

16fd5b50 05/20/2016 12:02 PM NewEraCracker

Reduce maximum length of string to gettext()

This limit is set at 4096 on PHP 5.6: http://lxr.php.net/xref/PHP_5_6/ext/gettext/gettext.c#139

Bug report on forum: https://forum.pfsense.org/index.php?topic=110088.0

(cherry picked from commit 95f46512d9410b38b23d7778cec0bf8610e448cf)

f2c719c9 05/07/2016 07:46 PM Stephen Beaver

Experimentally fixed #6327

(cherry picked from commit 54fc9503ff550d04d1253c41c1fd49da1b64c07e)

60f8fa56 03/14/2016 11:10 AM Phil Davis

Translate button text

74bd7993 03/11/2016 01:53 PM Phil Davis

Translate the default submit button text

Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text....

be7ef04b 03/10/2016 04:50 PM Jim Pingle

Make fa-save the default button icon for 'Save' on all forms. Ticket #5965

e42fcbd0 01/22/2016 10:17 AM NOYB NOYB

Adding {} to if statement.

cba2816e 01/22/2016 08:02 AM NOYB NOYB

Form Group - Empty Title GetText

Don't call gettext with an empty title.

There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.

Fixes use case of form group class without a title from passing empty var to gettext....

a5a983ae 01/19/2016 12:42 AM Pi Ba

classes/Form/Textarea.class.php, setNoWrap, make it work properly on FireFox and Chromium

c8a5dfce 01/18/2016 01:41 AM Jim Pingle

Put this htmlspecialchars back, I found a better workaround for the inconsistent handling of checkboxes in packages.

d8a88826 01/17/2016 01:09 PM Sjon Hortensius

Fix inconsistencies in Form_Input

renamed get_type to getType
fix capitalisation in getTagName

17c7c906 01/16/2016 06:31 PM Jim Pingle

Don't run the checkbox label through htmlspecialchars, it breaks several packages.

ba14d86f 01/16/2016 03:45 PM Jim Pingle

Don't automatically run strings that are too long through gettext here.

e418b7b6 01/06/2016 09:18 PM Stephen Beaver

Change method name to setIsRequired() to match other similar methods

7bf36694 01/06/2016 04:32 PM Stephen Beaver

Added new method setRequired() (shortcut for setAttribute("required", true) )

cf7a4f09 01/05/2016 12:57 PM NOYB NOYB

HTML Compliance - Form Button - HRef

The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.

187f96b9 01/04/2016 02:08 PM Stephen Beaver

Correct "noWrap" in text areas. (Function is not actually used by anyone, but it might as well work just in case.

d395af26 12/29/2015 04:09 PM Stephen Beaver

Final updates in support of hidden passwords

ddffa78c 12/28/2015 07:44 PM Stephen Beaver

Don't display dummy password if configured pwd is empty

5ea90990 12/28/2015 07:33 PM Stephen Beaver

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

e5274f51 12/22/2015 05:43 PM Stephen Beaver

Move width:auto style to textarea handler in pkg_edit.php

b5326b1d 12/22/2015 04:26 PM Stephen Beaver

Merge pull request #2316 from phil-davis/patch-3

ede54eaa 12/22/2015 04:21 PM Stephen Beaver

Merge pull request #2295 from NOYB/HTML_Compliance_-_Form_Input_-_Placeholder

5736b2ce 12/22/2015 02:49 PM Phil Davis

HTML Compliance - Form Select 3rd try

This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315

f84d2a90 12/22/2015 01:56 PM Stephen Beaver

Default textarea width to 60 cols.
Use setCols() to override

6e871698 12/22/2015 01:47 PM Stephen Beaver

Adds style="width: auto;" attribute to textareas to allow the "cols" attribute to take effect. Required bu pkg_edit.php and by wizards

09f9fff9 12/22/2015 01:17 PM Stephen Beaver

Reverts change to Form_Selector which was breaking selectors with blank options

c70b6835 12/21/2015 10:06 PM Stephen Beaver

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php

07271d6c 12/21/2015 01:36 PM Stephen Beaver

Merge pull request #2298 from NOYB/WebGUI_Left_Column_Labels_Hyper

f35ce6d2 12/21/2015 01:33 PM NOYB NOYB

HTML Compliance - Form Group - Label For

The for attribute of the label element must refer to a non-hidden form control.

24f15b3a 12/19/2015 01:14 PM NOYB NOYB

WebGUI Left Column Labels Hyper

Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0

Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.

No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes....

97743e56 12/19/2015 02:32 AM NOYB NOYB

HTML Compliance - Form Input - Placeholder

Attribute placeholder not allowed on element select at this point.
Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.

bc3b831d 12/19/2015 12:37 AM NOYB NOYB

HTML Compliance - Form Select

Element option without attribute label must not be empty.

47cf96e0 12/15/2015 03:30 PM NOYB NOYB

Applying htmlspecialchars on form action attribute causes ampersands to multiply, and also breaks multi-parameter query strings that are delimited with ampersands.

4a457d8d 12/14/2015 06:22 PM Stephen Beaver

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

279ea790 12/14/2015 04:41 PM Stephen Beaver

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

53eac591 12/14/2015 04:39 PM Stephen Beaver

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

a4b5b782 12/13/2015 09:54 AM NOYB NOYB

HTML Compliance - Collapsible Form Section HREF

Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.

<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20....

94826107 12/13/2015 08:51 AM NOYB NOYB

HTML Compliance - Checkbox Display As Radio Unique ID

Ensure checkbox display as raido has unique id.
Allow an id to be passed in displayAsRadio() as argument0.
If no argument is passed, construct id as name_value:uniqid.

Previous behavior was id = name. So all the radio buttons of the set had same id.

fe70112b 12/13/2015 12:06 AM NOYB NOYB

HTML Compliance - Form Action Attribute

Fix Empty Form Action Attribute Violation

An empty form action attribute is an HTML4 and HTML5 specification violation.

http://www.w3.org/TR/html5/forms.html#attr-fs-action
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."...

d47bc2ce 12/03/2015 07:50 PM Stephen Beaver

Revise collapsible section behavior to use defines (COLLAPSIBLE, SEC_OPEN, SEC_CLOSED)

16e4d564 12/03/2015 07:22 PM Stephen Beaver

Spelling

331e063c 12/03/2015 07:22 PM Stephen Beaver

Further changes to Section.class.php and to diag_logs_filter.php
Experimental section collapse

Form_Section() now accepts up to 4 arguments: Form_section(title, id, collapsable, initiall_collapsed)

collapsable = true specifies that the panel should be collapsable and should have a plus/minus icon in the title bar to allow that. Defaults to false...

b0006f27 12/02/2015 07:19 PM Stephen Beaver

Add full classpath to autoloader so that packages can run from their own directories.

d5d5836c 12/01/2015 02:41 PM Stephen Beaver

Experimental changes to Form_Section() to allow the panel to be made collapsable in the same way that dashboard widgets are.
Currently used on diag_logs_filter.php ONLY

660bd992 11/29/2015 04:58 PM Colin Fleming

Update Form_Input flass

02cc81ef 11/23/2015 12:54 PM Doug Wollison

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

e4a78780 11/19/2015 04:17 PM Bruno Ferri

add attribute 'id' for the Form_Section

9279147a 11/09/2015 05:20 PM Stephen Beaver

Allow fa icons to be embedded in Form_Button class buttons

23f6cdd7 09/25/2015 06:50 PM Stephen Beaver

Initial conversion of the file. Most functions completed and tested, but more testing remains

87c59979 09/18/2015 09:16 PM Stephen Beaver

Fixed #5121
Obscure PHP issue with mixed variable types.

784b435b 09/11/2015 08:04 PM Stephen Beaver

Revised all pages with autocomplete to accommodate host names in validation and change port inputs to 'text'

309e8f8f 09/09/2015 03:58 PM Stephen Beaver

Fixed Modal class issues
FInished interfaces.php (probably)
Fixed notices error in head.inc

aeeda8b4 09/08/2015 06:29 PM Stephen Beaver

Fixed modal.class.php so that modal forms now work
interface.php changes still WIP

cddc70a2 09/08/2015 01:38 PM Stephen Beaver

Fixed #5102
javascript revised to accommodate VPN masks

5c255783 09/04/2015 06:57 PM Stephen Beaver

Fixed #5102
Provided new method addVPNMask() that creates a mask selector including '0'

03b19a93 08/26/2015 06:12 PM Renato Botelho

Merge branch 'master' into bootstrap

46bc6e54 08/25/2015 05:49 PM Renato Botelho

Move main pfSense content to src/