pfSense

Reverts change to Form_Selector which was breaking selectors with blank options

Modify CSS to allow caller to specify width

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php

Fix help text on delete row when selector is used in a PHP table

Test for #5676

Fixed #5678

Fix row add/delete issues intorduced by PR https://github.com/pfsense/pfsense/commit/f35ce6d20e6fd1e3b66b5935c70532d7e5fa741f/

Only disable CSRF on diag_backup.php for the download action where it might be scripted. Other actions need its protection.

Encode hostname before printing; remove some related dead code.

Add "BETA" badge to ne UI feature

adding active tab to breadcrumb

closely review L186 - L188

Encode gateway attributes before printing

Merge pull request #2301 from NOYB/Staus_-_System_-_Logs_-_Write_Config_Only

Merge pull request #2298 from NOYB/WebGUI_Left_Column_Labels_Hyper

HTML Compliance - Form Group - Label For

The for attribute of the label element must refer to a non-hidden form control.

Silence array_map() call to avoid getting unlink errors for directories

Merge pull request #2306 from ExolonDX/branch_06

Merge pull request #2305 from ExolonDX/branch_04

Merge pull request #2309 from phil-davis/tiw

Merge pull request #2308 from phil-davis/patch-5

Merge pull request #2303 from phil-davis/patch-2

Merge pull request #2302 from ExolonDX/branch_03

Merge pull request #2300 from ExolonDX/branch_02

Merge pull request #2299 from ExolonDX/branch_01

Merge pull request #2294 from NOYB/HTML_Compliance_-_Form_Select

Merge pull request #2293 from phil-davis/patch-3

Avoid triggering initial wizard before reboot

If you use the the webGUI to reset to factory defaults, then while the
existing system is shutting down you navigate off to the dashboard, the
initial setup wizard will start. The trigger_initial_wizard flag file is...

fix text

Only enable Restore Configuration if a file is selected

If the user clicks "Choose File" and then cancels the file selection dialog, disable the "Restore Configuration" button.

Update wake_on_lan.widget.php

Remove unused TD tag

Tidy up columns in "ipsec"

status_ipsec.php
- remove unused column

vpn_ipsec.php
- reduce COLPSAN to seven

Tidy up widgets

ipsec.widget.php
- add missing TR tags to THEAD

wake_on_lan.widget.php
- remove stray double quotes

Redmine #5613 avoid Reset to Factory Defaults PHP warnings

On Reset to Factory Defaults there are some warnings given when unlink_if_exists() tries to unlink() directories in /conf - /conf/backup and /conf/sshd.
unlink does not work on directories.
This PR avoids the PHP warnings by not trying to remove the directories inside /conf....

Replace FONT tag with SPAN

Replace FONT tag with SPAN tags and Bootstrap CLASS statement
Escape double quotes correctly in "system_usermanager_settings_test.php"

Staus - System - Logs - Firewall - Write Config Only

If no logging changes have been made, only write the config file.

Staus - System - Logs - Write Config Only

If no logging changes have been made, only write the config file.

Use Bootstraps text alignment classes

As per "http://getbootstrap.com/css/#type-alignment", use CLASS
statement instead in inline STYLE statement (much tidier)

Remove $closehead variable

Remove unused variable $closehead

WebGUI Left Column Labels Hyper

Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0

Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.

No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes....

Fixed #5659

HTML Compliance - Form Select

Element option without attribute label must not be empty.

Rework dpinger related code to new version

- s/-U/-u/
- Add i GW_NAME to get this info on logs and make life easier
Since i parameter will be send to alert_cmd, remove it from command
Add source and target IP addresses on pid/socket filename since status...

Reverts PR2152 reported as causing OpenVPN issues here: https://forum.pfsense.org/index.php?topic=104175.0

Fixed #5636

Merge pull request #2292 from phil-davis/patch-2

Merge pull request #2291 from phil-davis/snmax

Merge pull request #2289 from NOYB/HTML_Compliance_-_Wake_On_LAN_Widget

Merge pull request #2288 from NOYB/Status_-_System_Logs_-_Manage_Log_-_Input_Validation

Fixed #5653
Removed bogus code that forced system information to be first in the list
Added JS to always add system_information to col 1

Bump for Nuke fifolog support

Should the default config version always be bumped to match the version in globals.inc when new upgrade code is committed?

Fix static DHCP address validation

1) Use gen_subnetv4 and gen_subnetv4_max rather than doing the guts of the calculation inline. (The ~gen_subnet_mask_long($ifcfgsn) thing was the cause of the problem)
2) Add validation checks to stop people using the network address or broadcast address as a statically allocated DHCP address....

Fix gen_subnetv4_max

and use it in services_dhcp rather than trying to do the similar
calculation in-line.
Should fix redmine #5654 and probably a bunch of other things that use
gen_subnet_max

Validate IP passthrough bandwidth values within sane range. Ticket #5655

Validate CP MAC passthrough bandwidth. Ticket #5655

HTML Compliance - Wake On LAN Widget

Align attribute not supported on td tag in HTML5 use css instead.
Center tag not supported in HTML5 use css instead.

Add max value to qty field.

Status - System Logs - Manage Log - Input Validation

Add input validation at form level in browser.
Keep PHP server side validation so as not to rely solely on the browser.

Flush zone's tables if its db must be reset to avoid leaving behind any table entries. Ticket #5622

Merge pull request #2287 from NOYB/Interfaces_-_DHCP_Config_File_Override

Interfaces - DHCP Config File Override

Correct section label.

Interfaces - DHCP Advanced Options - Number Attributes

Protocol timing select timeout; override system minimum number attribute to allow zero.

Merge pull request #2285 from ExolonDX/branch_04

Merge pull request #2284 from ExolonDX/branch_03

Tidy up "services_igmpproxy.php"

- Close TH tag correctly

Tidy up "services_dhcp.php"

- Close TABLE correctly

Merge pull request #2283 from ExolonDX/branch_02

Tidy up "ntp_status.widget.php"

- Tidy up coding style
- Remove unnecessary DIV tab
- Update TABLE tag

Correct quotes around $ifdesc introduced in PR 2282

Tidy up "services_dyndns.php"

services_dyndns.php
- remove duplicate double quotes
- tidy up tabs/spaces

services_rfc2136.php
- remove duplicate double quotes
- tidy up tabs/spaces

dyn_dns_status.widget.php
- change echo to print
- change FONT tag to SPAN tags and use correct class...

Add busytimeout of 60 seconds for CP database access. This matches the default value PHP uses with sqlite 2.x versions (pfSense 2.1.x and earlier) and prevents the issues noted in Ticket #5622

Merge pull request #2281 from ExolonDX/master

Tidy up "status_wireless.php"

Remove closing FONT tags

Merge pull request #2280 from phil-davis/patch-4

services_rfc2136_edit remove unused $input

These bits if code that put new Form_Checkbox() into var $input do not seem to do anything useful. They just made me wonder why they were there.
If someone knows how they do anything useful, then please say so. Otherwise we can get rid of $input here.

Merge pull request #2279 from phil-davis/patch-2

Point more directly to Certificate Revocation page

This could point more directly to the Certificate Revocation page.

Nuke fifolog support. It was never used or fully implemented, no GUI option, and didn't end up working out.
It buffered writes too long, users could never see the most current log data.

system_usermanager remove unused code

1) Line 448 "Remove this certificate association? (Certificate will not be deleted)" there was the text "Delete" being displayed and not looking good, in addition to the trash bin icon. Just the trash bin icon seems to be all that is needed....

system_crlmanager dodgy else statement

The "else" that was at line 550 should enclose the whole block of code below it. The "if" handles the case "No Certificates Found for this CA." and all the code below the else should only happen when there are certificates found.

Change status.php state dump to use -vvss for more verbose info, add kenv and pkg info

Fixed #5650

Fixed #5648

Save button fix - part deux

Fix "Save" button jQuery

Merge pull request #2276 from phil-davis/r020

Merge pull request #2275 from phil-davis/patch-5

Merge pull request #2274 from phil-davis/r019

Merge pull request #2273 from phil-davis/patch-4

Merge pull request #2272 from NOYB/Interfaces_-_Assign_-_Wireless_-_PHP_Crash

Merge pull request #2271 from NOYB/System_-_Advanced_-_Admin_Access

Merge pull request #2270 from NOYB/Interfaces_-_DHCP_Advanced_Options_-_Require_Options

Merge pull request #2268 from NOYB/Interfaces_-_DHCP_Advanced_Options_-_Radio_Buttons

Merge pull request #2267 from phil-davis/r018

Merge pull request #2265 from phil-davis/r017

Merge pull request #2266 from NOYB/HTML_Compliance_-_Dashboard_-_Widget_Config_Panel

Merge pull request #2264 from NOYB/HTML_Compliance_-_Dashboard

Merge pull request #2263 from phil-davis/r016

Merge pull request #2262 from NOYB/HTML_Compliance_-_Traffic_Graphs_Widget

Merge pull request #2261 from NOYB/HTML_Compliance_-_Thermal_Sensors_Widget

Merge pull request #2260 from NOYB/HTML_Compliance_-_RSS_Widget