pfSense

cleanup interfaces_groups.php

interfaces_groups.php Conversion complete

Page updated for compatibility with the other interface_* pages

diag_patterns.pgp Conversion complete

Ready for review.

Note: The “Browse” button has some alignment issues that should be
addressed.

guiconfig.inc updated

dump_clog_no_table() now returns the number of log lines printed so
that the caller can display a message if there were none.

print_info_box() now accepts an optional class argument allowing the
caller to specify the alert box appearance as in:...

diag_logs_filter_dynamic.php conversion complete

Ready for review

Table can be popularized both on initial load and at timed intervals,
hence the button needed to be specified in both files.

Put something usefull in placeholder for Filter expression

Merge pull request #172 from sbeaver-netgate/diag_logs_filter_summary

Convert diag_logs_filter_summary

Merge pull request #165 from Bouwdie/services_dhcp_relay

Covnert services_dhcp_relay + bugfix in IpAddress

If a btn-danger has a title, use that instead of generic for confirm()

simplify xhr delete button

Merge pull request #155 from sbeaver-netgate/diag_dump_states

Convert diag_dump_states.php

Merge pull request #162 from sbeaver-netgate/system_hasync

Converted system_hasync

Merge pull request #151 from sbeaver-netgate/status_rrd_graph_settings

Converted status_rrd_graph_settings.php

Remove 'form-control' class from file inputs

Refs. #180

diag_logs_filter_summary improved per SH

Thanks for the suggestion. Can’t believe I didn’t see that :(

Merge pull request #161 from sbeaver-netgate/diag_logs

diag_logs - Added warning for DHCP

Merge pull request #150 from sbeaver-netgate/diag_pkglogs.php

Converted diag_pkglogs.php

Display inner tabs as tabs

- Fixed indenting
- Fixed matching closing tags
- Moved action buttons to separate <nav>

Refs. #22

Removed unneeded var

Converted img to btn-xs button

diag_logs_filter_summary conversion complete

Ready for review

The previous charing system is not compatible with JQuery (because it
makes use of its own $() macros and converting the code would be
horrible. It is not responsive or attractive anyway.

The library has been removed and replaced by d3pie.js. The page has...

Make save button for widget configuration better visible

Refs. #48

Merge https://github.com/SjonHortensius/pfsense into bootstrap

Revert button>input so we can keep using $name

refs #101

Fix print_info_box_np with apply button

- Wrap message in container to float button to the right
- Fix syntax error

Refs. #101

Replace td's with th's and make table responsive

Refs. #168

Merge https://github.com/SjonHortensius/pfsense into bootstrap

Improved as suggested

Thanks

Merge pull request #157 from sbeaver-netgate/system_firmware

Convert system_firmware conversion

Rewrote xhr javascript, applied .form-inline refs #153

Merge pull request #153 from sbeaver-netgate/status_graph

Inital conversion of status_graph.php

Merge pull request #146 from sbeaver-netgate/status_ntpd

Converted status_ntpd update

Merge pull request #145 from sbeaver-netgate/status_interfaces

Converted status_interfaces.php

removed red. indenting + unused variable refs #139

Merge pull request #139 from sbeaver-netgate/status_gateway_groups

Converted status_gateway_groups

Use default array_filter callback.
Moved adding of section down for clarity.
Wrapped message in an alert (same as print_input errors but without the extra txt).

Added fix in IpAddress to check if a mask is set to prevent a method call on a non object.
Migrated form.
Moved server input to an array form value.

Merge branch 'bootstrap' of https://github.com/Bouwdie/pfsense into services_dhcp_relay

Caught up with main repo.

system_hasync.php - Conversion complete

Ready for review

diag_logs.php Added DBCP warning

Warning notice is required when viewing DHCP logs
Reduced unneeded indenting in HTML

ensure gettext and htmlspecialchars are correctly called

dig_settings updated

Switched to my master branch, updated with pull from SH fork, updated
tab array and committed.

This version should correspond to the head version but with revised tab
array.

diag_logs.php Minor edit per SH suggestion

Substitute in_array() for long ‘if’ statement

Thanks for the suggestion

diag_logs - log file consolidation

A GET argument has been added to dig_logs.php so that the log file to
displayed can be specified.

Minor edits to the file allow all log files to be displayed correctly

The tab array has been updated in this file, and in:...

status_rrd_graph_settings detail changes per SH

Thanks for the suggestions.

status_ntpd.pnp detailed changes

Removed unneeded printCell funtion

system_firmware detailed changes

Removed unneeded placeholders
Forced firmware upgrades to be disabled on atoll page load.

status_interfaces detailed changes per SH

Useful suggestions. Thank you.

htmlspecialchars() moved to showDef[Btn] functions
Minor formatting changes

status_gateway_groups

Detailed changed per SH

Merge pull request #147 from sbeaver-netgate/status_lb_vs

Converted status_lb_vs.php

ensure gettext and htmlspecialchars are correctly called

head.inc - don't include modal if there are no notices

update bootstrap to 3.3.4, jquery to 1.11.2

system_authservers - fix toggle by making it explicit fixes #108

also allow calling toggles without any arguments

status_gateways updated as requested

nbsp was not found. Perhaps I forgot to sync
Column widths were removed. You were right :)

Added thead/tbody tabs and removed unneeded div id

status_gateways.php conversion complete

Two tables eliminated
Colors defined to eliminate magic
Bootstrap column width specified
All obsolescent classes and elements removed

Corrected background color

status_gateways.php Bootstrap conversion

diag_traceroute updated as requested

Corrected typo

Updated per SH comments

Page ready for review

removed unneeded attributes, rewrote xhr-delete, made form not auto-submit

Tweak initial state for toggleable checkboxes

- When iterating over a jQuery object, just use $(this) for the current value
- Use the .data() method to fetch data attributes

Refs. #143

Detailed changes per SH

system_firmware conversion complete

Ready for review

introduce Form::setMultipartEncoding() for uploading files

dig_dump_states.php conversion complete

Ready for review

status_graph.php conversion complete

Tis page has a very clever presentation that I did not want to loose.
So one table remains.

Otherwise tit has been converted to Form.class, old classes and names
removed, javascript updated to use event.push, GET converted to POST...

Merge pull request #88 from sbeaver-netgate/diag_sockets

Convert diag_sockets

Updated for consistency with reboot.php

Revert "Merge pull request #100 from sbeaver-netgate/halt"

This reverts commit 5bd406696ae634b3993d79a8b9aef03eeab42488, reversing
changes made to b9bd62735f2afb818d9ff3afd399c6c7d3b904c5.

status_rrd_graph_settings.php conversion complete

Ready for review

diag_pkglog.php conversion complete

Ready for review

status_b_vs.php updated

Ready for review
Many nested tables and their old classes removed
Added warning when no LBs have been configured
Standardized colors

status_ntpd update complete

Ready for review

This conversion has no forms so lent itself to the removal off the
outer tables (3) the provision of some panels and a reorganization of
the HTML into php functions.

Suggestions welcome

status_interfaces - WIP for discussion

This is one way to present the information without the 600 lines of
HTML that were in the file.

Comments or suggestions?

Fix "Apply" button in dialogs #101

Add nav-wrapper to loose buttons

Don't use $section2, toggle all remote-options when disabled

pfSense.js - Force correct initial state for toggleable checkboxes #143

Prepare for different width, make widths static

refs #141

Merge pull request #134 from sbeaver-netgate/diag_logs_settings.php

Converted diag_logs_settings.php

Form - show all global Buttons in a single wrapper

fixes #135

Replaced js with toggles

Also eliminated unneeded gettext from help

Converted system_certmanager

fixes #106

Replace js with addClass to set button class

Also removed htmlspecialcharacters() where not required

Ran clean.sh.

diag_logs_settings replace ugly help with staticText

diag_logs_settings Removed bogus print_r

Also removed unneeded gettext

dig_sockets updated as requested

Also fixed an incorrect </div> placement
I have retained the “$class = 'info’;” for now as I believe it
significantly improves the readability of the page. We can always
remove it if people don’t like it.

Merge pull request #87 from sbeaver-netgate/diag_tables

Converted diag_tables.php

Merge pull request #138 from sbeaver-netgate/system

Bugfix: properly store timezone + don't close <a> twice

Merge pull request #109 from sbeaver-netgate/diag_logs

Converted diag_logs.php

Merge pull request #100 from sbeaver-netgate/halt

Updated halt.php for consistency with reboot.php

status_gateway_groups conversion complete

This page had three nested tables. It now has two, but this seems to be
the best way to display the information. Suggestions welcomed!

echo/print etc removed
Old classes replaced
Colors standardized

system.php bugfix

$timezonelist was an indexed array, causing the page to save the index
in the config, not the value.

Merge pull request #136 from Bouwdie/services_wol

Converted services_wol

Removed double newlines.
Removed onclick event.