Actually there is no reason to set a variable just to use once
Fix #3242 and some code cleanup:
- Only explode '/' and set address_subnet when address is a subnet, it fixes issue reported at #3242- While I'm here, do some cleanup on the way addresses are treated - Remove unecessary variable $tracker, we already have $counter set...
Make sure vlan interface exist when it's being configured, it fixes #3270
Split SSL/TLS into separate checkboxes so that plaintext connections can be made secured by using STARTTLS. Support for SMTPS connections should probably be done away with in future. Fixes #3180
Fix #3268 - avoid pf table names conflict:
. Create a list of reserved table names for the hardcoded ones. Use this list to validate aliases and load balance pool names. Check if alias names don't conflict with LB pool names and vice-versa
Add Captive Portal Zones privileges definition. Fix #3216
Allow special chars to be used on IPSec mobile login banner. Fixes #3247
Set default value to radius_protocol during upgrade, it should fix #3226
Fix 'Packet loss rate' and 'Bucket Size' range checking
added favicon to logged in pages
Needs parens
Remove newsyslog cron job on upgrade, if present.
Add upgrade code to change the DHCP next-server value to nextserver since it was renamed sometime in 2.1 but upgrade code didn't follow.
Perform a much more accurate comparison between two certificates to determine if they are identical when checking their revocation status. Fixes #3237
We do not use nor include newsyslog, so remove the cron job.
Remove this check, the value can be 0 here if the target is the first item in the array.
Replace pfSense with the rebrand
Now that doc.pfsense.org does https and redirects http to https, we may as well send the help links to the https destinations.
use (self) instead of any for web lockout
use (self) rather than any as the destination for the lockout rules
Fix display of pools in the LB status widget and on the LB Virtual Server status.
Merge pull request #815 from marcelloc/patch-1
fix pkg_edit.php to show interface description instead of interface name
Patch applied manually. Fixes bug #3245 and old interface names
Fix codel not being applied on non-priq queue types
Fixed typo in CoDel wiki link
If rc.newwanip is run on an interface that should not have an IP address, do not take any action.
Remove redundant copies of getNasIP(), it should fix #3234
require service-utils.inc for find_service_by_openvpn_vpnid()
Add missing td
Remove use of undefined var $conn and fix some td class
Make sure no extra spaces end up in the parsed IP, it can lead to issues in other places (Easy Rule, etc)
Respect default gateway option when adding a gateway from interfaces page. It fixes #3230
OpenSSL does not like country codes longer than two letters, so remove these entries that are not actually country codes.
Allow multiple valid time servers to be entered in the wizard, as they are allowed under System > General
Add patch from Ermal to fix ifconfig error on gif in certain cases.
Include the CP zone in the form parameters if one is defined. Fixes access to concurrent graph on zones other than the first/default.
Fix CP stats generation for concurrent users. Fixes #3225
Prevent assigned vlans from being changed the tag.
Fix #3218, reaload filter rules when activate or deactivate dhcpdv6
Make this name a little more general in case we decide to have multiple similar files.
Alix 2D6 crashes upgrade process withou out of diskspace
Updating the the RRD graphs causes two copies of each RRD's XML file to be stored in /tmp.
On Nanobsd, the default /tmp size is 40mb. It doesn't require very many RRD XML dumps before this is exhausted.
Certificate Manager, for 'Create an internal Certificate' use the correct 'Digest Algorithm'
Fix ufslabels.sh logic to avoid trying to convert slices which are already using appropriate labels. Fixes #3207
Switch to rw mode before file operations on RFC2136 cache. Fixes #3201
Convert mac address to lowercase when saving to avoid duplicates. It fixes #3195
s/BSDP/ESF/
Make sure to account for IP aliases on lo0 here, or they get duplicated on each CARP sync
No need to treat PHP errors as a crash on -RELEASE for now.
This broke correct detection of primary/secondary -- the person in that thread may have had some other config issue, but this broke working/valid configurations. Revert "Correct check to match the right vip based on configured ip. Reported-by: http://forum.pfsense.org/index.php/topic,66234.0.html"...
Fix didn't help -- backing this out and the change that made it necessary. Revert "Correctly check the secondary/primary parameter setting on dhcp failover configuration"
This reverts commit 24670866827b4e2d7a4a05baaf6d09ee377ce7cb.
Fix update URL so the -RELEASE version looks at the stable updates URL by default rather than the snapshots server.
Update an existing cron entry for pppoe periodic resets
The array variable name was incorrect in the test, so the existing cron entry was not being matched. Fixes #3192
Require IPv6.inc header so that if ipv6 functions are called no surprises arise
Leave a trace that rtsold did fire the dhcp6c client so troubleshooting is easier
Do not include disabled OpenVPN in vpn_networks and negate_networks
Correctly check the secondary/primary parameter setting on dhcp failover configuration
Correct typo that prevents dhcp rules from properly being generated.
the time has come - bump to 2.1-RELEASE
Fix errant display of "0 table deleted" during filter reload on console.
Remove unecessary capitalized WARNING from disabled APC message
Test growl whether or not growl is disabled.
Do not sync DHPCv6, it must operate independetly. Ticket #3184
Remove failover peer IP settings from DHCPv6, DHCPv6 doesn't support failover the way that DHPv4 did. Fixes #3184
Disable kill_states by default on upgrade, it fixes #3183
Fix #3127
By default htmlspecialchars does not consider single quotes, what can bea problem when value attribute is set using it. Replace value attributeset to use double quotes on places where it's obviously recieving aresult of htmlspecialchars() call.
Allow for easier override on $g values if needed.
Correct check to match the right vip based on configured ip. Reported-by: http://forum.pfsense.org/index.php/topic,66234.0.html
Ticket #3181 do the state flushing only on down gateway detection rather than any time.
Revert "Revert back the behaviour to cleanup all states for 2.1 Fixes #3181 and related to Ticket #1629. This commit is only for 2.1 since on master development will continue for better alternatives"
A bit too excessive need to get right.
This reverts commit c59dd719e0a6d9ee8deecaa7bff0d6ee8c76e4ca.
Ba-bump-bump.
When the v4 wan is dynamic and v6 is type dhcp and v6 information is retrieved through v4 link than trigger dhcp6c reconfiguration.
Actually the / here is not needed.
Related to Ticket #3045 avoid races in the ntpdate_sync_one script due to killall returning without the process really exiting.
Add safety belts to code in rc.openvpn to avoid php errors to leave stale locks around
Make the operation of saving old rule nearby the writing operation to be logical to spot
Sprinkle some unsets to reduce footprint and correct some whitespaces
filter_generate_port error log function name
Absolutely minor adjustment to make the error log message refer to the new function name.
Revert back the behaviour to cleanup all states for 2.1 Fixes #3181 and related to Ticket #1629. This commit is only for 2.1 since on master development will continue for better alternatives
Fixes #3173 if any port information exists on the rule than put it on the NEGATE rule generated.
Remove SPD when disable phase2, it fixes #2719
Increased needed memory for APC to 512M + code cleanup
- Increased the needed memory for APC to 512M as we often run into memory problems on our 256M box- fixed the RAM calculation to divide by 1024 and not 1000- code cleanup (renaming variables and creating new to avoid magic numbers)
Merge pull request #796 from phil-davis/master
Traffic Shaper GUI text typos
Merge pull request #790 from shahidsheikh/RELENG_2_1
#3174 Added handling of gateway groups in openvpn_restart
Merge pull request #794 from phil-davis/RELENG_2_1
Backport get_memory changes to 2.1
Bring back static routes to fix issues reported on Ticext #3179
Fix #3004:
. Create a function to replace strings on deep associative arrays. Use the recent created function array_replace_values_recursive to fix VIP interface names instead of touch config.xml directly
Disable state killing on gateway failure by default for new configs.Clarify the text describing the option while here.
Correct typo on variable name
Fix issue reported on http://forum.pfsense.org/index.php/topic,66160.0.html
Make sure RRD data is restored from backup before upgrading data and a new backup is done after. It should fix #2159
Resolves #3177. Do a filter reconfigure if the dynds ipsec hosts are present and being reloaded.
fix text
Merge pull request #792 from razzfazz/RELENG_2_1
add option to send prefix hint for requesting desired prefix length for ...
Merge pull request #791 from jean-m-cyr/RELENG_2_1
Dummynet does not require burst size specification
Use physmem and realmem from get_memory() in the appropriate places
Backport to 2.1
Use new names for get_memory parameters
Use hw.physmem when calculating pfsense_default_state_size
hw.physmem is the actual amount of memory that FreeBSD/pfSense can get its hands on, so use this for the calculation.Backport to 2.1
touch up text, s/nat/NAT/
add option to send prefix hint for requesting desired prefix length for delegation
This change adds an option on the interfaces page for sending a prefix hint for the selected delegation size. If enabled, a "prefix" field requesting :: with the appropriate prefix length (64 - dhcp6-ia-pd-len) is added to the "id-assoc pd" entry in the dhcp6c config file. This hint is required for requesting prefixes shorter than /64 from Comcast.