pfSense

Tidy up "services_wol" XHTML

Add SUMMARY to tables
Update HTML Boolean operators
Close INPUT and IMG tags and add ALT to IMG tags
Deprecate ampersand in anchor tags
Move NOWRAP into class statement
Remove empty EM tag

Be smarter at using kenv

Remove problematic code without proper checks but even not needed here

Unload the ZFS module if its not in use to not consume uselss memory

Merge pull request #1096 from fraenki/fix_pbi_services

Merge pull request #1094 from ingenieurmt/master

support symlinked RC scripts from PBI packages

GC unused code and do not set this to 0 for now since it is not anymore relevant

Add missing closing quotes

Correct missing parenthesis. Reported-by: https://forum.pfsense.org/index.php?topic=75120.0

Key off net.inet.carp.demotion and display a warning to the user if the system has self-demoted its CARP status.

Fix text, capitalization, and change wording to put more focus on how the action behaves.

Ensure e-mail address carries over from the CA screen to the Cert screen in the OpenVPN wizard.

Merge pull request #1093 from phil-davis/patch-2

Fix susbstr-substr typo

I just got this error again on 14 Apr 2014 2.2 snapshot. I can see the fix in 2.1 branch. I could have sworn it got fixed in Master also, but I can't see it. So here is the fix for Master.

Merge pull request #1092 from phil-davis/patch-1

Fix bracket type in Log File Size text

Now I am the one with fat fingers (or brain). Somehow I typed a curly bracket opening bracket in this text, but finished it with an ordinary closing bracket.

License Agreement

Insert tracker ids for the default LAN rules

Correct the sense of the check to allow openvpn to work

Correct auth-user-pass-verify to include parameters properly so openvpn can start

Merge pull request #1091 from dv-user1/usort_fix2

Merge pull request #1085 from ExolonDX/branch_master_01

Fixup update URL

fixed a type in usort callback

Use the FreeBSD script for ldconfig to catch all libs

Merge pull request #1088 from phil-davis/patch-11

Unset logfilesize rather than let it be zero

1) When saving Status: System logs: Settings, if the Log File Size field is left blank, it gets cast to (int) and ends pu as zero "0" in config.xml. That breaks the creation of clog files in /etc/rc during boot. /etc/rc expects logfilesize to be unset, blank or a valid integer >= 5120....

Avoid warnings later on if no config for layer7 exists

Get rid of embedded platform. Its time to GC this

Start using filterlog

Switch over to filterlog sooner than later

Unset also here

Unset these globals after use

Merge pull request #1087 from phil-davis/patch-10

Merge pull request #1086 from phil-davis/patch-9

Include static routes in automatic NAT rules display

If I have an internal gateway to other private subnets behind LAN, and add a static route to those private subnets through the internal gateway, then pfSense very nicely generates NAT rules on WAN-style interfaces to NAT those internal subnets on the way out of WAN. That is very good and convenient. This outbound NAT is actually correctly in the ruleset....

Do not allow upgrade_101_to_102 to exit early

This upgrade step does both Captive Portal stuff and OpenVPN stuff. So do not return early just because there is no Captive Portal config.
Both Captive Portal and OpenVPN tests changed to be positive tests, to make sure that everything is checked/tested and there is no chance to return early.

console, reload firewall rules after enabling SSH

Merge pull request #1076 from phil-davis/patch-2

Get real interface when dhcrelay uses default GW

If the DHCP Relay server is not on any local subnet, and not on any subnet that has an internal static route, but is somewhere that no specific route is known, then this code finds the default gateway and uses that in the DHCP relay "-i" parameter. The current code gets just the interface name (like "wan", "opt1"). But DHCP Relay command needs to be fed the actual device name "vr0", "vr1" etc....

Tidy up XHTML

Update HTML Boolean operator (multiple)
Change ONCLICK to lower case
Add missing semi-colon

Merge pull request #1072 from marcelloc/patch-3

Merge pull request #1071 from ExolonDX/master

tls-verify requires quotes around the command to be executed. Ticket #3596

use email from CA creation also as the default for server cert

There is no need to make distinction in kernel anymore since they are the same nowdays and it does the right thing(tm) most of the time

Nowdays there is no real difference between the kernels apart the ZFS support. So do not keep a distinction anymore

fixing typo for GIF tunnels to work over IPv6

the call of get_interface_gatewayv6() in the creation of a GIF tunnel over IPv6 leads to a "Fatal error: Call to undefined function get_interface_gatewayv6() in /etc/inc/interfaces.inc on line 934". changeing the function call to get_interface_gateway_v6() fixed it for me on my local system.

Also add similar checks on rc.newwanipv6 as in the v4 version

Forgot to remove the problematic part from previous OpenVPN loop fix commit

Tidy up package signature text

Thought I would tidy this up while coming across it. IMHO "Package settings" reads better than "Packages settings"... and I reworded the explanatory text a bit also.

Take care of the loops reported for OpenVPN in tap mode. Also fixes the problems of tap disappearing from bridge if its a member.

tls-verify requires quotes around the command to be executed. Ticket #3596

use email from CA creation also as the default for server cert

Add curly brackets here to improve readability

unset doesn't like @ to silent it, just check if it's set before unset

fix git path calls and CODIR

it may need some checks/fixes on pkg-utils.inc as git downloads but not installs.

After manual pbi install of git, "pfSsh.php playback gitsync master" works fine with this fix.

Use an alphanumeric test rather than purely is_numericint because the ID is generated by uniqid and is not purely numeric. Fixes #3591

Restore old logic and add a @ at unset to silent when it is not set as suggested by Ermal

Tidy up "guiconfig.inc" XHTML

Add missing closing SELECT tag

Merge pull request #1068 from FCI/patch-1

Check if the ipsec section exists before doing operations on it.

Correct typo on function name that has slipped unnoticed. Reported-by: https://forum.pfsense.org/index.php?topic=74688.0

fixes Bug #3569

On packages that uses row_helper when user clicks on add or delete button, the page scrolls to top.
It seems something with ajax
http://stackoverflow.com/questions/1061580/jquery-click-on-anchor-element-forces-scroll-to-top

A simple return false after jquery action fixes the unwanted scroll.

Merge pull request #1055 from ExolonDX/branch_master_10

Make extra sure that we do not start multiple instances of dhcpleases if, for example, the PID is stale/invalid and there is still a running instance.

Merge pull request #1056 from ExolonDX/branch_master_12

Merge pull request #1057 from ExolonDX/branch_master_13

Merge pull request #1058 from ExolonDX/branch_master_14

Merge pull request #1059 from ExolonDX/branch_master_15

Merge pull request #1060 from ExolonDX/branch_master_16

Merge pull request #1061 from ExolonDX/branch_master_17

Merge pull request #1062 from ExolonDX/branch_master_18

Merge pull request #1063 from ExolonDX/branch_master_19

Merge pull request #1065 from ExolonDX/branch_master_22

Put the fix to be more generic to prevent any other leak possible in the long run. Fixes #3062

Update captiveportal.inc

Release unused pipeno when client is already authenticated.

Bug #3062

Indentation

Indentation

Dont check for 'checked' but rather if it is just set

Ensure variable is available when testing smtp. Fixes #3577 (well not the rrd summary package).

Update system_advanced_misc.php

Added check line 175: Needed to fix error in GUI

Added check to see if $config['ipsec']["ipsec_{$lkey}"] is set before executing unnecessary unset, was causing issues when trying to enable/disable ("Do NOT check packages signature")

Tidy up "services_unbound_advanced.php" XHTML

Add "closehead" variable and manually close HEAD
Add CDATA sections to scripts
Add SUMMARY to tables
Update HTML Boolean operators
Close INPUR

Tidy up "services_unbound_acls.php" XHTML

Add "cloeahead" variable and manually close HEAD
Add CDATA sections to scripts
Close INPUT
Add SUMMARY to tables
Update HTML Boolean operators
Close IMG and add ALT
Remove empty TFOOT tag
Move TFOOT tag between THEAD and TBODY (quirk of HTML)...

Tidy up "services_unbound" XHTML

Add "cloeahead" variable and manually close HEAD
Add CDATA sections to scripts
Add SUMMARY to tables
Update HTML Boolean operators
Close INPUT
Remove duplicate closing TD tag
Move TFOOT tag between THEAD and TBODY (quirk of HTML)...

Tidy up "services_dnsmasq" XHTML

Add "closehead" variable and manually close HEAD
Add CDATA sections to scripts
Add SUMMARY to tables
Update HTML Boolean operators
Close INPUT
Move TFOOT between THEAD and TBODY (quirk of HTML)
Move NOWRAP into class statement...

Tidy up "services_router_advertisements" XHTML

Add CDATA sections to script
Add SUMMARY to table
Update HTML Boolean operators
Add dummy table row, but don't display it
Close INPUT

Tidy up "services_dhcpv6" XHTML

Update alert message
Add "closehead" variable and manually close HEAD
Add CDATA sections to script
Add SUMMARY to tables
Update HTML Boolean operators
Close INPUT
Add missing closing P tag
Remove empty TFOOT tag
Deprecate ampersand

Tidy up "services_dhcpv6_realy.php" XHTML

Add "closehead" variable and manually close HEAD
Add CDATA sections to scripts
Add summary to tables
Add missing closing FORM if DHCPV6 is running
Update HTML Boolean operators
Close INPUT

Tidy up "services_dhcp" XHTML

Update alert message
Add "closehead" variable and manually close HEAD
Add CDATA sections to scripts
Add summart to tables
Update HTML Boolean operators
Close INPUT
Add missing closing P tag
Remove empty TFOOT
Add missing opening TR tag, closing TD tag and closing P tag...

Tidy up "services_dhcp_relay.php" XHTML

Add "closehead" variable and close HEAD manually
Add CDATA sections to scripts
Add summary to TABLES
Add missing closing FORM if DHCP is enabled
Update HTML Boolean operators
Close INPUT

Tidy up "functions.inc"

Escape single quotes for TABLE and HREF
Updated closing TR tag

Fix variable name, it's not necessary to check since it is always set at ipsec.inc

Merge pull request #1052 from ExolonDX/branch_master_09

Branch master 09

Merge pull request #1051 from ExolonDX/branch_master_08

Tidy up "services_captiveportal_filemanager" XHTM

Merge pull request #1050 from ExolonDX/branch_master_07

Tidy up "services_captiveportal_vouchers" XHTML

Merge pull request #1049 from ExolonDX/branch_master_05

Tidy up "services_captiveportal_ip.php" XHTML

Merge pull request #1048 from ExolonDX/branch_master_04

Tidy up "services_captiveportal_mac.php" XHTML