Bug #11425
closed
XMLRPC error with Captive Portal and CARP failover when GUI is on non-standard port
Added by Luca De Andreis almost 4 years ago.
Updated over 3 years ago.
Description
.... after countless attempts and two tickets that you closed for me, I found the cause of the problem.
The tcp port of the webgui.
If I use the default it works correctly, if I use an alternative port (for example 8443) this warning appears.
- Subject changed from Alert: XMLRPC method captive_portal_sync FOUND the cause of the problem to XMLRPC error with Captive Portal and CARP failover when GUI is on non-standard port
- Assignee set to Jim Pingle
- Target version set to CE-Next
Previous issues: #11218, #11220
Though you still did not provide enough information here, I managed to piece together enough from your rejected issues to figure out what you were talking about. In the future, you must include all details in the current issue.
With the information that the port was the problem I was able to spot a bug in the code which seems to be the culprit. The small change below should fix it for you.
index 1d84efd223..65b48e0e77 100755
--- a/src/etc/rc.carpmaster
+++ b/src/etc/rc.carpmaster
@@ -130,7 +130,7 @@ if (!empty($config['captiveportal']) && is_array($config['hasync']) && !empty($c
$xmlrpc_username = $config['hasync']['username'];
}
$xmlrpc_port = $config['system']['webgui']['port'];
- if (empty($port)) {
+ if (empty($xmlrpc_port)) {
if ($config['system']['webgui']['protocol'] == "http") {
$xmlrpc_port = "80";
} else {
It's too late to fix this for 2.5.0, but the next patch release we put out can include it.
Luca De Andreis wrote:
.... after countless attempts and two tickets that you closed for me, I found the cause of the problem.
The tcp port of the webgui.
If I use the default it works correctly, if I use an alternative port (for example 8443) this warning appears.
Jim Pingle wrote:
Previous issues: #11218, #11220
Though you still did not provide enough information here, I managed to piece together enough from your rejected issues to figure out what you were talking about. In the future, you must include all details in the current issue.
With the information that the port was the problem I was able to spot a bug in the code which seems to be the culprit. The small change below should fix it for you.
[...]
It's too late to fix this for 2.5.0, but the next patch release we put out can include it.
Yes ! Now works without alert on an alternative GUI port.
Thanks !
- Status changed from New to Feedback
- % Done changed from 0 to 100
- Status changed from Feedback to In Progress
Needs picked back after the release is tagged.
- Status changed from In Progress to Waiting on Merge
- Status changed from Waiting on Merge to Feedback
- Target version changed from CE-Next to 2.5.1
- Status changed from Feedback to Resolved
Tested in
2.5.1-RC (amd64)
built on Thu Mar 18 03:04:03 EDT 2021
FreeBSD 12.2-STABLE
It's fixed. The XMLRPC errors are no longer generated with GUI on alternative port. Marking the ticket resolved.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by