Feature #13377
closed
Option to configure a custom value for the PHP memory limit
Added by Christopher Cope over 2 years ago.
Updated 12 months ago.
Estimated time:
(Total: 0.00 h)
Plus Target Version:
23.09
Description
There are several cases where the default memory limit used for PHP is being hit and where the system has plenty of extra RAM. In these cases, it would make sense to be able to adjust the limit as needed.
For instance, with an extremely large status_output, a large number of nested aliases, etc.
Files
|
0001-Add-a-setting-for-PHP-memory-limit-in-System-Advance.patch (3.24 KB)
0001-Add-a-setting-for-PHP-memory-limit-in-System-Advance.patch |
|
Christopher Cope, 07/28/2022 02:58 PM
|
|
|
clipboard-202207290952-dkowf.png (6.44 KB)
clipboard-202207290952-dkowf.png |
|
Lev Prokofev, 07/29/2022 01:52 AM
|
|
|
clipboard-202207290955-aiguw.png (3.93 KB)
clipboard-202207290955-aiguw.png |
|
Lev Prokofev, 07/29/2022 01:55 AM
|
|
|
clipboard-202207290956-o6kwf.png (2.46 KB)
clipboard-202207290956-o6kwf.png |
|
Lev Prokofev, 07/29/2022 01:56 AM
|
|
|
Screenshot 2023-08-04 093223.jpg (86 KB)
Screenshot 2023-08-04 093223.jpg |
512 |
Jonathan Lee, 08/04/2023 04:33 PM
|
|
|
clipboard-202308041104-h728p.png (127 KB)
clipboard-202308041104-h728p.png |
|
Jonathan Lee, 08/04/2023 06:04 PM
|
|
|
Screenshot from 2023-08-26 18-16-52.png (14.6 KB)
Screenshot from 2023-08-26 18-16-52.png |
|
Chris W, 08/27/2023 12:52 AM
|
|
|
clipboard-202309180840-vuqwy.png (14.9 KB)
clipboard-202309180840-vuqwy.png |
|
Jim Pingle, 09/18/2023 12:40 PM
|
|
|
clipboard-202311041720-hhol7.png (13.1 KB)
clipboard-202311041720-hhol7.png |
|
Jordan G, 11/04/2023 10:20 PM
|
|
|
clipboard-202311051030-9wftt.png (12.9 KB)
clipboard-202311051030-9wftt.png |
|
aleksei prokofiev, 11/05/2023 07:30 AM
|
|
|
clipboard-202311051036-vllrp.png (13 KB)
clipboard-202311051036-vllrp.png |
|
aleksei prokofiev, 11/05/2023 07:36 AM
|
|
|
clipboard-202311051046-vcslm.png (12.7 KB)
clipboard-202311051046-vcslm.png |
|
aleksei prokofiev, 11/05/2023 07:46 AM
|
|
Seems no changes,
Set 256M
Reboot,
checked with
echo ini_get("memory_limit");
The change only applies to the PHP used directly by pfSense, as they are set with config.inc.
For testing you can use
<?php
require_once("/etc/inc/config.inc");
echo ini_get("memory_limit");
?>
That inc will be loaded automatically inside pfSense. Also there is no need for a reboot for it to take effect.
Got it and checked, working as expected.
- Subject changed from Allow adjusting the PHP memory_limit in System -> Advanced to Option to configure a custom value for the PHP memory limit
- Target version set to 2.7.0
- Plus Target Version set to 22.11
- Plus Target Version changed from 22.11 to 23.01
- Plus Target Version changed from 23.01 to 23.05
- Plus Target Version changed from 23.05 to 23.09
- Target version changed from 2.7.0 to CE-Next
Could this also be adapted to use a disk swap? That way it could have an option to use and allocate fixed disk storage if needed or required. Kind of Like a reverse MS-DOS ramdisk if you are old enough to remember using this within MS-DOS 5 I think it was.
is the Path Strip Count 2 for the patch?
I added your patch set this to 512mb and I am still getting that snort error for active rules
Crash report begins. Anonymous machine information:
arm64
14.0-CURRENT
FreeBSD 14.0-CURRENT #1 plus-RELENG_23_05_1-n256108-459fc493a87: Wed Jun 28 04:25:15 UTC 2023 root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/obj/aarch64/0P4W6joa/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/source
Crash report details:
PHP Errors:
[04-Aug-2023 09:30:42 US/Pacific] PHP Fatal error: str_ireplace(): Cannot use output buffering in output buffering display handlers in /usr/local/www/csrf/csrf-magic.php on line 161
No FreeBSD crash data found.
Jonathan Lee wrote in #note-12:
I added your patch set this to 512mb and I am still getting that snort error for active rules
Crash report begins. Anonymous machine information:
arm64
14.0-CURRENT
FreeBSD 14.0-CURRENT #1 plus-RELENG_23_05_1-n256108-459fc493a87: Wed Jun 28 04:25:15 UTC 2023 root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/obj/aarch64/0P4W6joa/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/source
Crash report details:
PHP Errors:
[04-Aug-2023 09:30:42 US/Pacific] PHP Fatal error: str_ireplace(): Cannot use output buffering in output buffering display handlers in /usr/local/www/csrf/csrf-magic.php on line 161
No FreeBSD crash data found.
That error doesn't seem to be related to memory issues, so this patch wouldn't affect it.
Jonathan Lee wrote in #note-10:
Could this also be adapted to use a disk swap? That way it could have an option to use and allocate fixed disk storage if needed or required. Kind of Like a reverse MS-DOS ramdisk if you are old enough to remember using this within MS-DOS 5 I think it was.
Right now, this just adds a GUI interface for the existing PHP memory limit settings. In almost all cases, the default values are sufficient.
I don't see there being much of a need to allocate disk space as well, but you could theoretically create a swap partition and increase this value to the point that it would start using that. That's definitely not tested nor recommended, though.
Thanks for the reply,
just to confirm the is the Path Strip Count 2 for your patch?
Jonathan Lee wrote in #note-15:
Thanks for the reply,
just to confirm the is the Path Strip Count 2 for your patch?
That should be correct. Some updates are being made to the code still, so that's delaying the merge. That original patch is still functional, though.
- Status changed from Pull Request Review to Feedback
- Target version changed from CE-Next to 2.8.0
Tested on
23.09-DEVELOPMENT (amd64)
built on Sat Aug 26 17:37:15 UTC 2023
FreeBSD 14.0-ALPHA2
It's merged in and functioning as expected. I'll wait for others to test as well, since I made the changes.
Systems with 1GB or less of RAM show a negative number as the hinted maximum adjusted value. The screenshot is taken from a virtual machine with 512 MB RAM (and with 1GB, the value becomes 128 to -62).
Chris W wrote in #note-19:
Systems with 1GB or less of RAM show a negative number as the hinted maximum adjusted value. The screenshot is taken from a virtual machine with 512 MB RAM (and with 1GB, the value becomes 128 to -62).
Thanks for catching that. I have submitted a merge request to handle those cases more elegantly.
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1065
Should allow the user to fill in the PHP memory according to the total memory capacity of the server
still seeing a negative number suggested for the higher limit on system with <1gb RAM running 23.09-DEVELOPMENT-amd64-20230909-1856
Jordan G wrote in #note-22:
still seeing a negative number suggested for the higher limit on system with <1gb RAM running 23.09-DEVELOPMENT-amd64-20230909-1856
The new patches weren't merged in yet, should be in the next build.
New patches just merged.
It's better but still quirky.
On a VM with 1GB RAM it says the default is 512 but the allowed range is 128 to 449, so there isn't a way to set the manual value as high as the default.
- Status changed from New to In Progress
- Assignee changed from Christopher Cope to Jim Pingle
- Status changed from In Progress to Feedback
23.09 on 6100, this looks better for default and range
- Status changed from Feedback to Resolved
- Target version changed from 2.8.0 to 2.7.1
What is recommended for SG-2100MAX with 23.05.01 in use I can't remember I was using 128 I think but you guys are showing 512 now half a gb?
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
