pfSense

any clue when a patch for 22.05 will be available ?

Potential fix in https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/936

For reference the thread this was discussed and diagnosed in is here:
https://forum.netgate.com/topic/174489/22-05-cp-clients-have-connectivity-issues-after-x-amount-of-time

A fix was suggested and tested here:
https://forum.netgate.com/post/1068518

The changes in https://redmine.pfsense.org/projects/pfsense/repository/1/revisions/32661caf9549d8675763e814c9ceb9c2b47b2f02 which added the $check_only flag appear to have intended to prevent the check for available pipes from actually allocating them before user auth had completed, but the $pipeno returned from that call is still being passed to portal_allow(). The failed authentication case also still calls captiveportal_free_dn_ruleno(). I think the correct course of action here is to pass NULL for $pipe to portal_allow() and remove the call to captiveportal_free_dn_ruleno() in the failed auth case. In this way, a login attempt creates no pipes until after the user is authenticated, which I believe is the intention from the original changeset.

Steve Wheeler wrote in #note-4:

For reference the thread this was discussed and diagnosed in is here:
https://forum.netgate.com/topic/174489/22-05-cp-clients-have-connectivity-issues-after-x-amount-of-time

A fix was suggested and tested here:
https://forum.netgate.com/post/1068518

The proposed fix there is essentially the same as my first attempt at a fix. It handles most cases and would certainly improve users' experience, but it's not fully correct. Reid figured out what the original patch was trying to do, and has suggested a better fix, which is what's now in the merge request.

Looks like pipes per user fixed. Users using their own pipe.

Tested

23.01-DEVELOPMENT (amd64)
built on Fri Dec 02 06:04:48 UTC 2022
FreeBSD 14.0-CURRENT

3 users speeds 3Mbit Download 10Mbit Upload

02002: 10.280 Mbit/s 0 ms burst 0
q133074 100 sl. 0 flows (1 buckets) sched 67538 weight 0 lmax 0 pri 0 droptail
sched 67538 type FIFO flags 0x0 16 buckets 0 active
02003: 3.072 Mbit/s 0 ms burst 0
q133075 100 sl. 0 flows (1 buckets) sched 67539 weight 0 lmax 0 pri 0 droptail
sched 67539 type FIFO flags 0x0 16 buckets 0 active
02000: 10.280 Mbit/s 0 ms burst 0
q133072 100 sl. 0 flows (1 buckets) sched 67536 weight 0 lmax 0 pri 0 droptail
sched 67536 type FIFO flags 0x0 16 buckets 1 active
BKT Prot ___Source IP/port____ ____Dest. IP/port____ Tot_pkt/bytes Pkt/Byte Drp
0 ip 0.0.0.0/0 0.0.0.0/0 3 351 0 0 0
02001: 3.072 Mbit/s 0 ms burst 0
q133073 100 sl. 0 flows (1 buckets) sched 67537 weight 0 lmax 0 pri 0 droptail
sched 67537 type FIFO flags 0x0 16 buckets 0 active
02004: 10.280 Mbit/s 0 ms burst 0
q133076 100 sl. 0 flows (1 buckets) sched 67540 weight 0 lmax 0 pri 0 droptail
sched 67540 type FIFO flags 0x0 16 buckets 1 active
0 ip 0.0.0.0/0 0.0.0.0/0 20 1846 0 0 0
02005: 3.072 Mbit/s 0 ms burst 0
q133077 100 sl. 0 flows (1 buckets) sched 67541 weight 0 lmax 0 pri 0 droptail
sched 67541 type FIFO flags 0x0 16 buckets 1 active
0 ip 0.0.0.0/0 0.0.0.0/0 14417 19261353 76 99069 3365