pfSense

Store upgraded monitor IPs in gateway items, not accidentally as bogus interfaces. This was causing some configs to upgrade and then get stuck in a reassignment loop after the next reboot.

Make the RRD path if it doesn't yet exist at this point.

Remove hw.bce.tso_enable item it is loader.conf only per jimp

Some fixes for the upgrade code for captive portal users.

Remove the old field even if empty in rename_field.

Remove trailing carriage return

Do some is_array() testing before renaming fields, otherwise empty variables can be accidentally created.

Mark this entry as an array before treating it as such otherwise php complains.

Check to see if it is not an array first - as per jim-p on IRC.

Fix crl upgrade code.

Add upgrade code for importing CRLs. Ticket #555

Rename 'name' to 'descr' for CA, Certificates, and CRLs, to gain CDATA protection and standardize field names. Ticket #320.

Generalize this function and use it in more places to reduce duplicated code.

Convert fullname field on users to descr, so it gains CDATA protection.

desc to descr in Load Balancer config, so they gain CDATA protection and standardize field names. Ticket #320.

Change the description field on sysctl tunables to be 'descr' and not 'desc' so they will gain CDATA protection. Ticket #320

Use proper matching because the command might contain nice in it.

Do not run anymore the cron job for monitoring check_reload_status since it has a monitoring process that does this through kqueue.

We want to upgrade all of interfaces/gateways.

Better initialize this.

Add upgrade code for NAT 1:1 rules and bump config version.

Base64 encode passowrd fields for safer operations. Suggested-by: Efonne(IRC)

Upgrade user data too for new pppoe world.

Correct function name. Pointy-hat: jimp@

Upgrade code to merge user certificates with normal certificates.

Upgrade code for pppoe.

Moving certs and ca out from under system. Provide upgrade code to move existing certs.

Ticket #482. This solves point 3) which converts the custom 'local IP' directive to the 2.0 format.

Ticket #769. Convert assigned openvpn interfaces by using custom options to 2.0 style assigned openvpn interfaces. This upgrade removes the 'dev tun#' from cutom options and upgrades the assigned interface name to new style.

Make dhcrelay GUI be simple and easy to use by collapsing the interface tabs to a multiselect control. Remove proxydhcp option because it is broken and is not trivial to make it usable(if user request for it a reconsideration will be made). Allow multiple server ips on the server input box separated by commas. Also on the interface list do not show interfaces without an ip because dhcrelay will not be happy with them. Upgrade code is also included in this commit.

Disable TSO and LRO in upgraded configs.

Do not use a monitor address from a load balancer pool as the monitor IP for a connection. This can lead to incorrect configurations. Some 1.2
configurations use load balancer pools as a subtitute for a gateway since that option was not available then.

Invert the is_array() check as this incorrectly unsets the gateway array leaving the system unreachable

Follow the restored username as the logged in user when upgrading a config. Otherwise you can get access errors if you need to do an interface reassignment.

Only output these messages when booting.

Change this find to a chdir/glob.

Fix the RFC dns updates config upgrade. It would blow up on an incomplete/invalid config.

Fixes #480. Correctly upgrade config for monitorip. When a gateway exists save there the monitorip instead of the interface.

Include rrd.inc if dump_rrd_to_xml() is not found to be included to avoid Fatal error: Call to undefined function dump_rrd_to_xml() in /etc/inc/upgrade_config.inc on line 1752

Fix up upgrade function for new PPPs implementation.

Fix up for new ptpid scheme and iface name scheme.

Fix all issues that Ermal found.

Interfaces.php problems.
1- When creating a pppoe ptpid on the config is empty(<<ptpid/>).
2- after switching from pppoe to pptp in the config there remains
pppoe-reset-type which is not that much of a bug but needs to be...

Merge branch 'master' of http://gitweb.pfsense.org/pfsense/mainline into mlppp

Do not set max_execution time here.

Fix upgrade code for disable bit on OpenVPN CSC entries.

Update upgrade_config to remove 'defaultgw' from <ppp> config sections

Fix many things related to PPP connections.

Fixed tab array numbering in interfaces_* files. Enabled multilink over PPtP connections.
Fixed handling of bandwidth, mtu, mru settings. Removed unnecessary curly brackets from
single line if conditionals, and more . . .

PPPoE config upgrade code and bump config version in globals.inc

Fix OpenVPN upgrade code to properly handle the disable option. Fixes item 1a (and probably 1b) in #482 and should be the rest of the fix for #449.

Move RRD quality databases to reflect the gateway name instead of the interface name. This should prevent a flurry of duplicate but
unused RRD files on 2.0 where we use the gateway names for the RRD file. Fix ticket #354

Prevent empry dyndns array items on config upgrade ticket #491

Unbreak the switch statement, pointy hat to me

Correct the function name so that it upgrades properly

Make sure to upgrade deprecated themes to pfsense_ng.
The switch() should make it easy to add other deprecated themes here.

Do not put ip address on teh name since pfctl does not like an ip as part of macro name.

Ticket #408. Provide code to upgrade static routes.

Fix upgrade code for port forwards with "Interface address" set on external address. Ticket #561

Fix the empty array check, a empty load balancer tag has a value of 1, not 0.

Do not trip with configuration upgrades on a empty load balancer tag.

Ticket #491. Fix upgrade code. Since dyndns is considered and array item it failed with previous code. Use index of 0 since 1.2.x does not have multiple entries.

Add upgrade code for values of "Interface address" and "any" for the external address of port forwards. Ticket #561

Improve NAT Port Forwarding

• Now you can disable a rule
• You can define "no rdr" rules
• Source type, address and port, with an option "not" for exceptions
• Destination type, address and port, with an option "not" for exceptions...

Fix OpenVPN upgrade code for lzo compression. Resolves #280, mentioned also in Ticket #482.

Fix apparent typo in IPsec upgrade code which broke the user_fqdn identity type.

Ticket #486. Convert even the gateways that specify the interface itself.

Make lan/wan behave as all other interfaces.

Ticket #324. Add allow all rule during upgrade.

Ticket #280. Seems that xml parser does not set the value correctly.

Reorder a few lines so we do not step on the interface variable. This was the cause of accidentaly adding gateway name entries in the
$config['interfaces'] xml

Fix variable name, this tagged all gateways as dynamic on upgrades.

Unbreak remote-ip box. Mpd is now starting for ppptp server

Partial rewrite of gateway code, now partially facilitates dynamic interfaces
- Upgrade code takes different naming into account
- Add gateway entries for dynamic interfaces
- Rewrite status array to also support dynamic interfaces.
- Always use unique localhost monitor IP addresses for down dynamic interfaces...

Make sure we test for the right gateway name in the upgrade code.

Attempt to work around both static configs and dynamic configs on load balancer upgrades. Needs testing on
live installs 1.2 => 2.0.

Add a FIXME note to the upgrade part.

Make sure that the upgraded load balancer configuration reflects the new gateway names

Make sure that we mark the wan interface as the default gateway on upgrades

Replace the previous itteration with this version 2 attempt.
The interface gateways array previously contained no interface name that could be used.
Succesfully upgraded 1 configuration. Needs more testing to catch other edge cases.

Replace gateways configuration upgrade code with 1st attempt to fix.
Revert the lbpool descriptopn variable name. It was correct before.

Make sure that when upgrading the load balancer pools to the gateway format we set the description as well. Typo in the
variable name

Make sure that when upgrading a balance pool that we always user tier 1, it previously used tier 0 which equals "Do not use".

Fix the VLAN upgrade code so that it correctly renames the vlan entries and updates the interfaces
config section to the new name. Tested with 2 VLANS.

Make sure we do not place the temporary files in / but in /tmp

s/loadbalancer/load_balancer/

Add back chopped off and. Output updating configuration after rrd upgrade to make upgrade text look uniform.

oops, revert this. there is code already. focus on making it work for this config instead

Upgrade outgoing load balancing to gateway groups. Ticket #78

Do not rely on PHP5 features which are not widely used in pfSense.

upgrade sysctls to value default. Ticket #71

Extra protection to prevent empty load_balancer arrays on configuration upgrades

Add pfSense_BUILDER_BINARIES: and pfSense_MODULE: additions

add missing sysctl to config upgrade

Make the config upgrade sysctls match the correct values in the default config.xml.

Include certs.inc

Make style consistent

Oops, part of the git merge sneaked in here. Remove

Merge branch 'master' of git://rcs.pfsense.org/pfsense/nigel-ca-chain into review/master

Conflicts:
etc/inc/certs.inc
etc/inc/upgrade_config.inc

Minor header changes

Remove openvpn.inc from functions.inc since its just a subsystem that does not need to be present on all of the includes.

s/./_/ for vlans since netgraph does not like .(dots) in the path names.