pfSense

Conditionally indent the action icon so it doesn't look so out of place in the wider column resulting to accommodate the sort button/icon.

The rule entires still need to wrap.

Status - System Logs - Firewall - Sort Header

Fix header to not wrap the sort button/icon to the next row.
Add sort capability to the "raw" table.

Merge pull request #2226 from NOYB/HTML_Compliance_-_Status_-_System_Logs_-_VPN

Moved global defines to globals.inc

HTML Compliance - Status - System Logs - VPN

Permitted content of p tag is phrasing content.
Form is not a member of phrasing content.

Add gettext() calls to title elements

Correct <th> widths

Remove duplicate defines

Fix vertical alignment of fa icons within buttons

Parse package title, splitting into an array delineated by '/'.
So if the package title is "Services/Magic" the $pgtitle will be array("Services", "Magic") and the breadcrumb display will be as expected.

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2161 from heper/patch-1

Move function to fix none existent call.

Status - System Logs - Firewall - Manage Log

Use the same methods of obtaining log file etc. and mimic much of the code that is common with status_logs.php.
(future: factor out common code into shared functions to remove duplication.)

position confirm button better

Merge pull request #2224 from phil-davis/r005

Coe style firewall *

Text with max-src-conn-rate and max-src-conn-rates fields

I fixed up the text to read the best I could think of.
Actually in 2.2.* these 2 fields were horizontally across the page - so maybe someone can reformat this to look more like on 2.2.* ?

Merge pull request #2218 from NOYB/HTML_Compliance_-_Dashboard

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

Remove debug

Merge pull request #2215 from NOYB/HTML_Compliance_-_Form_Action_Attribute

Fixed #5638

Merge pull request #2222 from phil-davis/patch-3

Fix array key typo in firewall_nat_1to1_edit

This just looks wrong.

Remove duplicated code in firewall_aliases_edit

This hidden Form_Input is duplicated and I don't see why. The system seems to work OK with the duplication and without.

Merge pull request #2220 from phil-davis/r004

Fixed #5637

Revise child icon

Add fa icon to show override is a child

Code style usr local www a-e

Comment fix

Fixed #5638

Set language early on a common place included everywhere. This fix some tar warnings 'Failed to set locale'

Fix remaining copy/paste message from last commit

Add icon on retrieving gw widget

fix traffic shaper tree font color

HTML Compliance - Dashboard

HTML compliance (aside from the active widgets).

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

Merge pull request #2214 from BBcan177/patch-3

Merge pull request #2209 from NOYB/Status-System_Logs-Sortable_Table

Merge pull request #2208 from ExolonDX/branch_01

HTML Compliance - Collapsible Form Section HREF

Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.

<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20....

HTML Compliance - Checkbox Display As Radio Unique ID

Ensure checkbox display as raido has unique id.
Allow an id to be passed in displayAsRadio() as argument⁰.
If no argument is passed, construct id as name_value:uniqid.

Previous behavior was id = name. So all the radio buttons of the set had same id.

HTML Compliance - Form Action Attribute

Fix Empty Form Action Attribute Violation

An empty form action attribute is an HTML4 and HTML5 specification violation.

http://www.w3.org/TR/html5/forms.html#attr-fs-action
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."...

be more concise

clean up webGUI feature help text

remove icon- color classes

Mod to Services Status Widget

remove icon colors and add text colors

Fixed #5620 change css classes from icon- to text-

Put newest at top/bottom text with Forward/Reverse Display radio buttons for better clarity and more concise section description.

Correct tbody end tag.

Logs filename changes

Status - System Logs - Sortable Table

Rename of files to better match their position in the memory structure

Don't allow log specific setting to override grepreverse option.

Add few comments for clarity

Include table header titles in raw mode (time and message).
In raw mode give all horizontal space not being consumed by the time field to the message filed. Provides more space so fewer entires to consume multiple vertical line space....

Spelling Correction

s/formated/formatted/
Thanks Phil

Status - System Logs - Manage Log

Build up th manage log section with options to override the "General Logging Options" settings on an individual log basis.
Remove over exuberant gettext's.
Set/adjust filter form field widths to be better fitting for the field types....

Tidy up "status_queues.php"

Remove duplicate BODY
Tidy up BR tag correctly
Add COLPSAN statement to "interface" row
Wrap BGCOLOR in a STYLE statement (should really be defined as a CLASS
statement)
Remove FONT tag
Remove NAME statement in DIV tag
Use double quotes for consistency

Gateway advanced parameter validation

This does what I can think of so far:
1) Make sure low latency < high latency, low loss < high loss
2) Loss interval must be at least latencyhigh otherwise every packet that was high latency would be counted as lost before it came back. (see note below)...

Merge pull request #2201 from phil-davis/patch-10

dpinger help text

The packet loss thresholds must still be in % ? milliseconds does not look valid.
Other things are minor formatting.

apinger loss_interval array key name

Ticket #5624: Welcome dpinger!

Fix indent

Simplify logic and break some long lines, no functional changes

Remove calculated options

Change apinger_default to dpinger_default

Fixed #5602 by dynamically updating hte help text based on the cert selected.

Fixed #5617
Fixed #5612

Use the _title var to make the widget title

Each widget has an include file that already has the required widget
title in a var like $dyn_dns_status_title $carp_status_title etc.
Use that var to set the displayed title of the widget, rather than the
stuff that was capitalizing the file name and then having a list of...

fix input color

Merge pull request #2190 from phil-davis/r1

Merge pull request #2189 from phil-davis/patch-3

Merge pull request #2188 from phil-davis/log-breadcrumbs

Interface Stats Widget make rows standard size

The rows of data were taller than expected, and the name "Packets In", "Packets Out" etc. in the left column did not line up exactly horizontally with the numbers in the other columns. Seems to be because the "name" column was a "th" tag. If it is just "td" like the numbers then everything lines up and the row height is less (it then looks the same as other widgets that have this style of table)....

Widgets format and white space

OpenVPN Widget fix column header text

Standardize Firewall Logs breadcrumbs

fix widget header links

change alert colors to match palette

Added status page links to widget titles

Fix field description/name display of select_source package fields.

Fixed #5540

Create the required number of rows for NTP time servers

depending on how many are already defined in the config, making sure to always have a minimum of 1.

Also I used the constant NUMTIMESERVERS that was defined up the top of this file to control the loop that limits the number saved to 10....

Fix css path

Fixed #5610 by adding leading / to path

fix top nav colors

change colors to match pallete

Refine cloning of elements with autocomplete set

Fixed #5593
The jQuery required to fix this is tricky, but I believe this fixes the issue by re-adding the autoselect data to newly cloned groups.

Merge pull request #2181 from phil-davis/status-breadcrumbs

Merge pull request #2180 from phil-davis/OpenVPN

Standardize Status breadcrumbs

Merge pull request #2179 from phil-davis/IPsec

Merge pull request #2178 from phil-davis/services-ntp

Merge pull request #2177 from phil-davis/patch-3