pfSense

Standardize NAT NPt

Give NAT NPt GUI the same sort of interface as NAT 1:1
1) Checkbox to select multiple mappings and then delete selected
mappings
2) Tick/cross to enable/disable a mapping
3) Ability to "Add a new mapping based on this one"
4) Double-click to edit an entry...

Clarify input validation output. Ticket #5778

classes/Form/Textarea.class.php, setNoWrap, make it work properly on FireFox and Chromium

Include the zone in link for display of login page so it shows up correctly.

Added separator delete icon

Prototype #5373

add missing space between words

Merge pull request #2467 from NewEraCracker/widget-tunes

Changed var name sine label is an HTML reserved name.

Fixed #5779
Save/restore group label on delete row

Merge pull request #2469 from phil-davis/gt4

Internationalize firewall aliases and NAT

Merge pull request #2466 from phil-davis/patch-5

Merge pull request #2468 from phil-davis/patch-6

Merge pull request #2464 from phil-davis/patch-3

Add "GoTo line #" control

firewall_nat_1to1 fix save button text

There was no text appearing when hovering over the Save button, and Save did not actually save the changed rule order.
Make the code the same sort of stuff as in firewall_nat and it works.

firewall_nat_1to1 config descr and delete button

1) The description written when the config was saved said "Outbound" but should be "1 to 1". gettext() it while here.
2) The Delete button had no text displayed when hovering over it - make it like in firewall_nat.

Use current interface description for breadcrumb

If you enter invalid stuff in the interface description - e.g. "123" - and press save, then you get a warning about it, but the breadcrumb changes to "Interfaces: 123" - the wrongly entered description (that was not applied)....

Small tunning to all aspects involving widgets

1) Perform exclusion of non .inc files while reading directory. 2) Be more strict when checking for widget title. 3) We are in the PHP 5.5 age. We can convert certain pieces to anonymous functions and overall better coding.

Fix #5778 do not save changes if interface description matches an alias name

See https://redmine.pfsense.org/issues/5778 for details of how to reproduce the problem.

Note that similar code to make the "Sorry, an alias with the name XXX already exists" message is also at the top of interfaces.inc - it compares the current interface descr from the config with the currently existing alias names. That check would help warn the user if someone managed to add an alias name that matched the interface name. I guess it was there from some time in the past when the alias edit code did not cross-validate the alias name with the interface descriptions. I have left that check there - it does no harm to have it "just in case"....

Improved widget sorting (case insensitive)

Remove tab embedded in text - firewall_aliases_edit

Internationalize firewall_aliases_edit

1) Wrap all the various arrays of text that are displayed to the user in gettext()
2) Give the possibility to translate the singular of words like "host", "network" that get substituted into message strings.
3) Where there are multiple %s in an sprintf() use %$1s %s2s to be really sure, even though it seems to be a case where the order of substitution will never be swapped.

Display existing updatefreq

when user is editing an alias type that uses the subnet CIDR field as the URL table update frequency.
Forum: https://forum.pfsense.org/index.php?topic=105457.0

Firewall / Aliases / Edit - Pattern

Address field is used for a wide variety of input types. Including URLs which require a much greater character set acceptance.

Merge pull request #2454 from phil-davis/patch-2

diag_testport change some tabs to space

diag_testport alert message logic re-factoring

as suggested by @rbgarga

Merge pull request #2456 from phil-davis/gt2

Merge pull request #2458 from phil-davis/gt3

Merge pull request #2460 from NOYB/Firewall_/_Schedules_/_Edit_-_Add_Minutes_45

Merge pull request #2461 from NewEraCracker/php-standards

fix typo

s/schedule/alias

Alias name consistency in Firewall alias edit and schedules edit.

Minor corrections to guiconfig.inc

Set logarr as array() per default, default invert to empty string, improve variable representation within strings

Firewall / Schedules / Edit - Add Minutes 45

Show interface description in traffic graph widget settings

Forum: https://forum.pfsense.org/index.php?topic=105448.0

Test for an array here to avoid an error if the var isn't an array

Put this htmlspecialchars back, I found a better workaround for the inconsistent handling of checkboxes in packages.

Merge pull request #2458 from phil-davis/patch-5

Internationalize edit and exec

Note: in the end, edit.php has only whitespace format changes.

Fix easyrule fbegin.inc echoed text

If you manually navigate directly to easyrule.php you get a bit of rubbish text displayed before the actual message about "This is the Easy Rule status page...". That is due to having too many closing PHP tags. Also, fbegin.inc does not need to be included anyway....

Internationalize remaining diag* code

Cleanup of diag_traceroute

1) Internationalize
2) If there was a problem, then display it with print_info_box() up the top of the page.
3) Redisplay the user-selected IP protocol and source IP after a test. Previously those user selections always got reset to IPv4, any....

Rationalize message display on diag_testport

1) The logic of the various tests that determined which messages were displayed was all a bit odd, and there were ways that things could happen and no message was displayed. Now it displays the "warning" information message the first time, and 1 of the 4 possible result messages depending on the result status and if showtest was on....

Merge pull request #2451 from NOYB/Status_/_System_Logs_-_Raw_Mode_Search_Inversion

Fix inconsistencies in Form_Input

renamed get_type to getType
fix capitalisation in getTagName

Status / System Logs - Raw Mode Search Inversion

Add search inversion to dump_clog and dump_clog_no_table functions for raw mode logs filter.

Final Fixd #5774

Temporarily fixed #5774

Don't run the checkbox label through htmlspecialchars, it breaks several packages.

Don't automatically run strings that are too long through gettext here.

Allow /31 to be used for CARP IPs. Ticket #5533

Reverting change of label. It broke the display

Revise sorting to accommodate firewall logs name (logs)

Fix graph scale setting

Reverting #5771 - No longer required

Fix typo

Fixed #5771
EXCEPT that the link in the help text does not point to the correct place (yet)

Merge pull request #2448 from phil-davis/gt1

Internationalization batch 1

Display additional ooptions if value not empty

Merge pull request #2447 from phil-davis/patch-7

Merge pull request #2446 from phil-davis/patch-6

Fixed #5772

Internationalization of diag_defaults

A couple of typical fixes here:
1) Actually wrap the "Are you sure...?" question in gettext()
2) Use a single gettext() call combined with sprintf() and %s etc to construct a sentence in a single go.
3) Use %s rather than just appending a variable at the end of a sentence of text. That way there is no assumption that the variable text must go at the end in every language....

diag_confbak make a single gettext

Sentences that are constructed in pieces like this are a potential problem for translation, if the target language needs to use a different grammatical word order. e.g. in Nepali we would say datetime-dekhi datetime-samma (datetime-from datetime-to)....

Fixes some hide/show issues. An lucky bug in 2.2 was not duplicated in 2.3 so the page operated as written rather that as desired.

Merge pull request #2445 from phil-davis/patch-5

Merge pull request #2444 from phil-davis/patch-3

diag_confbak move tab_array code above diff display

At the moment the tabs "Config History" and "Backup/Restore" jump down the page below the config diff listing when a diff is displayed.
It seems better to me that the tab text stays where it is and the diff listing comes directly below it.

diag_confbak fix typo in class name

Fix product_name syntax problem in diag_backup

Notice that the old line had $g['[product_name'] - a bonus "[" - that caused the product name to not actually appear in the output.

In fixing that, I also wrapped this in sprintf() - that makes it more flexible for translation into languages where the word order of an instruction like this does not start with the verb.

Encode DHCP/DHCPv6 server additional BOOTP text options before save to XML to preserve data. It fixes #5623

Reduced header font size

Correct failure banner color

Remove unneeded var

Simplify HTML

Bootstrap style select element

Fix reboot after upgrade

HTML Compliance - VPN / IPsec / Tunnel / Edit Phase 1

End tag div seen, but there were open elements.
Unclosed element form.
<form action="vpn_ipsec_phase1.php" method="post" name="iform" id="iform">

Display correct page tabs during firmware update

Make sure $code¹ exist

Remove extra $

Should make more sense like this

Merge remote-tracking branch 'upstream/master' into strpos-fixes

Conflicts:
src/usr/local/www/pkg_mgr_install.php

Use strict comparison operators when checking strpos result

int(0) is a valid result and should not be confused with bool(false). This change will make code more future-proof. See https://secure.php.net/manual/en/function.strpos.php

Revise reboot on upgrade

Add panel heading, and make filter panel collapsible

Merge pull request #2440 from phil-davis/panel-heading

Revised reboot detection

Consistent panel-heading h2

Make all the panel-heading uses also have consistent <h2
class="panel-title"> so they all display the same size.
Forum https://forum.pfsense.org/index.php?topic=105275.0

Merge pull request #2439 from phil-davis/patch-3

Internationalize more text in diag_reboot

Internationalize more text in diag_halt

while I was looking at the panel-heading stuff, I noticed that there are whole chunks of text here that have no gettext() wrapper.

Merge pull request #2437 from NewEraCracker/php-echo-to-short

Ajax fix

Revised to handle firmware update that does not require reboot